[jira] [Commented] (METRON-1463) Adjust the groupings and shuffles in enrichment to be more efficient

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/METRON-1463?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16378711#comment-16378711 ] 

ASF GitHub Bot commented on METRON-1463:
----------------------------------------

GitHub user cestella opened a pull request:

    https://github.com/apache/metron/pull/944

    METRON-1463: Adjust the groupings and shuffles in enrichment to be more efficient

    ## Contributor Comments
    Currently there are some deficiencies in our grouping approach in the enrichment topology:
    
    * We have field grouping by key in places where we need LOCAL_OR_SHUFFLE groupings
    * We have shuffle groupings in places where we need LOCAL_OR_SHUFFLE groupings
    * We have field groupings by key in places where we need field grouping by message (specifically in the connections from the splitter to the enrichments).
      * Field grouping by key, as we had before, ensured that we had fewer cache hits as opposed to field grouping by message.
    
    To test this, just run things up in full-dev and ensure that data continues to flow.
    
    
    ## Pull Request Checklist
    
    Thank you for submitting a contribution to Apache Metron.  
    Please refer to our [Development Guidelines](https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=61332235) for the complete guide to follow for contributions.  
    Please refer also to our [Build Verification Guidelines](https://cwiki.apache.org/confluence/display/METRON/Verifying+Builds?show-miniview) for complete smoke testing guides.  
    
    
    In order to streamline the review of the contribution we ask you follow these guidelines and ask you to double check the following:
    
    ### For all changes:
    - [x] Is there a JIRA ticket associated with this PR? If not one needs to be created at [Metron Jira](https://issues.apache.org/jira/browse/METRON/?selectedTab=com.atlassian.jira.jira-projects-plugin:summary-panel).
    - [x] Does your PR title start with METRON-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
    - [x] Has your PR been rebased against the latest commit within the target branch (typically master)?
    
    
    ### For code changes:
    - [x] Have you included steps to reproduce the behavior or problem that is being changed or addressed?
    - [x] Have you included steps or a guide to how the change may be verified and tested manually?
    - [x] Have you ensured that the full suite of tests and checks have been executed in the root metron folder via:
      ```
      mvn -q clean integration-test install && dev-utilities/build-utils/verify_licenses.sh 
      ```
    
    - [x] Have you written or updated unit tests and or integration tests to verify your changes?
    - [x] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?
    - [x] Have you verified the basic functionality of the build by building and running locally with Vagrant full-dev environment or the equivalent?
    
    ### For documentation related changes:
    - [x] Have you ensured that format looks appropriate for the output in which it is rendered by building and verifying the site-book? If not then run the following commands and the verify changes via `site-book/target/site/index.html`:
    
      ```
      cd site-book
      mvn site
      ```
    
    #### Note:
    Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.
    It is also recommended that [travis-ci](https://travis-ci.org) is set up for your personal repository such that your branches are built there before submitting a pull request.


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/cestella/incubator-metron better_grouping_in_splitjoin

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/metron/pull/944.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #944
    
----
commit dd8821af912071e357c42c852361292c7c2c655c
Author: cstella <ce...@...>
Date:   2018-02-27T14:28:00Z

    Adjusted groupings to be local or shuffle

----


> Adjust the groupings and shuffles in enrichment to be more efficient
> --------------------------------------------------------------------
>
>                 Key: METRON-1463
>                 URL: https://issues.apache.org/jira/browse/METRON-1463
>             Project: Metron
>          Issue Type: Improvement
>            Reporter: Casey Stella
>            Priority: Major
>
> Currently there are some deficiencies in our grouping approach in the enrichment topology:
>  * We have field grouping by key in places where we need LOCAL_OR_SHUFFLE groupings
>  * We have shuffle groupings in places where we need LOCAL_OR_SHUFFLE groupings
>  * We have field groupings by key in places where we need field grouping by message (specifically in the connections from the splitter to the enrichments).



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)