You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hive.apache.org by "Hive QA (Jira)" <ji...@apache.org> on 2019/11/01 08:09:00 UTC

[jira] [Commented] (HIVE-22274) Upgrade Calcite version to 1.21.0

    [ https://issues.apache.org/jira/browse/HIVE-22274?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16964701#comment-16964701 ] 

Hive QA commented on HIVE-22274:
--------------------------------

| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} @author {color} | {color:green}  0m  0s{color} | {color:green} The patch does not contain any @author tags. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue}  1m 43s{color} | {color:blue} Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  7m 18s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  8m 46s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  3m 29s{color} | {color:green} master passed {color} |
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue}  4m  6s{color} | {color:blue} ql in master has 1545 extant Findbugs warnings. {color} |
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue}  0m 31s{color} | {color:blue} accumulo-handler in master has 21 extant Findbugs warnings. {color} |
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue}  0m 34s{color} | {color:blue} hbase-handler in master has 15 extant Findbugs warnings. {color} |
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue}  0m 39s{color} | {color:blue} itests/hive-unit in master has 2 extant Findbugs warnings. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  8m 43s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue}  0m 25s{color} | {color:blue} Maven dependency ordering for patch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  9m 51s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  8m 47s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green}  8m 47s{color} | {color:green} the patch passed {color} |
| {color:red}-1{color} | {color:red} checkstyle {color} | {color:red}  0m 42s{color} | {color:red} ql: The patch generated 37 new + 329 unchanged - 12 fixed = 366 total (was 341) {color} |
| {color:red}-1{color} | {color:red} checkstyle {color} | {color:red}  2m  2s{color} | {color:red} root: The patch generated 38 new + 381 unchanged - 12 fixed = 419 total (was 393) {color} |
| {color:red}-1{color} | {color:red} checkstyle {color} | {color:red}  0m 18s{color} | {color:red} itests/hive-unit: The patch generated 1 new + 52 unchanged - 0 fixed = 53 total (was 52) {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green}  0m  0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} xml {color} | {color:green}  0m  2s{color} | {color:green} The patch has no ill-formed XML file. {color} |
| {color:red}-1{color} | {color:red} findbugs {color} | {color:red}  4m 17s{color} | {color:red} ql generated 8 new + 1542 unchanged - 3 fixed = 1550 total (was 1545) {color} |
| {color:red}-1{color} | {color:red} javadoc {color} | {color:red}  1m  2s{color} | {color:red} ql generated 4 new + 96 unchanged - 4 fixed = 100 total (was 100) {color} |
| {color:red}-1{color} | {color:red} javadoc {color} | {color:red}  6m 35s{color} | {color:red} root generated 4 new + 333 unchanged - 4 fixed = 337 total (was 337) {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green}  0m 19s{color} | {color:green} The patch does not generate ASF License warnings. {color} |
| {color:black}{color} | {color:black} {color} | {color:black} 74m 52s{color} | {color:black} {color} |
\\
\\
|| Reason || Tests ||
| FindBugs | module:ql |
|  |  Dead store to joinInfo in org.apache.hadoop.hive.ql.optimizer.calcite.HiveRelFactories$HiveJoinFactoryImpl.createJoin(RelNode, RelNode, RexNode, Set, JoinRelType, boolean)  At HiveRelFactories.java:org.apache.hadoop.hive.ql.optimizer.calcite.HiveRelFactories$HiveJoinFactoryImpl.createJoin(RelNode, RelNode, RexNode, Set, JoinRelType, boolean)  At HiveRelFactories.java:[line 170] |
|  |  Dead store to joinInfo in org.apache.hadoop.hive.ql.optimizer.calcite.HiveRelFactories$HiveJoinFactoryImpl.createJoin(RelNode, RelNode, RexNode, JoinRelType, Set, boolean)  At HiveRelFactories.java:org.apache.hadoop.hive.ql.optimizer.calcite.HiveRelFactories$HiveJoinFactoryImpl.createJoin(RelNode, RelNode, RexNode, JoinRelType, Set, boolean)  At HiveRelFactories.java:[line 157] |
|  |  Dead store to joinInfo in org.apache.hadoop.hive.ql.optimizer.calcite.HiveRelFactories$HiveSemiJoinFactoryImpl.createSemiJoin(RelNode, RelNode, RexNode)  At HiveRelFactories.java:org.apache.hadoop.hive.ql.optimizer.calcite.HiveRelFactories$HiveSemiJoinFactoryImpl.createSemiJoin(RelNode, RelNode, RexNode)  At HiveRelFactories.java:[line 187] |
|  |  Dead store to rightKeys in org.apache.hadoop.hive.ql.optimizer.calcite.rules.HiveRelDecorrelator.decorrelateRel(LogicalCorrelate)  At HiveRelDecorrelator.java:org.apache.hadoop.hive.ql.optimizer.calcite.rules.HiveRelDecorrelator.decorrelateRel(LogicalCorrelate)  At HiveRelDecorrelator.java:[line 1453] |
|  |  Dead store to leftKeys in org.apache.hadoop.hive.ql.optimizer.calcite.rules.HiveRelDecorrelator.decorrelateRel(LogicalCorrelate)  At HiveRelDecorrelator.java:org.apache.hadoop.hive.ql.optimizer.calcite.rules.HiveRelDecorrelator.decorrelateRel(LogicalCorrelate)  At HiveRelDecorrelator.java:[line 1452] |
|  |  Redundant nullcheck of lefts, which is known to be non-null in org.apache.hadoop.hive.ql.optimizer.calcite.stats.HiveRelMdSize.averageColumnSizes(HiveSemiJoin, RelMetadataQuery)  Redundant null check at HiveRelMdSize.java:is known to be non-null in org.apache.hadoop.hive.ql.optimizer.calcite.stats.HiveRelMdSize.averageColumnSizes(HiveSemiJoin, RelMetadataQuery)  Redundant null check at HiveRelMdSize.java:[line 99] |
|  |  Possible null pointer dereference of b in org.apache.hadoop.hive.ql.optimizer.calcite.translator.ASTBuilder.join(ASTNode, ASTNode, JoinRelType, ASTNode) on exception path  Dereferenced at ASTBuilder.java:b in org.apache.hadoop.hive.ql.optimizer.calcite.translator.ASTBuilder.join(ASTNode, ASTNode, JoinRelType, ASTNode) on exception path  Dereferenced at ASTBuilder.java:[line 179] |
|  |  Switch statement found in org.apache.hadoop.hive.ql.optimizer.calcite.translator.ASTBuilder.join(ASTNode, ASTNode, JoinRelType, ASTNode) where default case is missing  At ASTBuilder.java:ASTNode, JoinRelType, ASTNode) where default case is missing  At ASTBuilder.java:[lines 161-175] |
\\
\\
|| Subsystem || Report/Notes ||
| Optional Tests |  asflicense  javac  javadoc  findbugs  checkstyle  compile  xml  |
| uname | Linux hiveptest-server-upstream 3.16.0-4-amd64 #1 SMP Debian 3.16.43-2+deb8u5 (2017-09-19) x86_64 GNU/Linux |
| Build tool | maven |
| Personality | /data/hiveptest/working/yetus_PreCommit-HIVE-Build-19246/dev-support/hive-personality.sh |
| git revision | master / 9490264 |
| Default Java | 1.8.0_111 |
| findbugs | v3.0.1 |
| checkstyle | http://104.198.109.242/logs//PreCommit-HIVE-Build-19246/yetus/diff-checkstyle-ql.txt |
| checkstyle | http://104.198.109.242/logs//PreCommit-HIVE-Build-19246/yetus/diff-checkstyle-root.txt |
| checkstyle | http://104.198.109.242/logs//PreCommit-HIVE-Build-19246/yetus/diff-checkstyle-itests_hive-unit.txt |
| findbugs | http://104.198.109.242/logs//PreCommit-HIVE-Build-19246/yetus/new-findbugs-ql.html |
| javadoc | http://104.198.109.242/logs//PreCommit-HIVE-Build-19246/yetus/diff-javadoc-javadoc-ql.txt |
| javadoc | http://104.198.109.242/logs//PreCommit-HIVE-Build-19246/yetus/diff-javadoc-javadoc-root.txt |
| modules | C: ql accumulo-handler hbase-handler . itests/hive-unit U: . |
| Console output | http://104.198.109.242/logs//PreCommit-HIVE-Build-19246/yetus.txt |
| Powered by | Apache Yetus    http://yetus.apache.org |


This message was automatically generated.



> Upgrade Calcite version to 1.21.0
> ---------------------------------
>
>                 Key: HIVE-22274
>                 URL: https://issues.apache.org/jira/browse/HIVE-22274
>             Project: Hive
>          Issue Type: Task
>    Affects Versions: 3.1.2
>            Reporter: Steve Carlin
>            Assignee: Steve Carlin
>            Priority: Major
>              Labels: pull-request-available
>         Attachments: HIVE-22274.1.patch, HIVE-22274.10.patch, HIVE-22274.10.patch, HIVE-22274.11.patch, HIVE-22274.12.patch, HIVE-22274.13.patch, HIVE-22274.15.patch, HIVE-22274.16.patch, HIVE-22274.17.patch, HIVE-22274.18.patch, HIVE-22274.2.patch, HIVE-22274.3.patch, HIVE-22274.4.patch, HIVE-22274.5.patch, HIVE-22274.6.patch, HIVE-22274.7.patch, HIVE-22274.8.patch, HIVE-22274.9.patch, HIVE-22274.patch
>
>          Time Spent: 1h
>  Remaining Estimate: 0h
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)