[GitHub] ahshokry commented on a change in pull request #283: Adding Periodic Advertising Feature

[GitBox <gi...@apache.org>]

ahshokry commented on a change in pull request #283: Adding Periodic Advertising Feature
URL: https://github.com/apache/mynewt-nimble/pull/283#discussion_r247343618
 
 

 ##########
 File path: nimble/host/include/host/ble_gap.h
 ##########
 @@ -913,6 +966,28 @@ int ble_gap_ext_adv_stop(uint8_t instance);
 int ble_gap_ext_adv_set_data(uint8_t instance, struct os_mbuf *data);
 int ble_gap_ext_adv_rsp_set_data(uint8_t instance, struct os_mbuf *data);
 int ble_gap_ext_adv_remove(uint8_t instance);
+
+#if MYNEWT_VAL(BLE_PERIODIC_ADV)
+/* Periodic Advertising */
+int ble_gap_per_adv_configure(uint8_t instance, const struct ble_gap_per_adv_params *params);
+int ble_gap_per_adv_start(uint8_t instance);
+int ble_gap_per_adv_stop(uint8_t instance);
+int ble_gap_per_adv_set_data(uint8_t instance, struct os_mbuf *data);
+int ble_gap_per_adv_create_sync (uint8_t filter_policy,
 
 Review comment:
   Thanks for the note.
   
   The idea is that sync established event can never be received without having extended scanning first !
   
   The point here is that even if the application is only interested in establishing a sync with a periodic advertising, this can never happen without having an extended scanning enabled at the first place, so ble_gap_ext_disc will have been called before, so the gap event callback should be already set.
   
   After the sync is established, then the application can disable extended scanning and live only with periodic scanning. At this time, the callback is already set since the time of extended scanning.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services