You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2022/08/22 15:05:23 UTC
[GitHub] [spark] Yikun opened a new pull request, #37618: Revert "[SPARK-40165][BUILD] Update test plugins to latest versions"
Yikun opened a new pull request, #37618:
URL: https://github.com/apache/spark/pull/37618
### What changes were proposed in this pull request?
This reverts commit 3ed382f391911ec4a79fb204f4986728017dfa4a.
### Why are the changes needed?
This patch cause the error like:
```
[error] /home/runner/work/spark/spark/sql/hive-thriftserver/src/main/java/org/apache/hive/service/auth/HttpAuthUtils.java:36:1: error: package org.apache.http.protocol does not exist
[error] import org.apache.http.protocol.BasicHttpContext;
[error] ^
[error] /home/runner/work/spark/spark/sql/hive-thriftserver/src/main/java/org/apache/hive/service/auth/HttpAuthUtils.java:156:1: error: cannot find symbol
[error] private final HttpContext httpContext;
[error] ^ symbol: class HttpContext
[error] location: class HttpKerberosClientAction
[error] 3 errors
```
### Does this PR introduce _any_ user-facing change?
No
### How was this patch tested?
CI passed, especially, 2.13 passed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] LuciferYang commented on pull request #37618: Revert "[SPARK-40165][BUILD] Update test plugins to latest versions"
Posted by GitBox <gi...@apache.org>.
LuciferYang commented on PR #37618:
URL: https://github.com/apache/spark/pull/37618#issuecomment-1222510382
Wait a little moment , I only revert `maven-dependency-plugin` in https://github.com/LuciferYang/spark/runs/7955190045?check_suite_focus=true
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] LuciferYang commented on pull request #37618: Revert "[SPARK-40165][BUILD] Update test plugins to latest versions"
Posted by GitBox <gi...@apache.org>.
LuciferYang commented on PR #37618:
URL: https://github.com/apache/spark/pull/37618#issuecomment-1222517483
> > And It seems strange that sbt local builds can also succeed :(
>
> You perhaps want to cleanup `org.apache.maven.plugins` and `org.scalacheck` in your local maven repo.
Thanks, let me try this
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] Yikun commented on pull request #37618: Revert "[SPARK-40165][BUILD] Update test plugins to latest versions"
Posted by GitBox <gi...@apache.org>.
Yikun commented on PR #37618:
URL: https://github.com/apache/spark/pull/37618#issuecomment-1222515227
> And It seems strange that sbt local builds can also succeed :(
You perhaps want to cleanup `org.apache.maven.plugins` and `org.scalacheck` in your local maven repo.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] LuciferYang commented on pull request #37618: Revert "[SPARK-40165][BUILD] Update test plugins to latest versions"
Posted by GitBox <gi...@apache.org>.
LuciferYang commented on PR #37618:
URL: https://github.com/apache/spark/pull/37618#issuecomment-1222500415
Can we just revert `maven-dependency-plugin`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] LuciferYang commented on pull request #37618: Revert "[SPARK-40165][BUILD] Update test plugins to latest versions"
Posted by GitBox <gi...@apache.org>.
LuciferYang commented on PR #37618:
URL: https://github.com/apache/spark/pull/37618#issuecomment-1222548678
> @LuciferYang I'm not sure about this, but if one PR once breaked CI, we'd better revert the whole change to recover CI first and then re-submit new one.
+1, Agree
On the other hand, only revert ` maven-dependency-plugin` seems also pass, but I haven't found root cause yet.
https://github.com/LuciferYang/spark/runs/7955190045?check_suite_focus=true
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] LuciferYang commented on pull request #37618: Revert "[SPARK-40165][BUILD] Update test plugins to latest versions"
Posted by GitBox <gi...@apache.org>.
LuciferYang commented on PR #37618:
URL: https://github.com/apache/spark/pull/37618#issuecomment-1222512151
And It seems strange that sbt local builds can also succeed :(
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] Yikun commented on pull request #37618: Revert "[SPARK-40165][BUILD] Update test plugins to latest versions"
Posted by GitBox <gi...@apache.org>.
Yikun commented on PR #37618:
URL: https://github.com/apache/spark/pull/37618#issuecomment-1222503447
@LuciferYang I'm not sure about this, but if one PR once breaked CI, we'd better revert the whole change to recover CI first and then re-submit new one.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] Yikun commented on pull request #37618: Revert "[SPARK-40165][BUILD] Update test plugins to latest versions"
Posted by GitBox <gi...@apache.org>.
Yikun commented on PR #37618:
URL: https://github.com/apache/spark/pull/37618#issuecomment-1222505160
At least 2.13 CI have been passed, let's wait for other CI to be green, then merge this first.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] Yikun commented on pull request #37618: Revert "[SPARK-40165][BUILD] Update test plugins to latest versions"
Posted by GitBox <gi...@apache.org>.
Yikun commented on PR #37618:
URL: https://github.com/apache/spark/pull/37618#issuecomment-1222564419
It's time to sleep:
- Let's merge this PR to recover CI after this PR green
- We might want to remove `restore-keys` to improve infra to catch similar failure in time.
- After `restore-keys` apply, then re-submit https://github.com/apache/spark/commit/3ed382f391911ec4a79fb204f4986728017dfa4a , make sure cache missed and is not restore, we might see CI failed then fix issue.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on pull request #37618: Revert "[SPARK-40165][BUILD] Update test plugins to latest versions"
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on PR #37618:
URL: https://github.com/apache/spark/pull/37618#issuecomment-1222616139
All tests passed including Scala 2.13. Merged to master.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun closed pull request #37618: Revert "[SPARK-40165][BUILD] Update test plugins to latest versions"
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun closed pull request #37618: Revert "[SPARK-40165][BUILD] Update test plugins to latest versions"
URL: https://github.com/apache/spark/pull/37618
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] Yikun commented on pull request #37618: Revert "[SPARK-40165][BUILD] Update test plugins to latest versions"
Posted by GitBox <gi...@apache.org>.
Yikun commented on PR #37618:
URL: https://github.com/apache/spark/pull/37618#issuecomment-1222539954
```yaml
key: build-${{ hashFiles('**/pom.xml', 'project/build.properties', 'build/mvn', 'build/sbt', 'build/sbt-launch-lib.bash', 'build/spark-build-info') }}
restore-keys: |
build-${{ hashFiles('**/pom.xml', 'project/build.properties', 'build/mvn', 'build/sbt', 'build/sbt-launch-lib.bash', 'build/spark-build-info') }}
```
emmm...BTW, to avoid this kind of problem happened again, I think `restore-keys` should be match strictly to restore cache, otherwise it will use recent `build-` cache, once local repo cache has some dependency error, the CI will not figure out and then give a fake green.
Need some inputs from @HyukjinKwon @dongjoon-hyun WDYT?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org