You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@doris.apache.org by "morrySnow (via GitHub)" <gi...@apache.org> on 2025/10/14 01:49:46 UTC

Re: [PR] [fix](function) Fix wrong calculation of timestampdiff of datetimev1 [doris]

morrySnow commented on code in PR #56893:
URL: https://github.com/apache/doris/pull/56893#discussion_r2427702468


##########
fe/fe-core/src/main/java/org/apache/doris/nereids/trees/expressions/functions/scalar/Now.java:
##########
@@ -37,7 +36,7 @@
 public class Now extends DateTimeWithPrecision implements ExplicitlyCastableSignature {
 
     public static final List<FunctionSignature> SIGNATURES = ImmutableList.of(
-            FunctionSignature.ret(DateTimeType.INSTANCE).args(),
+            FunctionSignature.ret(DateTimeV2Type.SYSTEM_DEFAULT).args(),

Review Comment:
   should not include breaking (incompatible) upgrades.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org