[GitHub] [spark] dbtsai commented on a change in pull request #26929: [SPARK-30289][SQL] DSv2's partitioning should not accept nested columns

[GitBox <gi...@apache.org>]

dbtsai commented on a change in pull request #26929: [SPARK-30289][SQL] DSv2's partitioning should not accept nested columns
URL: https://github.com/apache/spark/pull/26929#discussion_r359103698
 
 

 ##########
 File path: sql/catalyst/src/test/scala/org/apache/spark/sql/connector/InMemoryTable.scala
 ##########
 @@ -59,8 +60,11 @@ class InMemoryTable(
 
   def rows: Seq[InternalRow] = dataMap.values.flatMap(_.rows).toSeq
 
-  private val partFieldNames = partitioning.flatMap(_.references).toSeq.flatMap(_.fieldNames)
 
 Review comment:
   The nested columns were flatten out here, and then we looked them up against top level columns resulting `IllegalArgumentException`.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org