You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@kvrocks.apache.org by GitBox <gi...@apache.org> on 2022/06/06 07:39:40 UTC
[GitHub] [incubator-kvrocks-website] tisonkun opened a new pull request, #5: introduce docusaurus framework
tisonkun opened a new pull request, #5:
URL: https://github.com/apache/incubator-kvrocks-website/pull/5
You can checkout and run at local with `yarn start`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@kvrocks.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kvrocks-website] tisonkun commented on pull request #5: introduce docusaurus framework
Posted by GitBox <gi...@apache.org>.
tisonkun commented on PR #5:
URL: https://github.com/apache/incubator-kvrocks-website/pull/5#issuecomment-1147164350
@git-hulk thanks for your review. I'll do some random manual test and merge this PR later.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@kvrocks.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kvrocks-website] tisonkun commented on pull request #5: introduce docusaurus framework
Posted by GitBox <gi...@apache.org>.
tisonkun commented on PR #5:
URL: https://github.com/apache/incubator-kvrocks-website/pull/5#issuecomment-1147165015
> OK, I'm also unfamiliar with that. Will contact the original designer to help.
SGTM. It can be a follow-up later. Looking forward to see the original designer come back to the community :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@kvrocks.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kvrocks-website] git-hulk commented on pull request #5: introduce docusaurus framework
Posted by GitBox <gi...@apache.org>.
git-hulk commented on PR #5:
URL: https://github.com/apache/incubator-kvrocks-website/pull/5#issuecomment-1147170269
https://github.com/tianlingyu1997 is the original designer, but seems he/she's NOT active in GitHub. I'll try to contact he/she offline, hope it won't block this PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@kvrocks.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kvrocks-website] git-hulk commented on pull request #5: introduce docusaurus framework
Posted by GitBox <gi...@apache.org>.
git-hulk commented on PR #5:
URL: https://github.com/apache/incubator-kvrocks-website/pull/5#issuecomment-1147174988
OK, agreed. Maybe I can help on this part.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@kvrocks.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kvrocks-website] tisonkun commented on pull request #5: introduce docusaurus framework
Posted by GitBox <gi...@apache.org>.
tisonkun commented on PR #5:
URL: https://github.com/apache/incubator-kvrocks-website/pull/5#issuecomment-1147156020
@git-hulk the logo svg and favicon isn't quite good-look, though. I'm unfamiliar with draw a logo and maybe you can help on creating a better version.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@kvrocks.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kvrocks-website] tisonkun commented on pull request #5: introduce docusaurus framework
Posted by GitBox <gi...@apache.org>.
tisonkun commented on PR #5:
URL: https://github.com/apache/incubator-kvrocks-website/pull/5#issuecomment-1147156515
<img width="1792" alt="image" src="https://user-images.githubusercontent.com/18818196/172119329-f9cb28e7-4d2a-4e4f-a88f-a2b724bb5f3a.png">
Note that the favicon has been around with white background, and the navbar logo is a bit small.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@kvrocks.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kvrocks-website] tisonkun commented on pull request #5: introduce docusaurus framework
Posted by GitBox <gi...@apache.org>.
tisonkun commented on PR #5:
URL: https://github.com/apache/incubator-kvrocks-website/pull/5#issuecomment-1147173098
@git-hulk you're welcome. Now it's clear (to me, at least) to add new pages (user document, dev document, community infos, blogs) under the corresponding category. I'm going to move existing contents from blogs and wikis to our website in the next weeks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@kvrocks.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kvrocks-website] git-hulk commented on pull request #5: introduce docusaurus framework
Posted by GitBox <gi...@apache.org>.
git-hulk commented on PR #5:
URL: https://github.com/apache/incubator-kvrocks-website/pull/5#issuecomment-1147172300
copy that
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@kvrocks.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kvrocks-website] git-hulk commented on pull request #5: introduce docusaurus framework
Posted by GitBox <gi...@apache.org>.
git-hulk commented on PR #5:
URL: https://github.com/apache/incubator-kvrocks-website/pull/5#issuecomment-1147160341
> @git-hulk the logo svg and favicon isn't quite good-look, though. I'm unfamiliar with draw a logo and maybe you can help on creating a better version.
OK, I'm also unfamiliar with that. Will contact the original designer to help.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@kvrocks.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kvrocks-website] git-hulk commented on pull request #5: introduce docusaurus framework
Posted by GitBox <gi...@apache.org>.
git-hulk commented on PR #5:
URL: https://github.com/apache/incubator-kvrocks-website/pull/5#issuecomment-1147158053
I tried it on my side, looks really great to me.
<img width="1431" alt="image" src="https://user-images.githubusercontent.com/4987594/172119689-deedd875-0e83-4b60-8828-98bfb5ea1028.png">
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@kvrocks.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kvrocks-website] tisonkun commented on pull request #5: introduce docusaurus framework
Posted by GitBox <gi...@apache.org>.
tisonkun commented on PR #5:
URL: https://github.com/apache/incubator-kvrocks-website/pull/5#issuecomment-1147171416
> hope it won't block this PR.
@git-hulk I'm going to merge this PR now. Logo issue should not be a blocker - we can improve it later.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@kvrocks.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kvrocks-website] tisonkun merged pull request #5: introduce docusaurus framework
Posted by GitBox <gi...@apache.org>.
tisonkun merged PR #5:
URL: https://github.com/apache/incubator-kvrocks-website/pull/5
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@kvrocks.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org