You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Alexey Serbin (Code Review)" <ge...@cloudera.org> on 2024/07/20 01:24:32 UTC
[kudu-CR] [util] a small clean up on the Throttler class
Alexey Serbin has uploaded this change for review. ( http://gerrit.cloudera.org:8080/21603
Change subject: [util] a small clean up on the Throttler class
......................................................................
[util] a small clean up on the Throttler class
The motivation behind this patch was an idea of making the API of the
Throttler class more robust after reviewing a changelist that used the
functionality of the Throttler. I have doubts that the current
implementation of the Throttler behaves the way one would expect
(there is just spotty test coverage for that), but it's another story.
Change-Id: I43d60323c3d84da896c1a5429dfb7d461a24f9b2
---
M src/kudu/tablet/tablet.cc
M src/kudu/tools/table_scanner.cc
M src/kudu/tools/tool_action_local_replica.cc
M src/kudu/tserver/tablet_copy_client-test.cc
M src/kudu/tserver/tablet_copy_client.cc
M src/kudu/util/throttler-test.cc
M src/kudu/util/throttler.cc
M src/kudu/util/throttler.h
8 files changed, 89 insertions(+), 55 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/03/21603/1
--
To view, visit http://gerrit.cloudera.org:8080/21603
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I43d60323c3d84da896c1a5429dfb7d461a24f9b2
Gerrit-Change-Number: 21603
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <al...@apache.org>
[kudu-CR] [util] a small clean up on the Throttler class
Posted by "Yingchun Lai (Code Review)" <ge...@cloudera.org>.
Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/21603 )
Change subject: [util] a small clean up on the Throttler class
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/21603
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I43d60323c3d84da896c1a5429dfb7d461a24f9b2
Gerrit-Change-Number: 21603
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Yingchun Lai <la...@apache.org>
Gerrit-Comment-Date: Sun, 21 Jul 2024 06:41:08 +0000
Gerrit-HasComments: No
[kudu-CR] [util] a small clean up on the Throttler class
Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21603 )
Change subject: [util] a small clean up on the Throttler class
......................................................................
Patch Set 1:
Build Started http://jenkins.kudu.apache.org/job/pre_commit/313/
--
To view, visit http://gerrit.cloudera.org:8080/21603
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I43d60323c3d84da896c1a5429dfb7d461a24f9b2
Gerrit-Change-Number: 21603
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Sat, 20 Jul 2024 01:24:40 +0000
Gerrit-HasComments: No
[kudu-CR] [util] a small clean up on the Throttler class
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has removed a vote on this change.
Change subject: [util] a small clean up on the Throttler class
......................................................................
Removed Verified-1 by Kudu Jenkins (120)
--
To view, visit http://gerrit.cloudera.org:8080/21603
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: deleteVote
Gerrit-Change-Id: I43d60323c3d84da896c1a5429dfb7d461a24f9b2
Gerrit-Change-Number: 21603
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Yingchun Lai <la...@apache.org>
[kudu-CR] [util] a small clean up on the Throttler class
Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21603 )
Change subject: [util] a small clean up on the Throttler class
......................................................................
Patch Set 1: Verified-1
Build Failed
http://jenkins.kudu.apache.org/job/pre_commit/313/ : FAILURE
--
To view, visit http://gerrit.cloudera.org:8080/21603
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I43d60323c3d84da896c1a5429dfb7d461a24f9b2
Gerrit-Change-Number: 21603
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Yingchun Lai <la...@apache.org>
Gerrit-Comment-Date: Sat, 20 Jul 2024 03:10:08 +0000
Gerrit-HasComments: No
[kudu-CR] [util] a small clean up on the Throttler class
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/21603 )
Change subject: [util] a small clean up on the Throttler class
......................................................................
[util] a small clean up on the Throttler class
The motivation behind this patch was an idea of making the API of the
Throttler class more robust after reviewing a changelist that used the
functionality of the Throttler. I have doubts that the current
implementation of the Throttler behaves the way one would expect
(there is just spotty test coverage for that), but it's another story.
Change-Id: I43d60323c3d84da896c1a5429dfb7d461a24f9b2
Reviewed-on: http://gerrit.cloudera.org:8080/21603
Reviewed-by: Yingchun Lai <la...@apache.org>
Tested-by: Alexey Serbin <al...@apache.org>
---
M src/kudu/tablet/tablet.cc
M src/kudu/tools/table_scanner.cc
M src/kudu/tools/tool_action_local_replica.cc
M src/kudu/tserver/tablet_copy_client-test.cc
M src/kudu/tserver/tablet_copy_client.cc
M src/kudu/util/throttler-test.cc
M src/kudu/util/throttler.cc
M src/kudu/util/throttler.h
8 files changed, 89 insertions(+), 55 deletions(-)
Approvals:
Yingchun Lai: Looks good to me, approved
Alexey Serbin: Verified
--
To view, visit http://gerrit.cloudera.org:8080/21603
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I43d60323c3d84da896c1a5429dfb7d461a24f9b2
Gerrit-Change-Number: 21603
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Yingchun Lai <la...@apache.org>
[kudu-CR] [util] a small clean up on the Throttler class
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/21603 )
Change subject: [util] a small clean up on the Throttler class
......................................................................
Patch Set 1: Verified+1
All test failures seem to be solely related to KUDU-3590, which isn't relevant to this patch as-is.
--
To view, visit http://gerrit.cloudera.org:8080/21603
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I43d60323c3d84da896c1a5429dfb7d461a24f9b2
Gerrit-Change-Number: 21603
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Yingchun Lai <la...@apache.org>
Gerrit-Comment-Date: Sun, 21 Jul 2024 16:25:41 +0000
Gerrit-HasComments: No