You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@logging.apache.org by GitBox <gi...@apache.org> on 2021/08/24 18:33:05 UTC

[GitHub] [logging-log4j2] carterkozak commented on a change in pull request #568: Prefer `string.getBytes(Charset)` over `string.getBytes(String)`

carterkozak commented on a change in pull request #568:
URL: https://github.com/apache/logging-log4j2/pull/568#discussion_r695102789



##########
File path: log4j-core/src/main/java/org/apache/logging/log4j/core/layout/AbstractStringLayout.java
##########
@@ -158,17 +148,12 @@ protected static void trimToMaxSize(final StringBuilder stringBuilder) {
     /**
      * The charset for the formatted message.
      */
-    // LOG4J2-1099: Charset cannot be final due to serialization needs, so we serialize as Charset name instead

Review comment:
       This comment was no longer relevant given https://issues.apache.org/jira/browse/LOG4J2-1300 (5c6819530803357c8e580ad5143db4f2a4f33e64)




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@logging.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org