You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudstack.apache.org by GitBox <gi...@apache.org> on 2020/11/19 21:12:03 UTC

[GitHub] [cloudstack] ustcweizhou opened a new pull request #4484: VPC: fix some issues related to multiple public IP ranges and private gateway

ustcweizhou opened a new pull request #4484:
URL: https://github.com/apache/cloudstack/pull/4484


   ### Description
   
   This PR contains 13 commits below
   
   ```
   bugfix #1 vpc: fix ips on wrong interfaces after rebooting vpc vrs
   bugfix #1 vr: Force a restart of keepalived if conntrackd is not running or configuration has changed
   bugfix #2 vpc: Fix remove first public ip will remove all ips on the nic
   bugfix #3 apply ip dessociation before unplugging a nic so ip is marked as add:false in ips.json
   bugfix #2 vpc vr: fix issue if static nat is disabled but still other IP used by lb/pf
   bugfix #4 vpc vr: Do NOT send Nic plug in/out command to Stopped/Stopping VR
   Revert "Handle private gateways more reliably"
   Revert "Add private gateway IP to router initialization config"
   Revert "Fix Policy Based Routing for private gateway static routes (#3604)"
   bugfix #6 vpc vr: Add iptables rules for ACL of private gateway
   bugfix #7 vpc vr: allow servers in private gateway to reach internet via the VPC VR if it is gateway
   bugfix #8 vpc: add rule for traffic between vm and private gateway
   bugfix #9 vpc vr: Add PREROUTING rule for vm with static nat to multiple private gateways
   ```
   
   Here are description of bugs
   (1) ips on wrong interfaces after rebooting vpc vrs
   When add new vpc tier, create private gateway, associated IP in new range to a VPC, nics will be plugged  to VPC VRs.
   However, when reboot(or start) a VPC VR, the nics will be added by order: Public IP (source nat), other Public IP range, private gateway, VPC tiers. so the device_id of nics are different before stopping VR.
   
   I have created a PR for this issue #4467 
   
   (2) remove first public ip will remove all ips on the nic
   When use more public IPs in new public IP range (not same as source nat), a nic will be plugged to VPC VR. All public IPs used by the VPC will be attached to the nic.
   However, when we release the first public IP of the nic, it will remove the nic, all other IPs on the nic will be gone as well.
   
   (3) public ip is not marked as "add: false" in /etc/cloudstack/ips.json when release it.
   When use a public IP in new range to VPC VR, a nic will be plugged to VPC VR.
   When remove the public from VPC, the nic will be unplugged. however, the ip is still marked as "add: true" in /etc/cloudstack/ips.json
   so when we add a new nic to the VPC, the (old) public ip will be added back to the nic.
   
   (4) When a VPC VR is stopped, we cannot add/remove new nic to VPC VR.
   
   (5) Static NAT with multiple public interfaces uses wrong outgoing IP #4234
   This is a regression of the fix for #3604 
   we need to revert the commit "Fix Policy Based Routing for private gateway static routes (#3604)"
   
   (6) There is no ACL rule for private gateway
   This is a regression of the fix for #3402 
   private gateway is changed to 'public' in commit "vpc: set traffic type of private gateway IP to Public to fix ke… (#3851)"
   so we need to add ACL rules.
   
   (7) servers in private gateway cannot reach internet via the VPC VR if it is gateway
   When add private gateway and use VPC as gateway (private gateway IP = gateway IP), the servers in private gateway network cannot reach internet via VPC VR.
   need to add rule to accept packet if VPC VR is used as gateway.
   
   (8) INBOUND rules for traffic between vm and private gateway servers does not work.
   Even rules are added to fix bug (6), the incoming traffic between vm and private gateway network is always accepted.
   for example, if the ACL of vm disallow traffic from private gateway network, vm still accepts traffic from private gateway network.
   need to add rules to check the INBOUND ACL rules.
   
   (9) vm with static nat cannot connect to private gateway network.
   As the fix is reverted to fix (5), the issue described in #3604 is back. 
   this PR introduced another way to fix the issue.
   
   
   ### Types of changes
   
   - [ ] Breaking change (fix or feature that would cause existing functionality to change)
   - [ ] New feature (non-breaking change which adds functionality)
   - [X] Bug fix (non-breaking change which fixes an issue)
   - [ ] Enhancement (improves an existing feature and functionality)
   - [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
   
   ### Feature/Enhancement Scale or Bug Severity
   
   
   #### Bug Severity
   
   - [ ] BLOCKER
   - [X] Critical
   - [ ] Major
   - [ ] Minor
   - [ ] Trivial
   
   
   ### Screenshots (if appropriate):
   
   
   ### How Has This Been Tested?
   <!-- Please describe in detail how you tested your changes. -->
   <!-- Include details of your testing environment, and the tests you ran to -->
   <!-- see how your change affects other areas of the code, etc. -->
   
   
   <!-- Please read the [CONTRIBUTING](https://github.com/apache/cloudstack/blob/master/CONTRIBUTING.md) document -->
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #4484: VPC: fix some issues related to multiple public IP ranges and private gateway

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4484:
URL: https://github.com/apache/cloudstack/pull/4484#issuecomment-731021712


   @DaanHoogland a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #4484: VPC: fix some issues related to multiple public IP ranges and private gateway

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4484:
URL: https://github.com/apache/cloudstack/pull/4484#issuecomment-731371567


   <b>Trillian test result (tid-3223)</b>
   Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
   Total time taken: 30312 seconds
   Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr4484-t3223-kvm-centos7.zip
   Smoke tests completed. 83 look OK, 0 have error(s)
   Only failed tests results shown below:
   
   
   Test | Result | Time (s) | Test File
   --- | --- | --- | ---
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan removed a comment on pull request #4484: VPC: fix some issues related to multiple public IP ranges and private gateway

Posted by GitBox <gi...@apache.org>.
blueorangutan removed a comment on pull request #4484:
URL: https://github.com/apache/cloudstack/pull/4484#issuecomment-732095690


   @DaanHoogland a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #4484: VPC: fix some issues related to multiple public IP ranges and private gateway

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4484:
URL: https://github.com/apache/cloudstack/pull/4484#issuecomment-731039904


   Packaging result: ✔centos7 ✖centos8 ✔debian. JID-2414


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #4484: VPC: fix some issues related to multiple public IP ranges and private gateway

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4484:
URL: https://github.com/apache/cloudstack/pull/4484#issuecomment-732036586


   @DaanHoogland a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] DaanHoogland commented on pull request #4484: VPC: fix some issues related to multiple public IP ranges and private gateway

Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on pull request #4484:
URL: https://github.com/apache/cloudstack/pull/4484#issuecomment-731093307


   @blueorangutan test


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #4484: VPC: fix some issues related to multiple public IP ranges and private gateway

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4484:
URL: https://github.com/apache/cloudstack/pull/4484#issuecomment-732845053


   @rhtyd a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] rhtyd commented on pull request #4484: VPC: fix some issues related to multiple public IP ranges and private gateway

Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #4484:
URL: https://github.com/apache/cloudstack/pull/4484#issuecomment-732012856


   @weizhouapache can you share what tests were done, did you perform any upgrade tests? 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] rhtyd commented on pull request #4484: VPC: fix some issues related to multiple public IP ranges and private gateway

Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #4484:
URL: https://github.com/apache/cloudstack/pull/4484#issuecomment-731238287


   @blueorangutan test centos7 vmware-67u3


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] DennisKonrad edited a comment on pull request #4484: VPC: fix some issues related to multiple public IP ranges and private gateway

Posted by GitBox <gi...@apache.org>.
DennisKonrad edited a comment on pull request #4484:
URL: https://github.com/apache/cloudstack/pull/4484#issuecomment-732792656


   @DaanHoogland I'm looking into it right now. So far all I tested looked good. Giving my approval today if nothing else turns up


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] DaanHoogland commented on pull request #4484: VPC: fix some issues related to multiple public IP ranges and private gateway

Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on pull request #4484:
URL: https://github.com/apache/cloudstack/pull/4484#issuecomment-731991418


   @PaulAngus as RM, do we merge this before release? cc @rhtyd 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #4484: VPC: fix some issues related to multiple public IP ranges and private gateway

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4484:
URL: https://github.com/apache/cloudstack/pull/4484#issuecomment-731238654


   @rhtyd a Trillian-Jenkins test job (centos7 mgmt + vmware-67u3) has been kicked to run smoke tests


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] DaanHoogland commented on pull request #4484: VPC: fix some issues related to multiple public IP ranges and private gateway

Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on pull request #4484:
URL: https://github.com/apache/cloudstack/pull/4484#issuecomment-731021458


   these are a lot @weizhouapache can you add the highest severity to the labels?
   @blueorangutan package


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #4484: VPC: fix some issues related to multiple public IP ranges and private gateway

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4484:
URL: https://github.com/apache/cloudstack/pull/4484#issuecomment-732671429


   <b>Trillian test result (tid-3235)</b>
   Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
   Total time taken: 65329 seconds
   Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr4484-t3235-kvm-centos7.zip
   Intermittent failure detected: /marvin/tests/smoke/test_kubernetes_clusters.py
   Intermittent failure detected: /marvin/tests/smoke/test_password_server.py
   Intermittent failure detected: /marvin/tests/smoke/test_public_ip_range.py
   Intermittent failure detected: /marvin/tests/smoke/test_reset_vm_on_reboot.py
   Intermittent failure detected: /marvin/tests/smoke/test_resource_accounting.py
   Intermittent failure detected: /marvin/tests/smoke/test_router_dhcphosts.py
   Intermittent failure detected: /marvin/tests/smoke/test_router_dns.py
   Intermittent failure detected: /marvin/tests/smoke/test_router_dnsservice.py
   Intermittent failure detected: /marvin/tests/smoke/test_routers_iptables_default_policy.py
   Intermittent failure detected: /marvin/tests/smoke/test_routers_network_ops.py
   Intermittent failure detected: /marvin/tests/smoke/test_routers.py
   Intermittent failure detected: /marvin/tests/smoke/test_secondary_storage.py
   Intermittent failure detected: /marvin/tests/smoke/test_service_offerings.py
   Intermittent failure detected: /marvin/tests/smoke/test_snapshots.py
   Intermittent failure detected: /marvin/tests/smoke/test_ssvm.py
   Intermittent failure detected: /marvin/tests/smoke/test_templates.py
   Intermittent failure detected: /marvin/tests/smoke/test_usage.py
   Intermittent failure detected: /marvin/tests/smoke/test_vm_life_cycle.py
   Intermittent failure detected: /marvin/tests/smoke/test_vm_snapshots.py
   Intermittent failure detected: /marvin/tests/smoke/test_volumes.py
   Intermittent failure detected: /marvin/tests/smoke/test_vpc_redundant.py
   Intermittent failure detected: /marvin/tests/smoke/test_vpc_router_nics.py
   Intermittent failure detected: /marvin/tests/smoke/test_vpc_vpn.py
   Intermittent failure detected: /marvin/tests/smoke/test_hostha_kvm.py
   Smoke tests completed. 62 look OK, 21 have error(s)
   Only failed tests results shown below:
   
   
   Test | Result | Time (s) | Test File
   --- | --- | --- | ---
   ContextSuite context=TestResetVmOnReboot>:setup | `Error` | 0.00 | test_reset_vm_on_reboot.py
   ContextSuite context=TestRAMCPUResourceAccounting>:setup | `Error` | 0.00 | test_resource_accounting.py
   ContextSuite context=TestRouterDHCPHosts>:setup | `Error` | 0.00 | test_router_dhcphosts.py
   ContextSuite context=TestRouterDHCPOpts>:setup | `Error` | 0.00 | test_router_dhcphosts.py
   ContextSuite context=TestRouterDns>:setup | `Error` | 0.00 | test_router_dns.py
   ContextSuite context=TestRouterDnsService>:setup | `Error` | 0.00 | test_router_dnsservice.py
   ContextSuite context=TestRouterIpTablesPolicies>:setup | `Error` | 0.00 | test_routers_iptables_default_policy.py
   ContextSuite context=TestVPCIpTablesPolicies>:setup | `Error` | 0.00 | test_routers_iptables_default_policy.py
   ContextSuite context=TestIsolatedNetworks>:setup | `Error` | 0.00 | test_routers_network_ops.py
   ContextSuite context=TestRedundantIsolateNetworks>:setup | `Error` | 0.00 | test_routers_network_ops.py
   ContextSuite context=TestRouterServices>:setup | `Error` | 0.00 | test_routers.py
   test_01_sys_vm_start | `Failure` | 0.10 | test_secondary_storage.py
   ContextSuite context=TestCpuCapServiceOfferings>:setup | `Error` | 0.00 | test_service_offerings.py
   ContextSuite context=TestServiceOfferings>:setup | `Error` | 0.17 | test_service_offerings.py
   ContextSuite context=TestSnapshotRootDisk>:setup | `Error` | 0.00 | test_snapshots.py
   test_01_list_sec_storage_vm | `Failure` | 0.05 | test_ssvm.py
   test_02_list_cpvm_vm | `Failure` | 0.04 | test_ssvm.py
   test_03_ssvm_internals | `Failure` | 0.04 | test_ssvm.py
   test_04_cpvm_internals | `Failure` | 0.04 | test_ssvm.py
   test_05_stop_ssvm | `Failure` | 0.04 | test_ssvm.py
   test_06_stop_cpvm | `Failure` | 0.04 | test_ssvm.py
   test_07_reboot_ssvm | `Failure` | 0.04 | test_ssvm.py
   test_08_reboot_cpvm | `Failure` | 0.04 | test_ssvm.py
   test_09_destroy_ssvm | `Failure` | 0.04 | test_ssvm.py
   test_10_destroy_cpvm | `Failure` | 0.04 | test_ssvm.py
   test_02_create_template_with_checksum_sha1 | `Error` | 65.45 | test_templates.py
   test_03_create_template_with_checksum_sha256 | `Error` | 65.46 | test_templates.py
   test_04_create_template_with_checksum_md5 | `Error` | 65.48 | test_templates.py
   test_05_create_template_with_no_checksum | `Error` | 65.47 | test_templates.py
   test_02_deploy_vm_from_direct_download_template | `Error` | 1.25 | test_templates.py
   test_03_deploy_vm_wrong_checksum | `Error` | 1.31 | test_templates.py
   ContextSuite context=TestTemplates>:setup | `Error` | 18.44 | test_templates.py
   ContextSuite context=TestISOUsage>:setup | `Error` | 0.00 | test_usage.py
   ContextSuite context=TestLBRuleUsage>:setup | `Error` | 0.00 | test_usage.py
   ContextSuite context=TestNatRuleUsage>:setup | `Error` | 0.00 | test_usage.py
   ContextSuite context=TestPublicIPUsage>:setup | `Error` | 0.00 | test_usage.py
   ContextSuite context=TestSnapshotUsage>:setup | `Error` | 0.00 | test_usage.py
   ContextSuite context=TestVmUsage>:setup | `Error` | 0.00 | test_usage.py
   ContextSuite context=TestVolumeUsage>:setup | `Error` | 0.00 | test_usage.py
   ContextSuite context=TestVpnUsage>:setup | `Error` | 0.00 | test_usage.py
   ContextSuite context=Test01DeployVM>:setup | `Error` | 0.00 | test_vm_life_cycle.py
   ContextSuite context=Test02VMLifeCycle>:setup | `Error` | 0.00 | test_vm_life_cycle.py
   test_14_secure_to_secure_vm_migration | `Error` | 11.40 | test_vm_life_cycle.py
   test_15_secured_to_nonsecured_vm_migration | `Error` | 74.03 | test_vm_life_cycle.py
   test_16_nonsecured_to_secured_vm_migration | `Error` | 1.25 | test_vm_life_cycle.py
   ContextSuite context=TestVmSnapshot>:setup | `Error` | 1.85 | test_vm_snapshots.py
   ContextSuite context=TestCreateVolume>:setup | `Error` | 0.00 | test_volumes.py
   ContextSuite context=TestVolumes>:setup | `Error` | 0.00 | test_volumes.py
   ContextSuite context=TestVPCRedundancy>:setup | `Error` | 0.00 | test_vpc_redundant.py
   ContextSuite context=TestVPCNics>:setup | `Error` | 0.00 | test_vpc_router_nics.py
   ContextSuite context=TestRVPCSite2SiteVpn>:setup | `Error` | 0.00 | test_vpc_vpn.py
   ContextSuite context=TestVPCSite2SiteVPNMultipleOptions>:setup | `Error` | 0.00 | test_vpc_vpn.py
   ContextSuite context=TestVpcRemoteAccessVpn>:setup | `Error` | 0.00 | test_vpc_vpn.py
   ContextSuite context=TestVpcSite2SiteVpn>:setup | `Error` | 0.00 | test_vpc_vpn.py
   test_disable_oobm_ha_state_ineligible | `Error` | 1513.23 | test_hostha_kvm.py
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] DennisKonrad commented on pull request #4484: VPC: fix some issues related to multiple public IP ranges and private gateway

Posted by GitBox <gi...@apache.org>.
DennisKonrad commented on pull request #4484:
URL: https://github.com/apache/cloudstack/pull/4484#issuecomment-732792656


   @DaanHoogland I'm looking into it right now. So far all I tested looked good. Giving my approval today if noting else turns up


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] rhtyd commented on pull request #4484: VPC: fix some issues related to multiple public IP ranges and private gateway

Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #4484:
URL: https://github.com/apache/cloudstack/pull/4484#issuecomment-732844005


   @blueorangutan test
   
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #4484: VPC: fix some issues related to multiple public IP ranges and private gateway

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4484:
URL: https://github.com/apache/cloudstack/pull/4484#issuecomment-732095690


   @DaanHoogland a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] DaanHoogland commented on pull request #4484: VPC: fix some issues related to multiple public IP ranges and private gateway

Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on pull request #4484:
URL: https://github.com/apache/cloudstack/pull/4484#issuecomment-733015991


   i think we are good to go here. restarted the failed test env to be more than 100% sure.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] ustcweizhou commented on pull request #4484: VPC: fix some issues related to multiple public IP ranges and private gateway

Posted by GitBox <gi...@apache.org>.
ustcweizhou commented on pull request #4484:
URL: https://github.com/apache/cloudstack/pull/4484#issuecomment-731010004


   @div8cn @richardlawley @ravening @DennisKonrad 
   could you please test this pr ?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #4484: VPC: fix some issues related to multiple public IP ranges and private gateway

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4484:
URL: https://github.com/apache/cloudstack/pull/4484#issuecomment-732051096


   Packaging result: ✔centos7 ✖centos8 ✔debian. JID-2423


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #4484: VPC: fix some issues related to multiple public IP ranges and private gateway

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4484:
URL: https://github.com/apache/cloudstack/pull/4484#issuecomment-731489545


   <b>Trillian test result (tid-3224)</b>
   Environment: vmware-67u3 (x2), Advanced Networking with Mgmt server 7
   Total time taken: 35800 seconds
   Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr4484-t3224-vmware-67u3.zip
   Intermittent failure detected: /marvin/tests/smoke/test_templates.py
   Smoke tests completed. 82 look OK, 1 have error(s)
   Only failed tests results shown below:
   
   
   Test | Result | Time (s) | Test File
   --- | --- | --- | ---
   test_02_create_template_with_checksum_sha1 | `Error` | 5.19 | test_templates.py
   test_03_create_template_with_checksum_sha256 | `Error` | 5.19 | test_templates.py
   test_04_create_template_with_checksum_md5 | `Error` | 5.18 | test_templates.py
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #4484: VPC: fix some issues related to multiple public IP ranges and private gateway

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4484:
URL: https://github.com/apache/cloudstack/pull/4484#issuecomment-731697511


   @rhtyd a Trillian-Jenkins test job (centos7 mgmt + vmware-67u3) has been kicked to run smoke tests


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] DaanHoogland commented on pull request #4484: VPC: fix some issues related to multiple public IP ranges and private gateway

Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on pull request #4484:
URL: https://github.com/apache/cloudstack/pull/4484#issuecomment-732036161


   @blueorangutan package


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] DaanHoogland commented on pull request #4484: VPC: fix some issues related to multiple public IP ranges and private gateway

Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on pull request #4484:
URL: https://github.com/apache/cloudstack/pull/4484#issuecomment-732184635


   @DennisKonrad any conclusions from your testing yet?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] DaanHoogland merged pull request #4484: VPC: fix some issues related to multiple public IP ranges and private gateway

Posted by GitBox <gi...@apache.org>.
DaanHoogland merged pull request #4484:
URL: https://github.com/apache/cloudstack/pull/4484


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #4484: VPC: fix some issues related to multiple public IP ranges and private gateway

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4484:
URL: https://github.com/apache/cloudstack/pull/4484#issuecomment-733291760


   <b>Trillian test result (tid-3244)</b>
   Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
   Total time taken: 30318 seconds
   Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr4484-t3244-kvm-centos7.zip
   Smoke tests completed. 83 look OK, 0 have error(s)
   Only failed tests results shown below:
   
   
   Test | Result | Time (s) | Test File
   --- | --- | --- | ---
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] DaanHoogland commented on pull request #4484: VPC: fix some issues related to multiple public IP ranges and private gateway

Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on pull request #4484:
URL: https://github.com/apache/cloudstack/pull/4484#issuecomment-731563564


   hm, this exact set of failures I have seen before. I hope nothing slipped through.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] rhtyd commented on pull request #4484: VPC: fix some issues related to multiple public IP ranges and private gateway

Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #4484:
URL: https://github.com/apache/cloudstack/pull/4484#issuecomment-731697480


   @blueorangutan test centos7 vmware-67u3


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] rhtyd commented on pull request #4484: VPC: fix some issues related to multiple public IP ranges and private gateway

Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #4484:
URL: https://github.com/apache/cloudstack/pull/4484#issuecomment-732012607


   @DaanHoogland can you ping and discuss with @PaulAngus thnx


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #4484: VPC: fix some issues related to multiple public IP ranges and private gateway

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4484:
URL: https://github.com/apache/cloudstack/pull/4484#issuecomment-731757653


   <b>Trillian test result (tid-3230)</b>
   Environment: vmware-67u3 (x2), Advanced Networking with Mgmt server 7
   Total time taken: 33956 seconds
   Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr4484-t3230-vmware-67u3.zip
   Intermittent failure detected: /marvin/tests/smoke/test_templates.py
   Smoke tests completed. 82 look OK, 1 have error(s)
   Only failed tests results shown below:
   
   
   Test | Result | Time (s) | Test File
   --- | --- | --- | ---
   test_02_create_template_with_checksum_sha1 | `Error` | 5.19 | test_templates.py
   test_03_create_template_with_checksum_sha256 | `Error` | 5.19 | test_templates.py
   test_04_create_template_with_checksum_md5 | `Error` | 5.21 | test_templates.py
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] DaanHoogland commented on pull request #4484: VPC: fix some issues related to multiple public IP ranges and private gateway

Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on pull request #4484:
URL: https://github.com/apache/cloudstack/pull/4484#issuecomment-732095063


   @blueorangutan test


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan removed a comment on pull request #4484: VPC: fix some issues related to multiple public IP ranges and private gateway

Posted by GitBox <gi...@apache.org>.
blueorangutan removed a comment on pull request #4484:
URL: https://github.com/apache/cloudstack/pull/4484#issuecomment-732671429


   <b>Trillian test result (tid-3235)</b>
   Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
   Total time taken: 65329 seconds
   Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr4484-t3235-kvm-centos7.zip
   Intermittent failure detected: /marvin/tests/smoke/test_kubernetes_clusters.py
   Intermittent failure detected: /marvin/tests/smoke/test_password_server.py
   Intermittent failure detected: /marvin/tests/smoke/test_public_ip_range.py
   Intermittent failure detected: /marvin/tests/smoke/test_reset_vm_on_reboot.py
   Intermittent failure detected: /marvin/tests/smoke/test_resource_accounting.py
   Intermittent failure detected: /marvin/tests/smoke/test_router_dhcphosts.py
   Intermittent failure detected: /marvin/tests/smoke/test_router_dns.py
   Intermittent failure detected: /marvin/tests/smoke/test_router_dnsservice.py
   Intermittent failure detected: /marvin/tests/smoke/test_routers_iptables_default_policy.py
   Intermittent failure detected: /marvin/tests/smoke/test_routers_network_ops.py
   Intermittent failure detected: /marvin/tests/smoke/test_routers.py
   Intermittent failure detected: /marvin/tests/smoke/test_secondary_storage.py
   Intermittent failure detected: /marvin/tests/smoke/test_service_offerings.py
   Intermittent failure detected: /marvin/tests/smoke/test_snapshots.py
   Intermittent failure detected: /marvin/tests/smoke/test_ssvm.py
   Intermittent failure detected: /marvin/tests/smoke/test_templates.py
   Intermittent failure detected: /marvin/tests/smoke/test_usage.py
   Intermittent failure detected: /marvin/tests/smoke/test_vm_life_cycle.py
   Intermittent failure detected: /marvin/tests/smoke/test_vm_snapshots.py
   Intermittent failure detected: /marvin/tests/smoke/test_volumes.py
   Intermittent failure detected: /marvin/tests/smoke/test_vpc_redundant.py
   Intermittent failure detected: /marvin/tests/smoke/test_vpc_router_nics.py
   Intermittent failure detected: /marvin/tests/smoke/test_vpc_vpn.py
   Intermittent failure detected: /marvin/tests/smoke/test_hostha_kvm.py
   Smoke tests completed. 62 look OK, 21 have error(s)
   Only failed tests results shown below:
   
   
   Test | Result | Time (s) | Test File
   --- | --- | --- | ---
   ContextSuite context=TestResetVmOnReboot>:setup | `Error` | 0.00 | test_reset_vm_on_reboot.py
   ContextSuite context=TestRAMCPUResourceAccounting>:setup | `Error` | 0.00 | test_resource_accounting.py
   ContextSuite context=TestRouterDHCPHosts>:setup | `Error` | 0.00 | test_router_dhcphosts.py
   ContextSuite context=TestRouterDHCPOpts>:setup | `Error` | 0.00 | test_router_dhcphosts.py
   ContextSuite context=TestRouterDns>:setup | `Error` | 0.00 | test_router_dns.py
   ContextSuite context=TestRouterDnsService>:setup | `Error` | 0.00 | test_router_dnsservice.py
   ContextSuite context=TestRouterIpTablesPolicies>:setup | `Error` | 0.00 | test_routers_iptables_default_policy.py
   ContextSuite context=TestVPCIpTablesPolicies>:setup | `Error` | 0.00 | test_routers_iptables_default_policy.py
   ContextSuite context=TestIsolatedNetworks>:setup | `Error` | 0.00 | test_routers_network_ops.py
   ContextSuite context=TestRedundantIsolateNetworks>:setup | `Error` | 0.00 | test_routers_network_ops.py
   ContextSuite context=TestRouterServices>:setup | `Error` | 0.00 | test_routers.py
   test_01_sys_vm_start | `Failure` | 0.10 | test_secondary_storage.py
   ContextSuite context=TestCpuCapServiceOfferings>:setup | `Error` | 0.00 | test_service_offerings.py
   ContextSuite context=TestServiceOfferings>:setup | `Error` | 0.17 | test_service_offerings.py
   ContextSuite context=TestSnapshotRootDisk>:setup | `Error` | 0.00 | test_snapshots.py
   test_01_list_sec_storage_vm | `Failure` | 0.05 | test_ssvm.py
   test_02_list_cpvm_vm | `Failure` | 0.04 | test_ssvm.py
   test_03_ssvm_internals | `Failure` | 0.04 | test_ssvm.py
   test_04_cpvm_internals | `Failure` | 0.04 | test_ssvm.py
   test_05_stop_ssvm | `Failure` | 0.04 | test_ssvm.py
   test_06_stop_cpvm | `Failure` | 0.04 | test_ssvm.py
   test_07_reboot_ssvm | `Failure` | 0.04 | test_ssvm.py
   test_08_reboot_cpvm | `Failure` | 0.04 | test_ssvm.py
   test_09_destroy_ssvm | `Failure` | 0.04 | test_ssvm.py
   test_10_destroy_cpvm | `Failure` | 0.04 | test_ssvm.py
   test_02_create_template_with_checksum_sha1 | `Error` | 65.45 | test_templates.py
   test_03_create_template_with_checksum_sha256 | `Error` | 65.46 | test_templates.py
   test_04_create_template_with_checksum_md5 | `Error` | 65.48 | test_templates.py
   test_05_create_template_with_no_checksum | `Error` | 65.47 | test_templates.py
   test_02_deploy_vm_from_direct_download_template | `Error` | 1.25 | test_templates.py
   test_03_deploy_vm_wrong_checksum | `Error` | 1.31 | test_templates.py
   ContextSuite context=TestTemplates>:setup | `Error` | 18.44 | test_templates.py
   ContextSuite context=TestISOUsage>:setup | `Error` | 0.00 | test_usage.py
   ContextSuite context=TestLBRuleUsage>:setup | `Error` | 0.00 | test_usage.py
   ContextSuite context=TestNatRuleUsage>:setup | `Error` | 0.00 | test_usage.py
   ContextSuite context=TestPublicIPUsage>:setup | `Error` | 0.00 | test_usage.py
   ContextSuite context=TestSnapshotUsage>:setup | `Error` | 0.00 | test_usage.py
   ContextSuite context=TestVmUsage>:setup | `Error` | 0.00 | test_usage.py
   ContextSuite context=TestVolumeUsage>:setup | `Error` | 0.00 | test_usage.py
   ContextSuite context=TestVpnUsage>:setup | `Error` | 0.00 | test_usage.py
   ContextSuite context=Test01DeployVM>:setup | `Error` | 0.00 | test_vm_life_cycle.py
   ContextSuite context=Test02VMLifeCycle>:setup | `Error` | 0.00 | test_vm_life_cycle.py
   test_14_secure_to_secure_vm_migration | `Error` | 11.40 | test_vm_life_cycle.py
   test_15_secured_to_nonsecured_vm_migration | `Error` | 74.03 | test_vm_life_cycle.py
   test_16_nonsecured_to_secured_vm_migration | `Error` | 1.25 | test_vm_life_cycle.py
   ContextSuite context=TestVmSnapshot>:setup | `Error` | 1.85 | test_vm_snapshots.py
   ContextSuite context=TestCreateVolume>:setup | `Error` | 0.00 | test_volumes.py
   ContextSuite context=TestVolumes>:setup | `Error` | 0.00 | test_volumes.py
   ContextSuite context=TestVPCRedundancy>:setup | `Error` | 0.00 | test_vpc_redundant.py
   ContextSuite context=TestVPCNics>:setup | `Error` | 0.00 | test_vpc_router_nics.py
   ContextSuite context=TestRVPCSite2SiteVpn>:setup | `Error` | 0.00 | test_vpc_vpn.py
   ContextSuite context=TestVPCSite2SiteVPNMultipleOptions>:setup | `Error` | 0.00 | test_vpc_vpn.py
   ContextSuite context=TestVpcRemoteAccessVpn>:setup | `Error` | 0.00 | test_vpc_vpn.py
   ContextSuite context=TestVpcSite2SiteVpn>:setup | `Error` | 0.00 | test_vpc_vpn.py
   test_disable_oobm_ha_state_ineligible | `Error` | 1513.23 | test_hostha_kvm.py
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] weizhouapache commented on pull request #4484: VPC: fix some issues related to multiple public IP ranges and private gateway

Posted by GitBox <gi...@apache.org>.
weizhouapache commented on pull request #4484:
URL: https://github.com/apache/cloudstack/pull/4484#issuecomment-732042168


   > I see nothing strange or wrong with this code. two remarks thought:
   > 
   > 1. it is a lot in one go and will require verification in a lot of different kinds of environments.
   > 2. I recognise some changes that already went into master over the last few weeks so merging forward might give some conflicts (nothing that should stop us now.
   
   @DaanHoogland @rhtyd rebased with latest 4.14
   yes, there are  indeed a lot of verifications to be done.
   
   I have added some test cases in this PR which verify the ips on nics and UP/DOWN state of public interfaces.
   I have tested with kvm, but not on xenserver and vmware.
   it takes around 1 hour to finish all 4 integration tests so I do not add them to .travis.yaml.
   The integration tests cover vpc/network with/without vr, and some actions (add/remove public ip in multiple ip ranges, add/remove vpc tier,add private gateway). 
   https://github.com/apache/cloudstack/blob/788ed28a8c73756a1bc8deb102a1d2506cc2d430/test/integration/component/test_multiple_subnets_in_isolated_network.py
   https://github.com/apache/cloudstack/blob/788ed28a8c73756a1bc8deb102a1d2506cc2d430/test/integration/component/test_multiple_subnets_in_isolated_network_rvr.py
   https://github.com/apache/cloudstack/blob/788ed28a8c73756a1bc8deb102a1d2506cc2d430/test/integration/component/test_multiple_subnets_in_vpc.py
   https://github.com/apache/cloudstack/blob/788ed28a8c73756a1bc8deb102a1d2506cc2d430/test/integration/component/test_multiple_subnets_in_vpc_rvr.py
   
   
   However, for some changes on iptable rules , they require manual test.
   What I have done
   (1) create vpc1 and two tiers vpc1-001, vpc1-002, and some vms vpc1-001-001, vpc1-001-002, vpc1-002-001, vpc1-002-002
   (2) create a shared network and a vm in it, to simulate server in private rack.
   (3) create vpc2, create a tier and vm vpc2-001-001, and enable site-to-site vpn gateway
   (4) add multiple public ip ranges in zone/public physical network
   
   setup
   (5) create site-to-site vpn between vpc1 and vpc2
   (6) create private gateway in vpc1, with same vlan with shared network in step (2) above.
   (7) acquire multiple IPs in new public ranges created in step (4) above, and use them for different proposal (eg enable static nat on some vms in vpc, or create port forwarding rules to vms in vpc).
   
   expected results
   (1) if ACL is allow_all, then all servers (including vm in shared network, vm in vpc2, vms with/without static nat in vpc1) should be able to reach each other
   (2) if ACL is deny_all, vm in vpc tiers and private gateway should not be able to reach each other.
   
   By the way, if you merge his pr, could you use "Rebase and Merge" option so it would be better to track why a line of change is made if there are issues in the future.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] weizhouapache commented on pull request #4484: VPC: fix some issues related to multiple public IP ranges and private gateway

Posted by GitBox <gi...@apache.org>.
weizhouapache commented on pull request #4484:
URL: https://github.com/apache/cloudstack/pull/4484#issuecomment-731012310


   @DaanHoogland @rhtyd could you kick-off Trillian test for this pr ?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #4484: VPC: fix some issues related to multiple public IP ranges and private gateway

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4484:
URL: https://github.com/apache/cloudstack/pull/4484#issuecomment-731094035


   @DaanHoogland a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] DaanHoogland removed a comment on pull request #4484: VPC: fix some issues related to multiple public IP ranges and private gateway

Posted by GitBox <gi...@apache.org>.
DaanHoogland removed a comment on pull request #4484:
URL: https://github.com/apache/cloudstack/pull/4484#issuecomment-732095063


   @blueorangutan test


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] weizhouapache edited a comment on pull request #4484: VPC: fix some issues related to multiple public IP ranges and private gateway

Posted by GitBox <gi...@apache.org>.
weizhouapache edited a comment on pull request #4484:
URL: https://github.com/apache/cloudstack/pull/4484#issuecomment-732042168


   > I see nothing strange or wrong with this code. two remarks thought:
   > 
   > 1. it is a lot in one go and will require verification in a lot of different kinds of environments.
   > 2. I recognise some changes that already went into master over the last few weeks so merging forward might give some conflicts (nothing that should stop us now.
   
   @DaanHoogland @rhtyd rebased with latest 4.14
   yes, there are  indeed a lot of verifications to be done.
   
   I have added some test cases in this PR which verify the ips on nics and UP/DOWN state of public interfaces.
   I have tested with kvm, but not on xenserver and vmware.
   it takes around 1 hour to finish all 4 integration tests so I do not add them to .travis.yaml.
   The integration tests cover vpc/network with/without vr, and some actions (add/remove public ip in multiple ip ranges, add/remove vpc tier,add private gateway, reboot routers, restart vpc tiers, restart vpc/network w/wo cleanup). 
   https://github.com/apache/cloudstack/blob/788ed28a8c73756a1bc8deb102a1d2506cc2d430/test/integration/component/test_multiple_subnets_in_isolated_network.py
   https://github.com/apache/cloudstack/blob/788ed28a8c73756a1bc8deb102a1d2506cc2d430/test/integration/component/test_multiple_subnets_in_isolated_network_rvr.py
   https://github.com/apache/cloudstack/blob/788ed28a8c73756a1bc8deb102a1d2506cc2d430/test/integration/component/test_multiple_subnets_in_vpc.py
   https://github.com/apache/cloudstack/blob/788ed28a8c73756a1bc8deb102a1d2506cc2d430/test/integration/component/test_multiple_subnets_in_vpc_rvr.py
   
   
   However, for some changes on iptable rules , they require manual test.
   What I have done
   (1) create vpc1 and two tiers vpc1-001, vpc1-002, and some vms vpc1-001-001, vpc1-001-002, vpc1-002-001, vpc1-002-002
   (2) create a shared network and a vm in it, to simulate server in private rack.
   (3) create vpc2, create a tier and vm vpc2-001-001, and enable site-to-site vpn gateway
   (4) add multiple public ip ranges in zone/public physical network
   
   setup
   (5) create site-to-site vpn between vpc1 and vpc2
   (6) create private gateway in vpc1, with same vlan with shared network in step (2) above.
   (7) acquire multiple IPs in new public ranges created in step (4) above, and use them for different proposal (eg enable static nat on some vms in vpc, or create port forwarding rules to vms in vpc).
   
   expected results
   (1) if ACL is allow_all, then all servers (including vm in shared network, vm in vpc2, vms with/without static nat in vpc1) should be able to reach each other
   (2) if ACL is deny_all, vm in vpc tiers and private gateway should not be able to reach each other.
   
   By the way, if you merge his pr, could you use "Rebase and Merge" option so it would be better to track why a line of change is made if there are issues in the future.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org