You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/08/31 11:15:36 UTC

[GitHub] [airflow] olchas commented on a change in pull request #10403: Fix duration object in Dataproc cluster generator

olchas commented on a change in pull request #10403:
URL: https://github.com/apache/airflow/pull/10403#discussion_r480063016



##########
File path: airflow/providers/google/cloud/operators/dataproc.py
##########
@@ -240,10 +240,10 @@ def _get_init_action_timeout(self):
         match = re.match(r"^(\d+)([sm])$", self.init_action_timeout)
         if match:
             if match.group(2) == "s":
-                return self.init_action_timeout
+                return {"seconds": self.init_action_timeout}

Review comment:
       It seems value under `seconds` key will be of `str` type in this case, and an `int` type in the other - is that intended/valid?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org