[GitHub] [airflow] cliebBS commented on pull request #34183: Ensure that max_attempts is always an int

["cliebBS (via GitHub)" <gi...@apache.org>]

cliebBS commented on PR #34183:
URL: https://github.com/apache/airflow/pull/34183#issuecomment-1711639236

   @vincbeck I actually tried rewriting `EmrAddStepsTrigger` to extend `AwsBaseWaiterTrigger`, but ran into the issue where `AwsBaseWaiterTrigger` only waits on a single item, while `EmrAddStepsTrigger` allows you to wait on an arbitrary number of steps at the same time.  I couldn't figure out a way (quickly) to adapt it, though I did prove that trying to loop over multiple `self.delay` calls doesn't work.  I submitted this PR because this was the one way I was able to get things working without needing to dig too deeply into the provider and base trigger code.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org