You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2021/02/04 04:21:00 UTC

[GitHub] [spark] HeartSaVioR commented on a change in pull request #31464: [SPARK-34339][CORE][SQL] Expose the number of total paths in Utils.buildLocationMetadata()

HeartSaVioR commented on a change in pull request #31464:
URL: https://github.com/apache/spark/pull/31464#discussion_r569936135



##########
File path: core/src/main/scala/org/apache/spark/util/Utils.scala
##########
@@ -2989,6 +2989,9 @@ private[spark] object Utils extends Logging {
       metadata.append(paths(index).toString)
       index += 1
     }
+    if (paths.length > index) {
+      metadata.append(s", ... ${paths.length - index} more")

Review comment:
       I've reflected the second option. It's probably less beautiful but easily avoid possible glitches. I've also updated the PR title/description.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org