[GitHub] [tvm] Hzfengsy commented on a diff in pull request #13406: [MetaSchedule][Fix] Fix Empty Run Time Issue when Benchmarking Result

[GitBox <gi...@apache.org>]

Hzfengsy commented on code in PR #13406:
URL: https://github.com/apache/tvm/pull/13406#discussion_r1024799360


##########
src/meta_schedule/measure_callback/update_cost_model.cc:
##########
@@ -42,7 +42,8 @@ class UpdateCostModelNode : public MeasureCallbackNode {
     pruned_candidate.reserve(n);
     pruned_runner_result.reserve(n);
     for (int i = 0; i < n; i++) {
-      if (!builder_results[i]->error_msg.defined() &&
+      if (!builder_results[i]->error_msg.defined() &&  //
+          !runner_results[i]->error_msg.defined() &&   //

Review Comment:
   Thanks for pointing it out. It make sense to me



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org