You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@pegasus.apache.org by GitBox <gi...@apache.org> on 2022/08/22 08:54:11 UTC
[GitHub] [incubator-pegasus] totalo commented on a diff in pull request #1130: refactor(java-client): optimize the code style of PegasusScanner
totalo commented on code in PR #1130:
URL: https://github.com/apache/incubator-pegasus/pull/1130#discussion_r951180808
##########
java-client/src/main/java/org/apache/pegasus/client/ClientOptions.java:
##########
@@ -233,7 +233,6 @@ public int hashCode() {
result = 31 * result + Objects.hashCode(falconPushInterval.toMillis());
result = 31 * result + (enableWriteLimit ? 1 : 0);
result = 31 * result + Objects.hashCode(metaQueryTimeout.toMillis());
- result = 31 * result + authProtocol.hashCode();
Review Comment:
I think it's because #1096 was removed, but I didn't merge master, it used to run d
I think it's because #1096 was removed, but I didn't merge the master, I ran the previous complete code so that my pr could pass, and then the master didn't run ci again after the pr was merged, so I didn't find this problem.
Maybe we need to run ci after merging to master.
##########
java-client/src/main/java/org/apache/pegasus/client/ClientOptions.java:
##########
@@ -233,7 +233,6 @@ public int hashCode() {
result = 31 * result + Objects.hashCode(falconPushInterval.toMillis());
result = 31 * result + (enableWriteLimit ? 1 : 0);
result = 31 * result + Objects.hashCode(metaQueryTimeout.toMillis());
- result = 31 * result + authProtocol.hashCode();
Review Comment:
I think it's because #1096 was removed, but I didn't merge the master, I ran the previous complete code so that my pr could pass, and then the master didn't run ci again after the pr was merged, so I didn't find this problem.
Maybe we need to run ci after merging to master.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For additional commands, e-mail: dev-help@pegasus.apache.org