[GitHub] jihoonson commented on a change in pull request #6911: Remove DataSegmentFinder, InsertSegmentToDb, and descriptor.json file in deep storage

[GitBox <gi...@apache.org>]

jihoonson commented on a change in pull request #6911: Remove DataSegmentFinder, InsertSegmentToDb, and descriptor.json file in deep storage
URL: https://github.com/apache/incubator-druid/pull/6911#discussion_r253983956
 
 

 ##########
 File path: extensions-contrib/google-extensions/src/main/java/org/apache/druid/storage/google/GoogleDataSegmentKiller.java
 ##########
 @@ -52,11 +52,9 @@ public void kill(DataSegment segment) throws SegmentLoadingException
     Map<String, Object> loadSpec = segment.getLoadSpec();
     final String bucket = MapUtils.getString(loadSpec, "bucket");
     final String indexPath = MapUtils.getString(loadSpec, "path");
-    final String descriptorPath = indexPath.substring(0, indexPath.lastIndexOf('/')) + "/descriptor.json";
 
     try {
       deleteIfPresent(bucket, indexPath);
-      deleteIfPresent(bucket, descriptorPath);
 
 Review comment:
   Thanks. It sounds good. I reverted back and added a comment.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org