You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by Tom Beerbower <tb...@hortonworks.com> on 2015/06/30 18:48:53 UTC
Review Request 36057: Views: Don't cache URL stream provider in view
context
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36057/
-----------------------------------------------------------
Review request for Ambari and Robert Levas.
Bugs: AMBARI-12223
https://issues.apache.org/jira/browse/AMBARI-12223
Repository: ambari
Description
-------
The URLStreamProvider is currently cached in the ViewContext implementation. It is a problem if the associated HttpURLConnection times out because we have no way to refresh the connection. Instead, we should get a new URLStreamProvider for each request.
Diffs
-----
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/URLStreamProvider.java bc11646
ambari-server/src/main/java/org/apache/ambari/server/view/ViewContextImpl.java 8788346
ambari-server/src/test/java/org/apache/ambari/server/view/ViewContextImplTest.java e111811
Diff: https://reviews.apache.org/r/36057/diff/
Testing
-------
Updated unit test.
mvn clean test
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 45:58 min
[INFO] Finished at: 2015-06-30T12:42:16-04:00
[INFO] Final Memory: 58M/1995M
[INFO] ------------------------------------------------------------------------
Thanks,
Tom Beerbower
Re: Review Request 36057: Views: Don't cache URL stream provider in
view context
Posted by Robert Levas <rl...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36057/#review89924
-----------------------------------------------------------
Ship it!
Ship It!
- Robert Levas
On June 30, 2015, 12:48 p.m., Tom Beerbower wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36057/
> -----------------------------------------------------------
>
> (Updated June 30, 2015, 12:48 p.m.)
>
>
> Review request for Ambari and Robert Levas.
>
>
> Bugs: AMBARI-12223
> https://issues.apache.org/jira/browse/AMBARI-12223
>
>
> Repository: ambari
>
>
> Description
> -------
>
> The URLStreamProvider is currently cached in the ViewContext implementation. It is a problem if the associated HttpURLConnection times out because we have no way to refresh the connection. Instead, we should get a new URLStreamProvider for each request.
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/URLStreamProvider.java bc11646
> ambari-server/src/main/java/org/apache/ambari/server/view/ViewContextImpl.java 8788346
> ambari-server/src/test/java/org/apache/ambari/server/view/ViewContextImplTest.java e111811
>
> Diff: https://reviews.apache.org/r/36057/diff/
>
>
> Testing
> -------
>
> Updated unit test.
>
> mvn clean test
>
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 45:58 min
> [INFO] Finished at: 2015-06-30T12:42:16-04:00
> [INFO] Final Memory: 58M/1995M
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Tom Beerbower
>
>