You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@cordova.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2018/08/02 01:21:00 UTC

[jira] [Commented] (CB-14244) start cordova-ios@5.0.0-dev

    [ https://issues.apache.org/jira/browse/CB-14244?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16566216#comment-16566216 ] 

ASF GitHub Bot commented on CB-14244:
-------------------------------------

brodybits opened a new pull request #387: CB-14244 start 5.0.0-dev in master branch
URL: https://github.com/apache/cordova-ios/pull/387
 
 
   <!--
   Please make sure the checklist boxes are all checked before submitting the PR. The checklist
   is intended as a quick reference, for complete details please see our Contributor Guidelines:
   
   http://cordova.apache.org/contribute/contribute_guidelines.html
   
   Thanks!
   -->
   
   ### Platforms affected
   
   iOS
   
   ### What does this PR do?
   
   As agreed in [this dev@cordova.apache.org thread](https://lists.apache.org/thread.html/083ffe568bad2a8adc5533cbe5aca481bdd921e22a6aad9602aaded2@%3Cdev.cordova.apache.org%3E):
   
   Start `5.0.0-dev` (next major version) in `master` branch using the following command (with `cordova-coho` updates from [brodybits/cordova-coho - improve-patch-and-dev-version-support branch](https://github.com/brodybits/cordova-coho/tree/improve-patch-and-dev-version-support):
   
   ```sh
   ./cordova-coho/coho prepare-platform-release-branch --version 5.0.0-dev -r ios --js 4.2.3 --pre 'CB-14244 '
   ```
   
   with new flags to note:
   - `--js` value to avoid including new updates from `cordova-js` at the same time
   - `--pre` value to mark the commits with the corresponding JIRA number
   
   Also update `cordova.js` with recent change from cordova-js@4.2.4 in a separate commit, with help from the following command:
   
   ```sh
   ./cordova-coho/coho copy-js -r ios -js 4.2.4
   ```
   
   ### Merge instructions
   
   - [ ] To be merged by pushing these commits directly to `master` branch
   
   ### What testing has been done on this change?
   
   - [ ] able to try adding to a blank project using `cordova platform add github:brodybits/cordova-ios#cb-14244-start-5.0.0-dev-master` and then run on simulator
   - [ ] `npm test` succeeds on Travis CI
   
   ### Checklist
   
   - [x] [Reported an issue](http://cordova.apache.org/contribute/issues.html) in the JIRA database
   - [x] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file paths", where CB-xxxx is the JIRA ID & "android" is the platform affected.
   - ~~Added automated test coverage as appropriate for this change.~~

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> start cordova-ios@5.0.0-dev
> ---------------------------
>
>                 Key: CB-14244
>                 URL: https://issues.apache.org/jira/browse/CB-14244
>             Project: Apache Cordova
>          Issue Type: Task
>          Components: cordova-ios
>            Reporter: Chris Brody
>            Assignee: Chris Brody
>            Priority: Major
>
> To be done before the following in {{master}} branch of {{cordova-ios}}:
>  * CB-14074 - remove Node.js 4 support from {{package.json}}, {{.travis.yml}}, {{appveyor.yml}}, ... 
>  * CB-14242 - remove committed {{node_modules}}
>  * any other potentially breaking changes



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org