You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by GitBox <gi...@apache.org> on 2021/01/05 15:11:51 UTC

[GitHub] [iceberg] rymurr opened a new pull request #2032: add Nessie to flink runtime

rymurr opened a new pull request #2032:
URL: https://github.com/apache/iceberg/pull/2032


   This PR adds Nessie to the Flink runtime. Compliments #1895 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org

[GitHub] [iceberg] rdblue merged pull request #2032: add Nessie to flink runtime

Posted by GitBox <gi...@apache.org>.
rdblue merged pull request #2032:
URL: https://github.com/apache/iceberg/pull/2032


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org

[GitHub] [iceberg] rdblue commented on pull request #2032: add Nessie to flink runtime

Posted by GitBox <gi...@apache.org>.
rdblue commented on pull request #2032:
URL: https://github.com/apache/iceberg/pull/2032#issuecomment-756495836


   Thanks @rymurr!


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org

[GitHub] [iceberg] rymurr commented on a change in pull request #2032: add Nessie to flink runtime

Posted by GitBox <gi...@apache.org>.
rymurr commented on a change in pull request #2032:
URL: https://github.com/apache/iceberg/pull/2032#discussion_r553279670



##########
File path: build.gradle
##########
@@ -394,6 +394,9 @@ project(':iceberg-flink-runtime') {
   dependencies {
     compile project(':iceberg-flink')
     compile project(':iceberg-aws')
+    compile(project(':iceberg-nessie')) {
+      exclude group: 'com.google.code.findbugs', module: 'jsr305'
+    }

Review comment:
       doh, thanks for the reminder. Fixed




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org

[GitHub] [iceberg] rdblue commented on a change in pull request #2032: add Nessie to flink runtime

Posted by GitBox <gi...@apache.org>.
rdblue commented on a change in pull request #2032:
URL: https://github.com/apache/iceberg/pull/2032#discussion_r552224611



##########
File path: build.gradle
##########
@@ -394,6 +394,9 @@ project(':iceberg-flink-runtime') {
   dependencies {
     compile project(':iceberg-flink')
     compile project(':iceberg-aws')
+    compile(project(':iceberg-nessie')) {
+      exclude group: 'com.google.code.findbugs', module: 'jsr305'
+    }

Review comment:
       Do we need to update the LICENSE and NOTICE for the Jar?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org