You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by "JunRuiLee (via GitHub)" <gi...@apache.org> on 2023/03/05 09:26:08 UTC
[GitHub] [flink] JunRuiLee opened a new pull request, #22098: [FLINK-31144][coordination] Modify the judgment logic of whether to ignore the input locations of a ConsumePartitionGroup if the corresponding ConsumerVertexGroup is too large.
JunRuiLee opened a new pull request, #22098:
URL: https://github.com/apache/flink/pull/22098
<!--
*Thank you very much for contributing to Apache Flink - we are happy that you want to help us improve Flink. To help the community review your contribution in the best possible way, please go through the checklist below, which will get the contribution into a shape in which it can be best reviewed.*
*Please understand that we do not do this to make contributions to Flink a hassle. In order to uphold a high standard of quality for code contributions, while at the same time managing a large number of contributions, we need contributors to prepare the contributions well, and give reviewers enough contextual information for the review. Please also understand that contributions that do not follow this guide will take longer to review and thus typically be picked up with lower priority by the community.*
## Contribution Checklist
- Make sure that the pull request corresponds to a [JIRA issue](https://issues.apache.org/jira/projects/FLINK/issues). Exceptions are made for typos in JavaDoc or documentation files, which need no JIRA issue.
- Name the pull request in the form "[FLINK-XXXX] [component] Title of the pull request", where *FLINK-XXXX* should be replaced by the actual issue number. Skip *component* if you are unsure about which is the best component.
Typo fixes that have no associated JIRA issue should be named following this pattern: `[hotfix] [docs] Fix typo in event time introduction` or `[hotfix] [javadocs] Expand JavaDoc for PuncuatedWatermarkGenerator`.
- Fill out the template below to describe the changes contributed by the pull request. That will give reviewers the context they need to do the review.
- Make sure that the change passes the automated tests, i.e., `mvn clean verify` passes. You can set up Azure Pipelines CI to do that following [this guide](https://cwiki.apache.org/confluence/display/FLINK/Azure+Pipelines#AzurePipelines-Tutorial:SettingupAzurePipelinesforaforkoftheFlinkrepository).
- Each pull request should address only one issue, not mix up code from multiple issues.
- Each commit in the pull request has a meaningful commit message (including the JIRA id)
- Once all items of the checklist are addressed, remove the above text and this checklist, leaving only the filled out template below.
**(The sections below can be removed for hotfixes of typos)**
-->
## What is the purpose of the change
Currently, the judgment logic of whether to ignore the input locations of a ConsumePartitionGroup if the corresponding ConsumerVertexGroup is too large is to divide the size of the ConsumerVertexGroup by the size of the ConsumedPartitionGroup. But this will lead to a N^2 complexity to compute the input locations when there are N upstream task and N downstream tasks.
This pr wants to modify the judgment logic to consumeVertexGroup.size() > MAX_DISTINCT_CONSUMERS_TO_CONSIDER.
## Verifying this change
This change can be verified by DefaultPreferredLocationsRetrieverTest.
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): (yes / **no**)
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (yes / **no**)
- The serializers: (yes / **no** / don't know)
- The runtime per-record code paths (performance sensitive): (yes / **no** / don't know)
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: (yes / **no** / don't know)
- The S3 file system connector: (yes / **no** / don't know)
## Documentation
- Does this pull request introduce a new feature? (yes / **no**)
- If yes, how is the feature documented? (**not applicable** / docs / JavaDocs / not documented)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] JunRuiLee commented on a diff in pull request #22098: [FLINK-31144][coordination] Modify the judgment logic of whether to ignore the input locations of a ConsumePartitionGroup if the corresponding ConsumerVertexGroup is too large.
Posted by "JunRuiLee (via GitHub)" <gi...@apache.org>.
JunRuiLee commented on code in PR #22098:
URL: https://github.com/apache/flink/pull/22098#discussion_r1130636577
##########
flink-runtime/src/test/java/org/apache/flink/runtime/scheduler/DefaultPreferredLocationsRetrieverTest.java:
##########
@@ -81,16 +81,6 @@ void testInputLocations() {
producerLocations,
Collections.emptySet());
}
Review Comment:
done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] JunRuiLee commented on pull request #22098: [FLINK-31144][coordination] Modify the judgment logic of whether to ignore the input locations of a ConsumePartitionGroup if the corresponding ConsumerVertexGroup is too large.
Posted by "JunRuiLee (via GitHub)" <gi...@apache.org>.
JunRuiLee commented on PR #22098:
URL: https://github.com/apache/flink/pull/22098#issuecomment-1459238292
@huwh @zhuzhurk Thanks for review this pr and I've addressed comments, PTAL.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] zhuzhurk commented on a diff in pull request #22098: [FLINK-31144][coordination] Modify the judgment logic of whether to ignore the input locations of a ConsumePartitionGroup if the corresponding ConsumerVertexGroup is too large.
Posted by "zhuzhurk (via GitHub)" <gi...@apache.org>.
zhuzhurk commented on code in PR #22098:
URL: https://github.com/apache/flink/pull/22098#discussion_r1130607703
##########
flink-runtime/src/test/java/org/apache/flink/runtime/scheduler/DefaultPreferredLocationsRetrieverTest.java:
##########
@@ -81,16 +81,6 @@ void testInputLocations() {
producerLocations,
Collections.emptySet());
}
Review Comment:
This `{}`pair is no longer needed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] JunRuiLee commented on a diff in pull request #22098: [FLINK-31144][coordination] Modify the judgment logic of whether to ignore the input locations of a ConsumePartitionGroup if the corresponding ConsumerVertexGroup is too large.
Posted by "JunRuiLee (via GitHub)" <gi...@apache.org>.
JunRuiLee commented on code in PR #22098:
URL: https://github.com/apache/flink/pull/22098#discussion_r1128940538
##########
flink-runtime/src/main/java/org/apache/flink/runtime/scheduler/DefaultPreferredLocationsRetriever.java:
##########
@@ -95,8 +95,7 @@ private CompletableFuture<Collection<TaskManagerLocation>> getPreferredLocations
// consumers compared to the consumed partition group size. This is to avoid tasks
// unevenly distributed on nodes when running batch jobs or running jobs in
// session/standalone mode.
- if ((double) consumedPartitionGroup.getConsumerVertexGroup().size()
- / consumedPartitionGroup.size()
+ if (consumedPartitionGroup.getConsumerVertexGroup().size()
Review Comment:
done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] huwh commented on a diff in pull request #22098: [FLINK-31144][coordination] Modify the judgment logic of whether to ignore the input locations of a ConsumePartitionGroup if the corresponding ConsumerVertexGroup is too large.
Posted by "huwh (via GitHub)" <gi...@apache.org>.
huwh commented on code in PR #22098:
URL: https://github.com/apache/flink/pull/22098#discussion_r1128938614
##########
flink-runtime/src/main/java/org/apache/flink/runtime/scheduler/DefaultPreferredLocationsRetriever.java:
##########
@@ -95,8 +95,7 @@ private CompletableFuture<Collection<TaskManagerLocation>> getPreferredLocations
// consumers compared to the consumed partition group size. This is to avoid tasks
// unevenly distributed on nodes when running batch jobs or running jobs in
// session/standalone mode.
- if ((double) consumedPartitionGroup.getConsumerVertexGroup().size()
- / consumedPartitionGroup.size()
+ if (consumedPartitionGroup.getConsumerVertexGroup().size()
Review Comment:
typo: i -> in
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] zhuzhurk closed pull request #22098: [FLINK-31144][coordination] Modify the judgment logic of whether to ignore the input locations of a ConsumePartitionGroup if the corresponding ConsumerVertexGroup is too large.
Posted by "zhuzhurk (via GitHub)" <gi...@apache.org>.
zhuzhurk closed pull request #22098: [FLINK-31144][coordination] Modify the judgment logic of whether to ignore the input locations of a ConsumePartitionGroup if the corresponding ConsumerVertexGroup is too large.
URL: https://github.com/apache/flink/pull/22098
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #22098: [FLINK-31144][coordination] Modify the judgment logic of whether to ignore the input locations of a ConsumePartitionGroup if the corresponding ConsumerVertexGroup is too large.
Posted by "flinkbot (via GitHub)" <gi...@apache.org>.
flinkbot commented on PR #22098:
URL: https://github.com/apache/flink/pull/22098#issuecomment-1455037032
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "6a191540e8aadc32fab01e115249ffd2c7365d19",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "6a191540e8aadc32fab01e115249ffd2c7365d19",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 6a191540e8aadc32fab01e115249ffd2c7365d19 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] zhuzhurk commented on a diff in pull request #22098: [FLINK-31144][coordination] Modify the judgment logic of whether to ignore the input locations of a ConsumePartitionGroup if the corresponding ConsumerVertexGroup is too large.
Posted by "zhuzhurk (via GitHub)" <gi...@apache.org>.
zhuzhurk commented on code in PR #22098:
URL: https://github.com/apache/flink/pull/22098#discussion_r1125915973
##########
flink-runtime/src/main/java/org/apache/flink/runtime/scheduler/DefaultPreferredLocationsRetriever.java:
##########
@@ -35,7 +35,7 @@
/**
* Default implementation of {@link PreferredLocationsRetriever}. Locations based on state will be
- * returned if exist. Otherwise locations based on inputs will be returned.
+ * returned if existed. Otherwise, locations based on inputs will be returned.
Review Comment:
The usage of `exist` is correct regarding `locations`.
And I would suggest to not make this kind of changes, if the statement was not misleading or incorrect, unless you need to update the statement because it is outdated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] huwh commented on a diff in pull request #22098: [FLINK-31144][coordination] Modify the judgment logic of whether to ignore the input locations of a ConsumePartitionGroup if the corresponding ConsumerVertexGroup is too large.
Posted by "huwh (via GitHub)" <gi...@apache.org>.
huwh commented on code in PR #22098:
URL: https://github.com/apache/flink/pull/22098#discussion_r1125845041
##########
flink-runtime/src/main/java/org/apache/flink/runtime/scheduler/DefaultPreferredLocationsRetriever.java:
##########
@@ -35,7 +35,7 @@
/**
* Default implementation of {@link PreferredLocationsRetriever}. Locations based on state will be
- * returned if exist. Otherwise locations based on inputs will be returned.
+ * returned if existed. Otherwise, locations based on inputs will be returned.
Review Comment:
should be "exists"
##########
flink-runtime/src/main/java/org/apache/flink/runtime/scheduler/DefaultPreferredLocationsRetriever.java:
##########
@@ -95,8 +95,7 @@ private CompletableFuture<Collection<TaskManagerLocation>> getPreferredLocations
// consumers compared to the consumed partition group size. This is to avoid tasks
// unevenly distributed on nodes when running batch jobs or running jobs in
// session/standalone mode.
- if ((double) consumedPartitionGroup.getConsumerVertexGroup().size()
- / consumedPartitionGroup.size()
+ if (consumedPartitionGroup.getConsumerVertexGroup().size()
Review Comment:
The description should also be updated
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org