[GitHub] [ignite-3] agura commented on a change in pull request #365: IGNITE-15351 Implemented concepts of storage engines and data regions with basic integration into existing code.

[GitBox <gi...@apache.org>]

agura commented on a change in pull request #365:
URL: https://github.com/apache/ignite-3/pull/365#discussion_r723508272



##########
File path: modules/core/src/main/java/org/apache/ignite/internal/util/IgniteUtils.java
##########
@@ -467,27 +470,36 @@ public static void shutdownAndAwaitTermination(ExecutorService service, long tim
      * thrown exception will be propagated to the caller, after all other objects are closed, similar to
      * the try-with-resources block.
      *
-     * @param closeables Collection of objects to close.
+     * @param closeables Stream of objects to close.
      * @throws Exception If failed to close.
      */
-    public static void closeAll(Collection<? extends AutoCloseable> closeables) throws Exception {
-        Exception ex = null;
+    public static void closeAll(Stream<? extends AutoCloseable> closeables) throws Exception {

Review comment:
       @ibessonov Just remind you that we don't want to use Stream API in hot paths. I didn't like this method before your changes. Now I hate it :) Just because too many redundant transformations.  




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org