You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudstack.apache.org by GitBox <gi...@apache.org> on 2021/02/03 06:29:15 UTC
[GitHub] [cloudstack] Spaceman1984 opened a new pull request #4416: Fixed - unable to change disk controller - vmware
Spaceman1984 opened a new pull request #4416:
URL: https://github.com/apache/cloudstack/pull/4416
## Description
<!--- Describe your changes in detail -->
Fixes: #4344
<!-- For new features, provide link to FS, dev ML discussion etc. -->
<!-- In case of bug fix, the expected and actual behaviours, steps to reproduce. -->
<!-- When "Fixes: #<id>" is specified, the issue/PR will automatically be closed when this PR gets merged -->
<!-- For addressing multiple issues/PRs, use multiple "Fixes: #<id>" -->
<!-- Fixes: # -->
## Types of changes
<!--- What types of changes does your code introduce? Put an `x` in all the boxes that apply: -->
- [ ] Breaking change (fix or feature that would cause existing functionality to change)
- [ ] New feature (non-breaking change which adds functionality)
- [x] Bug fix (non-breaking change which fixes an issue)
- [ ] Enhancement (improves an existing feature and functionality)
- [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
## Screenshots (if appropriate):
## How Has This Been Tested?
<!-- Please describe in detail how you tested your changes. -->
<!-- Include details of your testing environment, and the tests you ran to -->
<!-- see how your change affects other areas of the code, etc. -->
Change the disk controller setting while the instance is stopped.
Start the instance.
Check vSphere client for disk controller change.
<!-- Please read the [CONTRIBUTING](https://github.com/apache/cloudstack/blob/master/CONTRIBUTING.md) document -->
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] shwstppr commented on pull request #4416: Fixed - unable to change disk controller - vmware
Posted by GitBox <gi...@apache.org>.
shwstppr commented on pull request #4416:
URL: https://github.com/apache/cloudstack/pull/4416#issuecomment-772272337
@blueorangutan package
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4416: Fixed - unable to change disk controller - vmware
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4416:
URL: https://github.com/apache/cloudstack/pull/4416#issuecomment-772272827
@shwstppr a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4416: vmware: disk controller fix
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4416:
URL: https://github.com/apache/cloudstack/pull/4416#issuecomment-826486710
Packaging result: :heavy_check_mark: centos7 :heavy_check_mark: debian. SL-JID 459
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4416: vmware: disk controller fix
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4416:
URL: https://github.com/apache/cloudstack/pull/4416#issuecomment-826490972
@shwstppr a Trillian-Jenkins test job (centos7 mgmt + vmware-67u3) has been kicked to run smoke tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] shwstppr commented on pull request #4416: vmware: disk controller fix
Posted by GitBox <gi...@apache.org>.
shwstppr commented on pull request #4416:
URL: https://github.com/apache/cloudstack/pull/4416#issuecomment-775050387
On 4.14 fix looks good but with forward merge on 4.15 (https://github.com/shapeblue/cloudstack/tree/disk-controller-vmware-415), with new template (deploy-as-is), change of controller doesn't reflect at vCenter side.
I upgraded a 4.14 env to 4.15 to test both old and new templates
This will need a bit more testing and some fixes.
Better to move it to 4.14.2 or 4.15.1? @rhtyd @harikrishna-patnala
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] shwstppr commented on pull request #4416: Fixed - unable to change disk controller - vmware
Posted by GitBox <gi...@apache.org>.
shwstppr commented on pull request #4416:
URL: https://github.com/apache/cloudstack/pull/4416#issuecomment-772268467
Reopening to address the issue in 4.14
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4416: vmware: disk controller fix
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4416:
URL: https://github.com/apache/cloudstack/pull/4416#issuecomment-826482892
@shwstppr a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] Spaceman1984 commented on pull request #4416: Fixed - unable to change disk controller - vmware
Posted by GitBox <gi...@apache.org>.
Spaceman1984 commented on pull request #4416:
URL: https://github.com/apache/cloudstack/pull/4416#issuecomment-713481437
@blueorangutan package
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4416: Fixed - unable to change disk controller - vmware
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4416:
URL: https://github.com/apache/cloudstack/pull/4416#issuecomment-713481673
@Spaceman1984 a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4416: vmware: disk controller fix
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4416:
URL: https://github.com/apache/cloudstack/pull/4416#issuecomment-772899261
<b>Trillian test result (tid-3483)</b>
Environment: vmware-67u3 (x2), Advanced Networking with Mgmt server 7
Total time taken: 36714 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr4416-t3483-vmware-67u3.zip
Intermittent failure detected: /marvin/tests/smoke/test_service_offerings.py
Intermittent failure detected: /marvin/tests/smoke/test_templates.py
Intermittent failure detected: /marvin/tests/smoke/test_vm_snapshots.py
Smoke tests completed. 80 look OK, 3 have error(s)
Only failed tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
test_04_change_offering_small | `Error` | 5.34 | test_service_offerings.py
test_02_create_template_with_checksum_sha1 | `Error` | 5.23 | test_templates.py
test_03_create_template_with_checksum_sha256 | `Error` | 5.22 | test_templates.py
test_04_create_template_with_checksum_md5 | `Error` | 5.23 | test_templates.py
test_change_service_offering_for_vm_with_snapshots | `Error` | 150.22 | test_vm_snapshots.py
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4416: vmware: disk controller fix
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4416:
URL: https://github.com/apache/cloudstack/pull/4416#issuecomment-826872328
<b>Trillian test result (tid-529)</b>
Environment: vmware-67u3 (x2), Advanced Networking with Mgmt server 7
Total time taken: 34470 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr4416-t529-vmware-67u3.zip
Intermittent failure detected: /marvin/tests/smoke/test_diagnostics.py
Smoke tests completed. 82 look OK, 1 have error(s)
Only failed tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
test_10_traceroute_in_vr | `Failure` | 61.12 | test_diagnostics.py
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] shwstppr commented on pull request #4416: vmware: disk controller fix
Posted by GitBox <gi...@apache.org>.
shwstppr commented on pull request #4416:
URL: https://github.com/apache/cloudstack/pull/4416#issuecomment-826490647
@blueorangutan test centos7 vmware-67u3
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] Spaceman1984 closed pull request #4416: Fixed - unable to change disk controller - vmware
Posted by GitBox <gi...@apache.org>.
Spaceman1984 closed pull request #4416:
URL: https://github.com/apache/cloudstack/pull/4416
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] Spaceman1984 commented on pull request #4416: vmware: disk controller fix
Posted by GitBox <gi...@apache.org>.
Spaceman1984 commented on pull request #4416:
URL: https://github.com/apache/cloudstack/pull/4416#issuecomment-836550848
Raised #5006 PR to fix #4344
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4416: Fixed - unable to change disk controller - vmware
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4416:
URL: https://github.com/apache/cloudstack/pull/4416#issuecomment-713498708
Packaging result: ✔centos7 ✔centos8 ✔debian. JID-2249
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4416: vmware: disk controller fix
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4416:
URL: https://github.com/apache/cloudstack/pull/4416#issuecomment-826482892
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] Spaceman1984 closed pull request #4416: vmware: disk controller fix
Posted by GitBox <gi...@apache.org>.
Spaceman1984 closed pull request #4416:
URL: https://github.com/apache/cloudstack/pull/4416
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] shwstppr commented on pull request #4416: vmware: disk controller fix
Posted by GitBox <gi...@apache.org>.
shwstppr commented on pull request #4416:
URL: https://github.com/apache/cloudstack/pull/4416#issuecomment-826482589
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] shwstppr commented on pull request #4416: vmware: disk controller fix
Posted by GitBox <gi...@apache.org>.
shwstppr commented on pull request #4416:
URL: https://github.com/apache/cloudstack/pull/4416#issuecomment-826482589
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] shwstppr commented on pull request #4416: vmware: disk controller fix
Posted by GitBox <gi...@apache.org>.
shwstppr commented on pull request #4416:
URL: https://github.com/apache/cloudstack/pull/4416#issuecomment-772483662
@blueorangutan test centos7 vmware-67u3
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4416: vmware: disk controller fix
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4416:
URL: https://github.com/apache/cloudstack/pull/4416#issuecomment-772484157
@shwstppr a Trillian-Jenkins test job (centos7 mgmt + vmware-67u3) has been kicked to run smoke tests
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4416: vmware: disk controller fix
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4416:
URL: https://github.com/apache/cloudstack/pull/4416#issuecomment-772293031
Packaging result: ✔centos7 ✖centos8 ✔debian. JID-2643
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on pull request #4416: vmware: disk controller fix
Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #4416:
URL: https://github.com/apache/cloudstack/pull/4416#issuecomment-828258068
ping @Spaceman1984 cc @harikrishna-patnala
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org