You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@subversion.apache.org by Max Bowsher <ma...@ukf.net> on 2005/01/13 14:29:17 UTC
Re: SWIG Again
John Lenz wrote:
> --- subversion/subversion/bindings/swig/core.i~fixswig
> +++ subversion/subversion/bindings/swig/core.i
> @@ -303,6 +303,17 @@
> */
> #ifdef SWIGPERL
>
> +/* Fix for SWIG 1.3.24 */
> +#if SWIG_VERSION == 0x010324
> +%typemap(varin) apr_pool_t * {
> + void *temp;
> + if (SWIG_ConvertPtr($input, (void **) &temp, $1_descriptor,0) <
> 0) {
> + croak("Type error in argument $argnum of $symname. Expected
> $1_mangle"); + }
> + $1 = ($1_ltype) temp;
> +}
> +#endif
> +
> apr_pool_t *current_pool;
>
> %{
I've started to investigate swig 1.3.24 support (and successfully got
mailer.py working with a swig 1.3.24 bindings install!).
I don't understand the above chunk of patch though.
Could someone explain why it is needed, and confirm whether it really is
just for swig 1.3.24, or should be for 1.3.24 and later?
Thanks,
Max.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Re: SWIG Again
Posted by Max Bowsher <ma...@ukf.net>.
John Lenz wrote:
> On 01/13/05 08:29:17, Max Bowsher wrote:
>> John Lenz wrote:
>>
>>> --- subversion/subversion/bindings/swig/core.i~fixswig
>>> +++ subversion/subversion/bindings/swig/core.i
>>> @@ -303,6 +303,17 @@
>>> */
>>> #ifdef SWIGPERL
>>>
>>> +/* Fix for SWIG 1.3.24 */
>>> +#if SWIG_VERSION == 0x010324
>>> +%typemap(varin) apr_pool_t * {
>>> + void *temp;
>>> + if (SWIG_ConvertPtr($input, (void **) &temp, $1_descriptor,0) <
>>> 0) {
>>> + croak("Type error in argument $argnum of $symname. Expected
>>> $1_mangle"); + }
>>> + $1 = ($1_ltype) temp;
>>> +}
>>> +#endif
>>> +
>>> apr_pool_t *current_pool;
>>>
>>> %{
>>
>>
>> I've started to investigate swig 1.3.24 support (and successfully got
>> mailer.py working with a swig 1.3.24 bindings install!).
>>
>> I don't understand the above chunk of patch though.
>>
>> Could someone explain why it is needed, and confirm whether it really is
>> just for swig 1.3.24, or should be for 1.3.24 and later?
>
> Only 1.3.24. It was a change that got added a while back that caused
> member variable typemaps to crash. Since the old bindings used a get and
> set instead of using a member variable, they were not broken.
>
> The thread below states the problem and the latest SWIG CVS includes the
> fix so the code there is only needed for 1.3.24.
>
> http://mailman.cs.uchicago.edu/pipermail/swig-dev/2004-December/014662.html
Thanks for clarifying!
Max.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Re: SWIG Again
Posted by John Lenz <le...@cs.wisc.edu>.
On 01/13/05 08:29:17, Max Bowsher wrote:
> John Lenz wrote:
>
>> --- subversion/subversion/bindings/swig/core.i~fixswig
>> +++ subversion/subversion/bindings/swig/core.i
>> @@ -303,6 +303,17 @@
>> */
>> #ifdef SWIGPERL
>>
>> +/* Fix for SWIG 1.3.24 */
>> +#if SWIG_VERSION == 0x010324
>> +%typemap(varin) apr_pool_t * {
>> + void *temp;
>> + if (SWIG_ConvertPtr($input, (void **) &temp, $1_descriptor,0) <
>> 0) {
>> + croak("Type error in argument $argnum of $symname. Expected
>> $1_mangle"); + }
>> + $1 = ($1_ltype) temp;
>> +}
>> +#endif
>> +
>> apr_pool_t *current_pool;
>>
>> %{
>
>
> I've started to investigate swig 1.3.24 support (and successfully got
> mailer.py working with a swig 1.3.24 bindings install!).
>
> I don't understand the above chunk of patch though.
>
> Could someone explain why it is needed, and confirm whether it really is
> just for swig 1.3.24, or should be for 1.3.24 and later?
Only 1.3.24. It was a change that got added a while back that caused
member variable typemaps to crash. Since the old bindings used a get and
set instead of using a member variable, they were not broken.
The thread below states the problem and the latest SWIG CVS includes the
fix so the code there is only needed for 1.3.24.
http://mailman.cs.uchicago.edu/pipermail/swig-dev/2004-December/014662.html
John
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org