[GitHub] [httpcomponents-client] carterkozak commented on a change in pull request #236: HTTPCLIENT-2096: Migrate instance loggers to static fields

[GitBox <gi...@apache.org>]

carterkozak commented on a change in pull request #236:
URL: https://github.com/apache/httpcomponents-client/pull/236#discussion_r450263910



##########
File path: httpclient5/src/main/java/org/apache/hc/client5/http/ssl/SSLConnectionSocketFactory.java
##########
@@ -266,13 +266,13 @@ public Socket createLayeredSocket(
             sslsock.setEnabledCipherSuites(TlsCiphers.excludeWeak(sslsock.getEnabledCipherSuites()));
         }
 
-        if (this.log.isDebugEnabled()) {
-            this.log.debug("Enabled protocols: {}", Arrays.asList(sslsock.getEnabledProtocols()));
-            this.log.debug("Enabled cipher suites:{}", Arrays.asList(sslsock.getEnabledCipherSuites()));
+        if (LOG.isDebugEnabled()) {
+            LOG.debug("Enabled protocols: {}", Arrays.asList(sslsock.getEnabledProtocols()));
+            LOG.debug("Enabled cipher suites:{}", Arrays.asList(sslsock.getEnabledCipherSuites()));

Review comment:
       Now that we're using slf4j interpolation, logging the `String[]` directly without wrapping should be fine. Missing a space after the colon.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org