You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@shardingsphere.apache.org by Zhang Yonglun <zh...@apache.org> on 2019/08/09 10:46:33 UTC

[DISCUSS] Apache ShardingSphere (Incubating) 4.0.0-RC2 release [ROUND 4]

Hello ShardingSphere Community,

This is a call for the 4th round of discussion to release Apache
ShardingSphere (Incubating) version 4.0.0-RC2

Release notes:
https://github.com/apache/incubator-shardingsphere/releases/edit/untagged-08931c6025e028ee428c

Git branch for the release:
The dev branch of ShardingSphere(
https://github.com/apache/incubator-shardingsphere.git)

We have fixed all know serious issues found during the integration test. So
the dev branch is ready for discussion.

Anyone who is interested can do this acceptance test and discuss whether
this version should be released or not.

-- 
Zhang Yonglun
Apache ShardingSphere

Re: [DISCUSS] Apache ShardingSphere (Incubating) 4.0.0-RC2 release [ROUND 4]

Posted by Zhang Yonglun <zh...@apache.org>.
Thanks for you response.
This is the new link to the release notes:
https://github.com/apache/incubator-shardingsphere/blob/dev/RELEASE-NOTES.md

Rimaljit Kaur <ri...@gmail.com> 于2019年8月9日周五 下午6:58写道:

>
> https://github.com/apache/incubator-shardingsphere/releases/edit/untagged-08931c6025e028ee428c
> is
> redirecting me to github.com.
>
> On Fri, Aug 9, 2019 at 4:16 PM Zhang Yonglun <zh...@apache.org>
> wrote:
>
> > Hello ShardingSphere Community,
> >
> > This is a call for the 4th round of discussion to release Apache
> > ShardingSphere (Incubating) version 4.0.0-RC2
> >
> > Release notes:
> >
> >
> https://github.com/apache/incubator-shardingsphere/releases/edit/untagged-08931c6025e028ee428c
> >
> > Git branch for the release:
> > The dev branch of ShardingSphere(
> > https://github.com/apache/incubator-shardingsphere.git)
> >
> > We have fixed all know serious issues found during the integration test.
> So
> > the dev branch is ready for discussion.
> >
> > Anyone who is interested can do this acceptance test and discuss whether
> > this version should be released or not.
> >
> > --
> > Zhang Yonglun
> > Apache ShardingSphere
> >
>


-- 
Zhang Yonglun
Apache ShardingSphere

Re: [DISCUSS] Apache ShardingSphere (Incubating) 4.0.0-RC2 release [ROUND 4]

Posted by "zhangliang@apache.org" <zh...@apache.org>.
Good suggestion, we should use a new file to show draft release note

------------------

Liang Zhang (John)
Apache ShardingSphere & Dubbo


Sheng Wu <wu...@gmail.com> 于2019年8月9日周五 下午7:14写道:

> Yes. GitHub release draft is unavailable from no-committer.
>
> I suggest providing changes file like this,
> https://github.com/apache/skywalking/blob/master/CHANGES.md
>
> Sheng Wu 吴晟
>
> Apache SkyWalking, Apache ShardingSphere(Incubating), Zipkin
> Twitter, wusheng1108
>
>
> Rimaljit Kaur <ri...@gmail.com> 于2019年8月9日周五 下午6:58写道:
>
> >
> >
> https://github.com/apache/incubator-shardingsphere/releases/edit/untagged-08931c6025e028ee428c
> > is
> > redirecting me to github.com.
> >
> > On Fri, Aug 9, 2019 at 4:16 PM Zhang Yonglun <zh...@apache.org>
> > wrote:
> >
> > > Hello ShardingSphere Community,
> > >
> > > This is a call for the 4th round of discussion to release Apache
> > > ShardingSphere (Incubating) version 4.0.0-RC2
> > >
> > > Release notes:
> > >
> > >
> >
> https://github.com/apache/incubator-shardingsphere/releases/edit/untagged-08931c6025e028ee428c
> > >
> > > Git branch for the release:
> > > The dev branch of ShardingSphere(
> > > https://github.com/apache/incubator-shardingsphere.git)
> > >
> > > We have fixed all know serious issues found during the integration
> test.
> > So
> > > the dev branch is ready for discussion.
> > >
> > > Anyone who is interested can do this acceptance test and discuss
> whether
> > > this version should be released or not.
> > >
> > > --
> > > Zhang Yonglun
> > > Apache ShardingSphere
> > >
> >
>

Re: [DISCUSS] Apache ShardingSphere (Incubating) 4.0.0-RC2 release [ROUND 4]

Posted by Sheng Wu <wu...@gmail.com>.
Yes. GitHub release draft is unavailable from no-committer.

I suggest providing changes file like this,
https://github.com/apache/skywalking/blob/master/CHANGES.md

Sheng Wu 吴晟

Apache SkyWalking, Apache ShardingSphere(Incubating), Zipkin
Twitter, wusheng1108


Rimaljit Kaur <ri...@gmail.com> 于2019年8月9日周五 下午6:58写道:

>
> https://github.com/apache/incubator-shardingsphere/releases/edit/untagged-08931c6025e028ee428c
> is
> redirecting me to github.com.
>
> On Fri, Aug 9, 2019 at 4:16 PM Zhang Yonglun <zh...@apache.org>
> wrote:
>
> > Hello ShardingSphere Community,
> >
> > This is a call for the 4th round of discussion to release Apache
> > ShardingSphere (Incubating) version 4.0.0-RC2
> >
> > Release notes:
> >
> >
> https://github.com/apache/incubator-shardingsphere/releases/edit/untagged-08931c6025e028ee428c
> >
> > Git branch for the release:
> > The dev branch of ShardingSphere(
> > https://github.com/apache/incubator-shardingsphere.git)
> >
> > We have fixed all know serious issues found during the integration test.
> So
> > the dev branch is ready for discussion.
> >
> > Anyone who is interested can do this acceptance test and discuss whether
> > this version should be released or not.
> >
> > --
> > Zhang Yonglun
> > Apache ShardingSphere
> >
>

Re: [DISCUSS] Apache ShardingSphere (Incubating) 4.0.0-RC2 release [ROUND 4]

Posted by Rimaljit Kaur <ri...@gmail.com>.
https://github.com/apache/incubator-shardingsphere/releases/edit/untagged-08931c6025e028ee428c
is
redirecting me to github.com.

On Fri, Aug 9, 2019 at 4:16 PM Zhang Yonglun <zh...@apache.org>
wrote:

> Hello ShardingSphere Community,
>
> This is a call for the 4th round of discussion to release Apache
> ShardingSphere (Incubating) version 4.0.0-RC2
>
> Release notes:
>
> https://github.com/apache/incubator-shardingsphere/releases/edit/untagged-08931c6025e028ee428c
>
> Git branch for the release:
> The dev branch of ShardingSphere(
> https://github.com/apache/incubator-shardingsphere.git)
>
> We have fixed all know serious issues found during the integration test. So
> the dev branch is ready for discussion.
>
> Anyone who is interested can do this acceptance test and discuss whether
> this version should be released or not.
>
> --
> Zhang Yonglun
> Apache ShardingSphere
>

Re: [DISCUSS] Apache ShardingSphere (Incubating) 4.0.0-RC2 release [ROUND 4]

Posted by juan pan <pa...@apache.org>.
Today, i ran some tests, and a bug of wrong rewritten SQL for `INSERT` in
multiple threads appeared. Now this bug has been fixed already. It is not a
big deal, so i think we can continue to prepare our version 4.0.0-RC2.
---------------------------------
Juan Pan (Trista)
Apache ShardingSphere


Zhang Yonglun <zh...@apache.org> 于2019年8月9日周五 下午6:46写道:

> Hello ShardingSphere Community,
>
> This is a call for the 4th round of discussion to release Apache
> ShardingSphere (Incubating) version 4.0.0-RC2
>
> Release notes:
>
> https://github.com/apache/incubator-shardingsphere/releases/edit/untagged-08931c6025e028ee428c
>
> Git branch for the release:
> The dev branch of ShardingSphere(
> https://github.com/apache/incubator-shardingsphere.git)
>
> We have fixed all know serious issues found during the integration test. So
> the dev branch is ready for discussion.
>
> Anyone who is interested can do this acceptance test and discuss whether
> this version should be released or not.
>
> --
> Zhang Yonglun
> Apache ShardingSphere
>

Re: [NOTICED] Lead diversity. Original: [DISCUSS] Apache ShardingSphere (Incubating) 4.0.0-RC2 release [ROUND 4]

Posted by Sheng Wu <wu...@gmail.com>.
I mean this

> This version is also use to company, we just test on some projects, maybe
> some bug need to be hot fix, after finished it, we can start to vote

This style of words is showing the project belongs to only one
company implicitly from my understanding, at least, this one company use
case is the most important one.
If there is a bug blocking the vote, you should refer/submit an issue to
track.
There is nothing related between the project release and internal tests.

Clearly, the project could be released if it follows one release manager
and community processes.
A release w/ bugs is normal, that is a hot-fix release for, right?

There is just a reminder from my observations.

Sheng Wu 吴晟

Apache SkyWalking, Apache ShardingSphere(Incubating), Zipkin
Twitter, wusheng1108


zhangliang@apache.org <zh...@apache.org> 于2019年8月16日周五 上午11:33写道:

> Yes, I totally agree ShardingSphere is a diversity community. JD.com is a
> part of ShardingSphere's community.
> This version find some problems from JD.com when they tested, so we just
> hot fix bugs to make sure this version is more stable.
>
> ------------------
>
> Liang Zhang (John)
> Apache ShardingSphere & Dubbo
>
>
> Sheng Wu <wu...@gmail.com> 于2019年8月15日周四 下午8:41写道:
>
> > zhangliang@apache.org <zh...@apache.org> 于2019年8月15日周四 下午6:05写道:
> >
> > > This version is also use to company, we just test on some projects,
> maybe
> > > some bug need to be hot fix, after finished it, we can start to vote
> > >
> >
> >
> > Hi Liang
> >
> > Please be advised, you and jd.com team should be a part of the
> > shardingsphere community.
> > We will need other parts to lead the release.
> > Also, release and vote should be a consensus, which should not be jd.com
> > internal integration.
> >
> > Right now, I would say this is a signal that the release manager and
> > release process are not diversity.
> > We need to make progress in both this and new committers. There are the
> > keys to make shardingsphere widely and fit TLP goal.
> >
> > Sheng Wu 吴晟
> >
> > Apache SkyWalking, Apache ShardingSphere(Incubating), Zipkin
> > Twitter, wusheng1108
> >
> >
> > >
> > > ------------------
> > >
> > > Liang Zhang (John)
> > > Apache ShardingSphere & Dubbo
> > >
> > >
> > > Sion Yang <sc...@163.com> 于2019年8月13日周二 下午6:38写道:
> > >
> > > > I execute all examples. Most of examples execute successfully except
> > > > encrypt in JPA with SpringBoot.
> > > > The bug has marked `TODO` in example, and only affects part of
> encrypt.
> > > > So i think we can continue to prepare our version 4.0.0-RC2.
> > > >
> > > >
> > > > --
> > > >
> > > > Yi Yang(Sion)
> > > > Apache ShardingSphere
> > > >
> > > >
> > > >
> > > > At 2019-08-09 18:46:33, "Zhang Yonglun" <zh...@apache.org>
> > wrote:
> > > > >Hello ShardingSphere Community,
> > > > >
> > > > >This is a call for the 4th round of discussion to release Apache
> > > > >ShardingSphere (Incubating) version 4.0.0-RC2
> > > > >
> > > > >Release notes:
> > > > >
> > > >
> > >
> >
> https://github.com/apache/incubator-shardingsphere/releases/edit/untagged-08931c6025e028ee428c
> > > > >
> > > > >Git branch for the release:
> > > > >The dev branch of ShardingSphere(
> > > > >https://github.com/apache/incubator-shardingsphere.git)
> > > > >
> > > > >We have fixed all know serious issues found during the integration
> > test.
> > > > So
> > > > >the dev branch is ready for discussion.
> > > > >
> > > > >Anyone who is interested can do this acceptance test and discuss
> > whether
> > > > >this version should be released or not.
> > > > >
> > > > >--
> > > > >Zhang Yonglun
> > > > >Apache ShardingSphere
> > > >
> > >
> >
>

Re: [NOTICED] Lead diversity. Original: [DISCUSS] Apache ShardingSphere (Incubating) 4.0.0-RC2 release [ROUND 4]

Posted by "zhangliang@apache.org" <zh...@apache.org>.
Yes, I totally agree ShardingSphere is a diversity community. JD.com is a
part of ShardingSphere's community.
This version find some problems from JD.com when they tested, so we just
hot fix bugs to make sure this version is more stable.

------------------

Liang Zhang (John)
Apache ShardingSphere & Dubbo


Sheng Wu <wu...@gmail.com> 于2019年8月15日周四 下午8:41写道:

> zhangliang@apache.org <zh...@apache.org> 于2019年8月15日周四 下午6:05写道:
>
> > This version is also use to company, we just test on some projects, maybe
> > some bug need to be hot fix, after finished it, we can start to vote
> >
>
>
> Hi Liang
>
> Please be advised, you and jd.com team should be a part of the
> shardingsphere community.
> We will need other parts to lead the release.
> Also, release and vote should be a consensus, which should not be jd.com
> internal integration.
>
> Right now, I would say this is a signal that the release manager and
> release process are not diversity.
> We need to make progress in both this and new committers. There are the
> keys to make shardingsphere widely and fit TLP goal.
>
> Sheng Wu 吴晟
>
> Apache SkyWalking, Apache ShardingSphere(Incubating), Zipkin
> Twitter, wusheng1108
>
>
> >
> > ------------------
> >
> > Liang Zhang (John)
> > Apache ShardingSphere & Dubbo
> >
> >
> > Sion Yang <sc...@163.com> 于2019年8月13日周二 下午6:38写道:
> >
> > > I execute all examples. Most of examples execute successfully except
> > > encrypt in JPA with SpringBoot.
> > > The bug has marked `TODO` in example, and only affects part of encrypt.
> > > So i think we can continue to prepare our version 4.0.0-RC2.
> > >
> > >
> > > --
> > >
> > > Yi Yang(Sion)
> > > Apache ShardingSphere
> > >
> > >
> > >
> > > At 2019-08-09 18:46:33, "Zhang Yonglun" <zh...@apache.org>
> wrote:
> > > >Hello ShardingSphere Community,
> > > >
> > > >This is a call for the 4th round of discussion to release Apache
> > > >ShardingSphere (Incubating) version 4.0.0-RC2
> > > >
> > > >Release notes:
> > > >
> > >
> >
> https://github.com/apache/incubator-shardingsphere/releases/edit/untagged-08931c6025e028ee428c
> > > >
> > > >Git branch for the release:
> > > >The dev branch of ShardingSphere(
> > > >https://github.com/apache/incubator-shardingsphere.git)
> > > >
> > > >We have fixed all know serious issues found during the integration
> test.
> > > So
> > > >the dev branch is ready for discussion.
> > > >
> > > >Anyone who is interested can do this acceptance test and discuss
> whether
> > > >this version should be released or not.
> > > >
> > > >--
> > > >Zhang Yonglun
> > > >Apache ShardingSphere
> > >
> >
>

[NOTICED] Lead diversity. Original: [DISCUSS] Apache ShardingSphere (Incubating) 4.0.0-RC2 release [ROUND 4]

Posted by Sheng Wu <wu...@gmail.com>.
zhangliang@apache.org <zh...@apache.org> 于2019年8月15日周四 下午6:05写道:

> This version is also use to company, we just test on some projects, maybe
> some bug need to be hot fix, after finished it, we can start to vote
>


Hi Liang

Please be advised, you and jd.com team should be a part of the
shardingsphere community.
We will need other parts to lead the release.
Also, release and vote should be a consensus, which should not be jd.com
internal integration.

Right now, I would say this is a signal that the release manager and
release process are not diversity.
We need to make progress in both this and new committers. There are the
keys to make shardingsphere widely and fit TLP goal.

Sheng Wu 吴晟

Apache SkyWalking, Apache ShardingSphere(Incubating), Zipkin
Twitter, wusheng1108


>
> ------------------
>
> Liang Zhang (John)
> Apache ShardingSphere & Dubbo
>
>
> Sion Yang <sc...@163.com> 于2019年8月13日周二 下午6:38写道:
>
> > I execute all examples. Most of examples execute successfully except
> > encrypt in JPA with SpringBoot.
> > The bug has marked `TODO` in example, and only affects part of encrypt.
> > So i think we can continue to prepare our version 4.0.0-RC2.
> >
> >
> > --
> >
> > Yi Yang(Sion)
> > Apache ShardingSphere
> >
> >
> >
> > At 2019-08-09 18:46:33, "Zhang Yonglun" <zh...@apache.org> wrote:
> > >Hello ShardingSphere Community,
> > >
> > >This is a call for the 4th round of discussion to release Apache
> > >ShardingSphere (Incubating) version 4.0.0-RC2
> > >
> > >Release notes:
> > >
> >
> https://github.com/apache/incubator-shardingsphere/releases/edit/untagged-08931c6025e028ee428c
> > >
> > >Git branch for the release:
> > >The dev branch of ShardingSphere(
> > >https://github.com/apache/incubator-shardingsphere.git)
> > >
> > >We have fixed all know serious issues found during the integration test.
> > So
> > >the dev branch is ready for discussion.
> > >
> > >Anyone who is interested can do this acceptance test and discuss whether
> > >this version should be released or not.
> > >
> > >--
> > >Zhang Yonglun
> > >Apache ShardingSphere
> >
>

Re: [DISCUSS] Apache ShardingSphere (Incubating) 4.0.0-RC2 release [ROUND 4]

Posted by "zhangliang@apache.org" <zh...@apache.org>.
This version is also use to company, we just test on some projects, maybe
some bug need to be hot fix, after finished it, we can start to vote

------------------

Liang Zhang (John)
Apache ShardingSphere & Dubbo


Sion Yang <sc...@163.com> 于2019年8月13日周二 下午6:38写道:

> I execute all examples. Most of examples execute successfully except
> encrypt in JPA with SpringBoot.
> The bug has marked `TODO` in example, and only affects part of encrypt.
> So i think we can continue to prepare our version 4.0.0-RC2.
>
>
> --
>
> Yi Yang(Sion)
> Apache ShardingSphere
>
>
>
> At 2019-08-09 18:46:33, "Zhang Yonglun" <zh...@apache.org> wrote:
> >Hello ShardingSphere Community,
> >
> >This is a call for the 4th round of discussion to release Apache
> >ShardingSphere (Incubating) version 4.0.0-RC2
> >
> >Release notes:
> >
> https://github.com/apache/incubator-shardingsphere/releases/edit/untagged-08931c6025e028ee428c
> >
> >Git branch for the release:
> >The dev branch of ShardingSphere(
> >https://github.com/apache/incubator-shardingsphere.git)
> >
> >We have fixed all know serious issues found during the integration test.
> So
> >the dev branch is ready for discussion.
> >
> >Anyone who is interested can do this acceptance test and discuss whether
> >this version should be released or not.
> >
> >--
> >Zhang Yonglun
> >Apache ShardingSphere
>

Re: [DISCUSS] Apache ShardingSphere (Incubating) 4.0.0-RC2 release [ROUND 4]

Posted by Zhang Yonglun <zh...@apache.org>.
Hi Craig,

Thanks for your reminder. I understand that a key motto at Apache is “If it
didn’t happen on the mailing list, it didn’t happen.”
I have called for a discussion for the issue 2884. You can find it in
this thread:
https://lists.apache.org/thread.html/453b317fef1e679b0ae9e45632718395a5f3df489044f6937dc614ca@%3Cdev.shardingsphere.apache.org%3E

Craig Russell <ap...@gmail.com> 于2019年8月21日周三 上午2:28写道:

> Hi Yonglun,
>
> Where was the discussion about the issue 2884?
>
> I cannot find it in the mail archives.
>
> Regards,
>
> Craig
>
> > On Aug 16, 2019, at 9:33 PM, Zhang Yonglun <zh...@apache.org>
> wrote:
> >
> > The issue #2884 mentioned by Sion Yang was determined to be fixed in the
> > next release.
> >
> > So, the discussion is complete, let's go to the vote stage.
> >
> > juan pan <pa...@apache.org> 于2019年8月16日周五 下午10:10写道:
> >
> >> The issue[1] mentioned by Sion Yang has been fixed already, please check
> >> the Pr[2].
> >>
> >> [1] https://github.com/apache/incubator-shardingsphere/issues/2883
> >> [2] https://github.com/apache/incubator-shardingsphere/pull/2886
> >> ---------------------------------
> >> Juan Pan (Trista)
> >> Apache ShardingSphere
> >>
> >>
> >> Sion Yang <sc...@163.com> 于2019年8月16日周五 下午5:17写道:
> >>
> >>> These two issues can reproduce in
> >>> apache/incubator-shardingsphere-example[1].
> >>> And I also open issue in GitHub[2][3].
> >>>
> >>>
> >>> [1] https://github.com/apache/incubator-shardingsphere-example
> >>> [2] https://github.com/apache/incubator-shardingsphere/issues/2883
> >>> [3] https://github.com/apache/incubator-shardingsphere/issues/2884
> >>>
> >>>
> >>> --
> >>>
> >>> Yi Yang(Sion)
> >>> Apache ShardingSphere
> >>>
> >>>
> >>>
> >>> At 2019-08-16 17:09:48, "Sion Yang" <sc...@163.com> wrote:
> >>>> There are another issue[1] for encrypt in 4.0.0-RC2.
> >>>> Encrypt may replace table name with column so that the column in SQL
> >>> become `column.column`.
> >>>>
> >>>>
> >>>> [1] https://github.com/apache/incubator-shardingsphere/issues/2883
> >>>>
> >>>>
> >>>> --
> >>>>
> >>>> Yi Yang(Sion)
> >>>> Apache ShardingSphere
> >>>>
> >>>>
> >>>>
> >>>> At 2019-08-13 18:38:13, "Sion Yang" <sc...@163.com> wrote:
> >>>>> I execute all examples. Most of examples execute successfully except
> >>> encrypt in JPA with SpringBoot.
> >>>>> The bug has marked `TODO` in example, and only affects part of
> encrypt.
> >>>>> So i think we can continue to prepare our version 4.0.0-RC2.
> >>>>>
> >>>>>
> >>>>> --
> >>>>>
> >>>>> Yi Yang(Sion)
> >>>>> Apache ShardingSphere
> >>>>>
> >>>>>
> >>>>>
> >>>>> At 2019-08-09 18:46:33, "Zhang Yonglun" <zh...@apache.org>
> >> wrote:
> >>>>>> Hello ShardingSphere Community,
> >>>>>>
> >>>>>> This is a call for the 4th round of discussion to release Apache
> >>>>>> ShardingSphere (Incubating) version 4.0.0-RC2
> >>>>>>
> >>>>>> Release notes:
> >>>>>>
> >>>
> >>
> https://github.com/apache/incubator-shardingsphere/releases/edit/untagged-08931c6025e028ee428c
> >>>>>>
> >>>>>> Git branch for the release:
> >>>>>> The dev branch of ShardingSphere(
> >>>>>> https://github.com/apache/incubator-shardingsphere.git)
> >>>>>>
> >>>>>> We have fixed all know serious issues found during the integration
> >>> test. So
> >>>>>> the dev branch is ready for discussion.
> >>>>>>
> >>>>>> Anyone who is interested can do this acceptance test and discuss
> >> whether
> >>>>>> this version should be released or not.
> >>>>>>
> >>>>>> --
> >>>>>> Zhang Yonglun
> >>>>>> Apache ShardingSphere
> >>>
> >>
> >
> >
> > --
> > Zhang Yonglun
> > Apache ShardingSphere
>
> Craig L Russell
> clr@apache.org
>
>

-- 
Zhang Yonglun
Apache ShardingSphere

Re: [DISCUSS] Apache ShardingSphere (Incubating) 4.0.0-RC2 release [ROUND 4]

Posted by Craig Russell <ap...@gmail.com>.
Hi Yonglun,

Where was the discussion about the issue 2884? 

I cannot find it in the mail archives.

Regards,

Craig

> On Aug 16, 2019, at 9:33 PM, Zhang Yonglun <zh...@apache.org> wrote:
> 
> The issue #2884 mentioned by Sion Yang was determined to be fixed in the
> next release.
> 
> So, the discussion is complete, let's go to the vote stage.
> 
> juan pan <pa...@apache.org> 于2019年8月16日周五 下午10:10写道:
> 
>> The issue[1] mentioned by Sion Yang has been fixed already, please check
>> the Pr[2].
>> 
>> [1] https://github.com/apache/incubator-shardingsphere/issues/2883
>> [2] https://github.com/apache/incubator-shardingsphere/pull/2886
>> ---------------------------------
>> Juan Pan (Trista)
>> Apache ShardingSphere
>> 
>> 
>> Sion Yang <sc...@163.com> 于2019年8月16日周五 下午5:17写道:
>> 
>>> These two issues can reproduce in
>>> apache/incubator-shardingsphere-example[1].
>>> And I also open issue in GitHub[2][3].
>>> 
>>> 
>>> [1] https://github.com/apache/incubator-shardingsphere-example
>>> [2] https://github.com/apache/incubator-shardingsphere/issues/2883
>>> [3] https://github.com/apache/incubator-shardingsphere/issues/2884
>>> 
>>> 
>>> --
>>> 
>>> Yi Yang(Sion)
>>> Apache ShardingSphere
>>> 
>>> 
>>> 
>>> At 2019-08-16 17:09:48, "Sion Yang" <sc...@163.com> wrote:
>>>> There are another issue[1] for encrypt in 4.0.0-RC2.
>>>> Encrypt may replace table name with column so that the column in SQL
>>> become `column.column`.
>>>> 
>>>> 
>>>> [1] https://github.com/apache/incubator-shardingsphere/issues/2883
>>>> 
>>>> 
>>>> --
>>>> 
>>>> Yi Yang(Sion)
>>>> Apache ShardingSphere
>>>> 
>>>> 
>>>> 
>>>> At 2019-08-13 18:38:13, "Sion Yang" <sc...@163.com> wrote:
>>>>> I execute all examples. Most of examples execute successfully except
>>> encrypt in JPA with SpringBoot.
>>>>> The bug has marked `TODO` in example, and only affects part of encrypt.
>>>>> So i think we can continue to prepare our version 4.0.0-RC2.
>>>>> 
>>>>> 
>>>>> --
>>>>> 
>>>>> Yi Yang(Sion)
>>>>> Apache ShardingSphere
>>>>> 
>>>>> 
>>>>> 
>>>>> At 2019-08-09 18:46:33, "Zhang Yonglun" <zh...@apache.org>
>> wrote:
>>>>>> Hello ShardingSphere Community,
>>>>>> 
>>>>>> This is a call for the 4th round of discussion to release Apache
>>>>>> ShardingSphere (Incubating) version 4.0.0-RC2
>>>>>> 
>>>>>> Release notes:
>>>>>> 
>>> 
>> https://github.com/apache/incubator-shardingsphere/releases/edit/untagged-08931c6025e028ee428c
>>>>>> 
>>>>>> Git branch for the release:
>>>>>> The dev branch of ShardingSphere(
>>>>>> https://github.com/apache/incubator-shardingsphere.git)
>>>>>> 
>>>>>> We have fixed all know serious issues found during the integration
>>> test. So
>>>>>> the dev branch is ready for discussion.
>>>>>> 
>>>>>> Anyone who is interested can do this acceptance test and discuss
>> whether
>>>>>> this version should be released or not.
>>>>>> 
>>>>>> --
>>>>>> Zhang Yonglun
>>>>>> Apache ShardingSphere
>>> 
>> 
> 
> 
> -- 
> Zhang Yonglun
> Apache ShardingSphere

Craig L Russell
clr@apache.org


Re: Re:Re:[DISCUSS] Apache ShardingSphere (Incubating) 4.0.0-RC2 release [ROUND 4]

Posted by Zhang Yonglun <zh...@apache.org>.
The issue #2884 mentioned by Sion Yang was determined to be fixed in the
next release.

So, the discussion is complete, let's go to the vote stage.

juan pan <pa...@apache.org> 于2019年8月16日周五 下午10:10写道:

> The issue[1] mentioned by Sion Yang has been fixed already, please check
> the Pr[2].
>
> [1] https://github.com/apache/incubator-shardingsphere/issues/2883
> [2] https://github.com/apache/incubator-shardingsphere/pull/2886
> ---------------------------------
> Juan Pan (Trista)
> Apache ShardingSphere
>
>
> Sion Yang <sc...@163.com> 于2019年8月16日周五 下午5:17写道:
>
> > These two issues can reproduce in
> > apache/incubator-shardingsphere-example[1].
> > And I also open issue in GitHub[2][3].
> >
> >
> > [1] https://github.com/apache/incubator-shardingsphere-example
> > [2] https://github.com/apache/incubator-shardingsphere/issues/2883
> > [3] https://github.com/apache/incubator-shardingsphere/issues/2884
> >
> >
> > --
> >
> > Yi Yang(Sion)
> > Apache ShardingSphere
> >
> >
> >
> > At 2019-08-16 17:09:48, "Sion Yang" <sc...@163.com> wrote:
> > >There are another issue[1] for encrypt in 4.0.0-RC2.
> > >Encrypt may replace table name with column so that the column in SQL
> > become `column.column`.
> > >
> > >
> > >[1] https://github.com/apache/incubator-shardingsphere/issues/2883
> > >
> > >
> > >--
> > >
> > >Yi Yang(Sion)
> > >Apache ShardingSphere
> > >
> > >
> > >
> > >At 2019-08-13 18:38:13, "Sion Yang" <sc...@163.com> wrote:
> > >>I execute all examples. Most of examples execute successfully except
> > encrypt in JPA with SpringBoot.
> > >>The bug has marked `TODO` in example, and only affects part of encrypt.
> > >>So i think we can continue to prepare our version 4.0.0-RC2.
> > >>
> > >>
> > >>--
> > >>
> > >>Yi Yang(Sion)
> > >>Apache ShardingSphere
> > >>
> > >>
> > >>
> > >>At 2019-08-09 18:46:33, "Zhang Yonglun" <zh...@apache.org>
> wrote:
> > >>>Hello ShardingSphere Community,
> > >>>
> > >>>This is a call for the 4th round of discussion to release Apache
> > >>>ShardingSphere (Incubating) version 4.0.0-RC2
> > >>>
> > >>>Release notes:
> > >>>
> >
> https://github.com/apache/incubator-shardingsphere/releases/edit/untagged-08931c6025e028ee428c
> > >>>
> > >>>Git branch for the release:
> > >>>The dev branch of ShardingSphere(
> > >>>https://github.com/apache/incubator-shardingsphere.git)
> > >>>
> > >>>We have fixed all know serious issues found during the integration
> > test. So
> > >>>the dev branch is ready for discussion.
> > >>>
> > >>>Anyone who is interested can do this acceptance test and discuss
> whether
> > >>>this version should be released or not.
> > >>>
> > >>>--
> > >>>Zhang Yonglun
> > >>>Apache ShardingSphere
> >
>


-- 
Zhang Yonglun
Apache ShardingSphere

Re: Re:Re:[DISCUSS] Apache ShardingSphere (Incubating) 4.0.0-RC2 release [ROUND 4]

Posted by juan pan <pa...@apache.org>.
The issue[1] mentioned by Sion Yang has been fixed already, please check
the Pr[2].

[1] https://github.com/apache/incubator-shardingsphere/issues/2883
[2] https://github.com/apache/incubator-shardingsphere/pull/2886
---------------------------------
Juan Pan (Trista)
Apache ShardingSphere


Sion Yang <sc...@163.com> 于2019年8月16日周五 下午5:17写道:

> These two issues can reproduce in
> apache/incubator-shardingsphere-example[1].
> And I also open issue in GitHub[2][3].
>
>
> [1] https://github.com/apache/incubator-shardingsphere-example
> [2] https://github.com/apache/incubator-shardingsphere/issues/2883
> [3] https://github.com/apache/incubator-shardingsphere/issues/2884
>
>
> --
>
> Yi Yang(Sion)
> Apache ShardingSphere
>
>
>
> At 2019-08-16 17:09:48, "Sion Yang" <sc...@163.com> wrote:
> >There are another issue[1] for encrypt in 4.0.0-RC2.
> >Encrypt may replace table name with column so that the column in SQL
> become `column.column`.
> >
> >
> >[1] https://github.com/apache/incubator-shardingsphere/issues/2883
> >
> >
> >--
> >
> >Yi Yang(Sion)
> >Apache ShardingSphere
> >
> >
> >
> >At 2019-08-13 18:38:13, "Sion Yang" <sc...@163.com> wrote:
> >>I execute all examples. Most of examples execute successfully except
> encrypt in JPA with SpringBoot.
> >>The bug has marked `TODO` in example, and only affects part of encrypt.
> >>So i think we can continue to prepare our version 4.0.0-RC2.
> >>
> >>
> >>--
> >>
> >>Yi Yang(Sion)
> >>Apache ShardingSphere
> >>
> >>
> >>
> >>At 2019-08-09 18:46:33, "Zhang Yonglun" <zh...@apache.org> wrote:
> >>>Hello ShardingSphere Community,
> >>>
> >>>This is a call for the 4th round of discussion to release Apache
> >>>ShardingSphere (Incubating) version 4.0.0-RC2
> >>>
> >>>Release notes:
> >>>
> https://github.com/apache/incubator-shardingsphere/releases/edit/untagged-08931c6025e028ee428c
> >>>
> >>>Git branch for the release:
> >>>The dev branch of ShardingSphere(
> >>>https://github.com/apache/incubator-shardingsphere.git)
> >>>
> >>>We have fixed all know serious issues found during the integration
> test. So
> >>>the dev branch is ready for discussion.
> >>>
> >>>Anyone who is interested can do this acceptance test and discuss whether
> >>>this version should be released or not.
> >>>
> >>>--
> >>>Zhang Yonglun
> >>>Apache ShardingSphere
>

Re:Re:Re:[DISCUSS] Apache ShardingSphere (Incubating) 4.0.0-RC2 release [ROUND 4]

Posted by Sion Yang <sc...@163.com>.
These two issues can reproduce in apache/incubator-shardingsphere-example[1].
And I also open issue in GitHub[2][3].


[1] https://github.com/apache/incubator-shardingsphere-example
[2] https://github.com/apache/incubator-shardingsphere/issues/2883
[3] https://github.com/apache/incubator-shardingsphere/issues/2884


--

Yi Yang(Sion)
Apache ShardingSphere



At 2019-08-16 17:09:48, "Sion Yang" <sc...@163.com> wrote:
>There are another issue[1] for encrypt in 4.0.0-RC2.
>Encrypt may replace table name with column so that the column in SQL become `column.column`.
>
>
>[1] https://github.com/apache/incubator-shardingsphere/issues/2883
>
>
>--
>
>Yi Yang(Sion)
>Apache ShardingSphere
>
>
>
>At 2019-08-13 18:38:13, "Sion Yang" <sc...@163.com> wrote:
>>I execute all examples. Most of examples execute successfully except encrypt in JPA with SpringBoot.  
>>The bug has marked `TODO` in example, and only affects part of encrypt.
>>So i think we can continue to prepare our version 4.0.0-RC2.
>>
>>
>>--
>>
>>Yi Yang(Sion)
>>Apache ShardingSphere
>>
>>
>>
>>At 2019-08-09 18:46:33, "Zhang Yonglun" <zh...@apache.org> wrote:
>>>Hello ShardingSphere Community,
>>>
>>>This is a call for the 4th round of discussion to release Apache
>>>ShardingSphere (Incubating) version 4.0.0-RC2
>>>
>>>Release notes:
>>>https://github.com/apache/incubator-shardingsphere/releases/edit/untagged-08931c6025e028ee428c
>>>
>>>Git branch for the release:
>>>The dev branch of ShardingSphere(
>>>https://github.com/apache/incubator-shardingsphere.git)
>>>
>>>We have fixed all know serious issues found during the integration test. So
>>>the dev branch is ready for discussion.
>>>
>>>Anyone who is interested can do this acceptance test and discuss whether
>>>this version should be released or not.
>>>
>>>-- 
>>>Zhang Yonglun
>>>Apache ShardingSphere

Re:Re:[DISCUSS] Apache ShardingSphere (Incubating) 4.0.0-RC2 release [ROUND 4]

Posted by Sion Yang <sc...@163.com>.
There are another issue[1] for encrypt in 4.0.0-RC2.
Encrypt may replace table name with column so that the column in SQL become `column.column`.


[1] https://github.com/apache/incubator-shardingsphere/issues/2883


--

Yi Yang(Sion)
Apache ShardingSphere



At 2019-08-13 18:38:13, "Sion Yang" <sc...@163.com> wrote:
>I execute all examples. Most of examples execute successfully except encrypt in JPA with SpringBoot.  
>The bug has marked `TODO` in example, and only affects part of encrypt.
>So i think we can continue to prepare our version 4.0.0-RC2.
>
>
>--
>
>Yi Yang(Sion)
>Apache ShardingSphere
>
>
>
>At 2019-08-09 18:46:33, "Zhang Yonglun" <zh...@apache.org> wrote:
>>Hello ShardingSphere Community,
>>
>>This is a call for the 4th round of discussion to release Apache
>>ShardingSphere (Incubating) version 4.0.0-RC2
>>
>>Release notes:
>>https://github.com/apache/incubator-shardingsphere/releases/edit/untagged-08931c6025e028ee428c
>>
>>Git branch for the release:
>>The dev branch of ShardingSphere(
>>https://github.com/apache/incubator-shardingsphere.git)
>>
>>We have fixed all know serious issues found during the integration test. So
>>the dev branch is ready for discussion.
>>
>>Anyone who is interested can do this acceptance test and discuss whether
>>this version should be released or not.
>>
>>-- 
>>Zhang Yonglun
>>Apache ShardingSphere

Re:[DISCUSS] Apache ShardingSphere (Incubating) 4.0.0-RC2 release [ROUND 4]

Posted by Sion Yang <sc...@163.com>.
I execute all examples. Most of examples execute successfully except encrypt in JPA with SpringBoot.  
The bug has marked `TODO` in example, and only affects part of encrypt.
So i think we can continue to prepare our version 4.0.0-RC2.


--

Yi Yang(Sion)
Apache ShardingSphere



At 2019-08-09 18:46:33, "Zhang Yonglun" <zh...@apache.org> wrote:
>Hello ShardingSphere Community,
>
>This is a call for the 4th round of discussion to release Apache
>ShardingSphere (Incubating) version 4.0.0-RC2
>
>Release notes:
>https://github.com/apache/incubator-shardingsphere/releases/edit/untagged-08931c6025e028ee428c
>
>Git branch for the release:
>The dev branch of ShardingSphere(
>https://github.com/apache/incubator-shardingsphere.git)
>
>We have fixed all know serious issues found during the integration test. So
>the dev branch is ready for discussion.
>
>Anyone who is interested can do this acceptance test and discuss whether
>this version should be released or not.
>
>-- 
>Zhang Yonglun
>Apache ShardingSphere