You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pinot.apache.org by "shenyu0127 (via GitHub)" <gi...@apache.org> on 2023/07/13 01:50:24 UTC
[GitHub] [pinot] shenyu0127 opened a new pull request, #11096: Fix a flaky test LLCRealtimeClusterIntegrationTest.testAddRemoveDicionaryAndInvertedIndex.
shenyu0127 opened a new pull request, #11096:
URL: https://github.com/apache/pinot/pull/11096
@Jackie-Jiang helped me identify the root cause.
For more explanations see https://github.com/apache/pinot/issues/11084.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [pinot] shenyu0127 commented on a diff in pull request #11096: Fix a flaky test LLCRealtimeClusterIntegrationTest.testAddRemoveDicionaryAndInvertedIndex.
Posted by "shenyu0127 (via GitHub)" <gi...@apache.org>.
shenyu0127 commented on code in PR #11096:
URL: https://github.com/apache/pinot/pull/11096#discussion_r1263130464
##########
pinot-integration-tests/src/test/java/org/apache/pinot/integration/tests/LLCRealtimeClusterIntegrationTest.java:
##########
@@ -271,7 +271,17 @@ public void testAddRemoveDictionaryAndInvertedIndex()
JsonNode queryResponse = postQuery(query);
assertEquals(queryResponse.get("totalDocs").asLong(), numTotalDocs);
// Full table scan without dictionary
- assertEquals(queryResponse.get("numEntriesScannedInFilter").asLong(), numTotalDocs);
+ // The offline segments are created deterministically and all the offline segments contain "ActualElapsedTime =
+ // -9999" records.
+ // The realtime segments are created non-deterministically (uses system time for Kafka partitioning) and there is
Review Comment:
Done.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [pinot] navina commented on a diff in pull request #11096: Fix a flaky test LLCRealtimeClusterIntegrationTest.testAddRemoveDicionaryAndInvertedIndex.
Posted by "navina (via GitHub)" <gi...@apache.org>.
navina commented on code in PR #11096:
URL: https://github.com/apache/pinot/pull/11096#discussion_r1262954847
##########
pinot-integration-tests/src/test/java/org/apache/pinot/integration/tests/LLCRealtimeClusterIntegrationTest.java:
##########
@@ -271,7 +271,17 @@ public void testAddRemoveDictionaryAndInvertedIndex()
JsonNode queryResponse = postQuery(query);
assertEquals(queryResponse.get("totalDocs").asLong(), numTotalDocs);
// Full table scan without dictionary
- assertEquals(queryResponse.get("numEntriesScannedInFilter").asLong(), numTotalDocs);
+ // The offline segments are created deterministically and all the offline segments contain "ActualElapsedTime =
+ // -9999" records.
+ // The realtime segments are created non-deterministically (uses system time for Kafka partitioning) and there is
Review Comment:
Would it be a better fix to make the data partitioning more deterministic for realtime tests?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [pinot] codecov-commenter commented on pull request #11096: Fix a flaky test LLCRealtimeClusterIntegrationTest.testAddRemoveDicionaryAndInvertedIndex.
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #11096:
URL: https://github.com/apache/pinot/pull/11096#issuecomment-1633449426
## [Codecov](https://app.codecov.io/gh/apache/pinot/pull/11096?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
> Merging [#11096](https://app.codecov.io/gh/apache/pinot/pull/11096?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (1a06c34) into [master](https://app.codecov.io/gh/apache/pinot/commit/b39329966f8aff7bf3d7e7b05fad5f78e07ebc6b?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (b393299) will **increase** coverage by `0.00%`.
> The diff coverage is `n/a`.
```diff
@@ Coverage Diff @@
## master #11096 +/- ##
=========================================
Coverage 0.11% 0.11%
=========================================
Files 2203 2148 -55
Lines 118144 115621 -2523
Branches 17877 17571 -306
=========================================
Hits 137 137
+ Misses 117987 115464 -2523
Partials 20 20
```
| Flag | Coverage Δ | |
|---|---|---|
| integration1temurin11 | `?` | |
| integration1temurin17 | `?` | |
| integration1temurin20 | `?` | |
| integration2temurin11 | `?` | |
| integration2temurin17 | `?` | |
| integration2temurin20 | `?` | |
| unittests1temurin11 | `?` | |
| unittests1temurin17 | `?` | |
| unittests1temurin20 | `?` | |
| unittests2temurin11 | `0.11% <ø> (ø)` | |
| unittests2temurin17 | `?` | |
| unittests2temurin20 | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
[see 57 files with indirect coverage changes](https://app.codecov.io/gh/apache/pinot/pull/11096/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [pinot] Jackie-Jiang merged pull request #11096: Fix a flaky test LLCRealtimeClusterIntegrationTest.testAddRemoveDicionaryAndInvertedIndex.
Posted by "Jackie-Jiang (via GitHub)" <gi...@apache.org>.
Jackie-Jiang merged PR #11096:
URL: https://github.com/apache/pinot/pull/11096
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org