[GitHub] [spark] dh20 edited a comment on pull request #34549: [SPARK-37274][SQL]When the value of this parameter is greater than the maximum value of int type, the value will be thrown out of bounds. The document description of this parameter should remind the user of this risk point

[GitBox <gi...@apache.org>]

dh20 edited a comment on pull request #34549:
URL: https://github.com/apache/spark/pull/34549#issuecomment-966772505


   > @dh20 Thank you for trying to make the doc better. But users can know the proper data type from the error message.
   > 
   > ```
   > java.lang.IllegalArgumentException: Error while instantiating 'org.apache.spark.sql.hive.HiveSessionStateBuilder':
   >   at org.apache.spark.sql.SparkSession$.org$apache$spark$sql$SparkSession$$instantiateSessionState(SparkSession.scala:1151)
   >   at org.apache.spark.sql.SparkSession.$anonfun$sessionState$2(SparkSession.scala:158)
   >   at scala.Option.getOrElse(Option.scala:189)
   >   at org.apache.spark.sql.SparkSession.sessionState$lzycompute(SparkSession.scala:156)
   >   at org.apache.spark.sql.SparkSession.sessionState(SparkSession.scala:153)
   >   at org.apache.spark.sql.SparkSession.conf$lzycompute(SparkSession.scala:181)
   >   at org.apache.spark.sql.SparkSession.conf(SparkSession.scala:181)
   > ```
   > 
   > I think it's enough.
   > 
   > Also, even if we mention the data type of the property, we should mention the data types for all the properties.
   
   @sarutak Thank you for reviewing this pr.  in my opinion, the user setting of this parameter may exceed the maximum value of int type. Can it be changed to long type?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org