You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@thrift.apache.org by "Roger Meier (JIRA)" <ji...@apache.org> on 2011/09/13 00:27:14 UTC

[jira] [Resolved] (THRIFT-1341) TProtocol.h endian detection wrong with boost

     [ https://issues.apache.org/jira/browse/THRIFT-1341?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Roger Meier resolved THRIFT-1341.
---------------------------------

    Resolution: Fixed

Thanks Alexandre!

> TProtocol.h endian detection wrong with boost
> ---------------------------------------------
>
>                 Key: THRIFT-1341
>                 URL: https://issues.apache.org/jira/browse/THRIFT-1341
>             Project: Thrift
>          Issue Type: Bug
>          Components: C++ - Library
>    Affects Versions: 0.7, 0.8
>         Environment: Windows
>            Reporter: alexandre parenteau
>            Priority: Trivial
>              Labels: patch
>             Fix For: 0.8
>
>         Attachments: THRIFT-1341.patch
>
>   Original Estimate: 1h
>  Remaining Estimate: 1h
>
> When compiling on platforms without /usr/include/endian.h (e.g. Windows.h), TProtocol.h uses boost to detect the endianess, but does it wrong: boost's endian.hpp will only #define BOOST_LITTLE_ENDIAN with no value (unlike endian.h)
> Attached is a patch against trunk which fixes the code that uses boost. Tested on Windows, boost 1.44.0.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira