You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "zhaomin1423 (via GitHub)" <gi...@apache.org> on 2023/07/29 02:53:50 UTC
[GitHub] [spark] zhaomin1423 opened a new pull request, #42221: [SPARK-44595][CONNECT] Make the user session cache number and cache time be configurable in spark connect service
zhaomin1423 opened a new pull request, #42221:
URL: https://github.com/apache/spark/pull/42221
<!--
Thanks for sending a pull request! Here are some tips for you:
1. If this is your first time, please read our contributor guidelines: https://spark.apache.org/contributing.html
2. Ensure you have added or run the appropriate tests for your PR: https://spark.apache.org/developer-tools.html
3. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP][SPARK-XXXX] Your PR title ...'.
4. Be sure to keep the PR description updated to reflect all changes.
5. Please write your PR title to summarize what this PR proposes.
6. If possible, provide a concise example to reproduce the issue for a faster review.
7. If you want to add a new configuration, please read the guideline first for naming configurations in
'core/src/main/scala/org/apache/spark/internal/config/ConfigEntry.scala'.
8. If you want to add or modify an error type or message, please read the guideline first in
'core/src/main/resources/error/README.md'.
-->
### What changes were proposed in this pull request?
<!--
Please clarify what changes you are proposing. The purpose of this section is to outline the changes and how this PR fixes the issue.
If possible, please consider writing useful notes for better and faster reviews in your PR. See the examples below.
1. If you refactor some codes with changing classes, showing the class hierarchy will help reviewers.
2. If you fix some SQL features, you can provide some references of other DBMSes.
3. If there is design documentation, please add the link.
4. If there is a discussion in the mailing list, please add the link.
-->
Added configs for user session cache size and cache timeout in connect service.
### Why are the changes needed?
<!--
Please clarify why the changes are needed. For instance,
1. If you propose a new API, clarify the use case for a new API.
2. If you fix a bug, you can clarify why it is a bug.
-->
Now, the cache size of user session is 100, the cache timeout is 3600. Make them modifiable to meet diverse scenarios.
### Does this PR introduce _any_ user-facing change?
<!--
Note that it means *any* user-facing change including all aspects such as the documentation fix.
If yes, please clarify the previous behavior and the change this PR proposes - provide the console output, description and/or an example to show the behavior difference if possible.
If possible, please also clarify if this is a user-facing change compared to the released Spark versions or within the unreleased branches such as master.
If no, write 'No'.
-->
no
### How was this patch tested?
<!--
If tests were added, say they were added here. Please make sure to add some test cases that check the changes thoroughly including negative and positive cases if possible.
If it was tested in a way different from regular unit tests, please clarify how you tested step by step, ideally copy and paste-able, so that other reviewers can test and check, and descendants can verify in the future.
If tests were not added, please describe why they were not added and/or why it was difficult to add.
If benchmark tests were added, please run the benchmarks in GitHub Actions for the consistent environment, and the instructions could accord to: https://spark.apache.org/developer-tools.html#github-workflow-benchmarks.
-->
Existing can test it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] zhaomin1423 commented on pull request #42221: [SPARK-44595][CONNECT] Make the user session cache number and cache time be configurable in spark connect service
Posted by "zhaomin1423 (via GitHub)" <gi...@apache.org>.
zhaomin1423 commented on PR #42221:
URL: https://github.com/apache/spark/pull/42221#issuecomment-1656544043
> We can avoid unnecessary multiline strings.
Thanks, updated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] beliefer commented on a diff in pull request #42221: [SPARK-44595][CONNECT] Make the user session cache number and cache time be configurable in spark connect service
Posted by "beliefer (via GitHub)" <gi...@apache.org>.
beliefer commented on code in PR #42221:
URL: https://github.com/apache/spark/pull/42221#discussion_r1280488655
##########
connector/connect/server/src/main/scala/org/apache/spark/sql/connect/config/Connect.scala:
##########
@@ -121,4 +121,18 @@ object Connect {
.version("3.5.0")
.booleanConf
.createWithDefault(false)
+
+ val CONNECT_USER_SESSION_CACHE_SIZE =
+ ConfigBuilder("spark.connect.userSession.cacheSize")
Review Comment:
So, how about `spark.connect.session.cacheSize` ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] juliuszsompolski commented on a diff in pull request #42221: [SPARK-44595][CONNECT] Make the user session cache number and cache time be configurable in spark connect service
Posted by "juliuszsompolski (via GitHub)" <gi...@apache.org>.
juliuszsompolski commented on code in PR #42221:
URL: https://github.com/apache/spark/pull/42221#discussion_r1280016548
##########
connector/connect/server/src/main/scala/org/apache/spark/sql/connect/config/Connect.scala:
##########
@@ -121,4 +121,18 @@ object Connect {
.version("3.5.0")
.booleanConf
.createWithDefault(false)
+
+ val CONNECT_USER_SESSION_CACHE_SIZE =
+ ConfigBuilder("spark.connect.userSession.cacheSize")
+ .doc("Sets the cache size of user session.")
+ .version("4.0.0")
+ .intConf
+ .createWithDefault(100)
+
+ val CONNECT_USER_SESSION_CACHE_TIMEOUT =
+ ConfigBuilder("spark.connect.userSession.cacheTimeout")
+ .doc("Sets the cache timeout of user session.")
+ .version("4.0.0")
+ .intConf
+ .createWithDefault(3600)
Review Comment:
I am not sure if we want to keep the session cache semantics being like it is now in the long term.
Because of that, I would not codify these configs into documented public configs, that will later restrict us from changing the behaviour of the cache.
For example
- should we have this global limit of how many sessions there are at all? so that a malicious user can flood the server with sessions, and get other people's sessions evicted?
- should the timeout be 3600 seconds? There is currently no way to close session, so a client that goes away just leaves it hanging for an hour. We should have some mechanism for sessions liveness, like e.g. a heartbeat from client that they are still there, and then likely a timeout that is much lower if the client doesn't go away. But since we need to maintain backwards compatibility with old client, we need to leave it working with 1h timeout for old clients...
I am working on designing these matters, and I think we shouldn't put the current behaviour into user facing comment, so that we maintain flexibility of changing it...
Maybe .internal() for now would be fine, because I see the value in just having something to control it for now?
cc @grundprinzip
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-44595][CONNECT] Make the user session cache number and cache time be configurable in spark connect service [spark]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #42221:
URL: https://github.com/apache/spark/pull/42221#issuecomment-1804878102
We're closing this PR because it hasn't been updated in a while. This isn't a judgement on the merit of the PR in any way. It's just a way of keeping the PR queue manageable.
If you'd like to revive this PR, please reopen it and ask a committer to remove the Stale tag!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] zhaomin1423 commented on pull request #42221: [SPARK-44595][CONNECT] Make the user session cache number and cache time be configurable in spark connect service
Posted by "zhaomin1423 (via GitHub)" <gi...@apache.org>.
zhaomin1423 commented on PR #42221:
URL: https://github.com/apache/spark/pull/42221#issuecomment-1659937105
Could you help me review it? @LuciferYang
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] zhaomin1423 commented on a diff in pull request #42221: [SPARK-44595][CONNECT] Make the user session cache number and cache time be configurable in spark connect service
Posted by "zhaomin1423 (via GitHub)" <gi...@apache.org>.
zhaomin1423 commented on code in PR #42221:
URL: https://github.com/apache/spark/pull/42221#discussion_r1280288855
##########
connector/connect/server/src/main/scala/org/apache/spark/sql/connect/config/Connect.scala:
##########
@@ -121,4 +121,18 @@ object Connect {
.version("3.5.0")
.booleanConf
.createWithDefault(false)
+
+ val CONNECT_USER_SESSION_CACHE_SIZE =
+ ConfigBuilder("spark.connect.userSession.cacheSize")
Review Comment:
It is common
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] zhaomin1423 commented on a diff in pull request #42221: [SPARK-44595][CONNECT] Make the user session cache number and cache time be configurable in spark connect service
Posted by "zhaomin1423 (via GitHub)" <gi...@apache.org>.
zhaomin1423 commented on code in PR #42221:
URL: https://github.com/apache/spark/pull/42221#discussion_r1280832560
##########
connector/connect/server/src/main/scala/org/apache/spark/sql/connect/config/Connect.scala:
##########
@@ -121,4 +121,18 @@ object Connect {
.version("3.5.0")
.booleanConf
.createWithDefault(false)
+
+ val CONNECT_USER_SESSION_CACHE_SIZE =
+ ConfigBuilder("spark.connect.userSession.cacheSize")
+ .doc("Sets the cache size of user session.")
+ .version("4.0.0")
+ .intConf
+ .createWithDefault(100)
+
+ val CONNECT_USER_SESSION_CACHE_TIMEOUT =
+ ConfigBuilder("spark.connect.userSession.cacheTimeout")
+ .doc("Sets the cache timeout of user session.")
+ .version("4.0.0")
+ .intConf
+ .createWithDefault(3600)
Review Comment:
Thanks for your input, look forward to your work.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] zhaomin1423 commented on a diff in pull request #42221: [SPARK-44595][CONNECT] Make the user session cache number and cache time be configurable in spark connect service
Posted by "zhaomin1423 (via GitHub)" <gi...@apache.org>.
zhaomin1423 commented on code in PR #42221:
URL: https://github.com/apache/spark/pull/42221#discussion_r1280547646
##########
connector/connect/server/src/main/scala/org/apache/spark/sql/connect/config/Connect.scala:
##########
@@ -121,4 +121,18 @@ object Connect {
.version("3.5.0")
.booleanConf
.createWithDefault(false)
+
+ val CONNECT_USER_SESSION_CACHE_SIZE =
+ ConfigBuilder("spark.connect.userSession.cacheSize")
Review Comment:
It is ok, thanks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-44595][CONNECT] Make the user session cache number and cache time be configurable in spark connect service [spark]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] closed pull request #42221: [SPARK-44595][CONNECT] Make the user session cache number and cache time be configurable in spark connect service
URL: https://github.com/apache/spark/pull/42221
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] beliefer commented on a diff in pull request #42221: [SPARK-44595][CONNECT] Make the user session cache number and cache time be configurable in spark connect service
Posted by "beliefer (via GitHub)" <gi...@apache.org>.
beliefer commented on code in PR #42221:
URL: https://github.com/apache/spark/pull/42221#discussion_r1280208696
##########
connector/connect/server/src/main/scala/org/apache/spark/sql/connect/config/Connect.scala:
##########
@@ -121,4 +121,18 @@ object Connect {
.version("3.5.0")
.booleanConf
.createWithDefault(false)
+
+ val CONNECT_USER_SESSION_CACHE_SIZE =
+ ConfigBuilder("spark.connect.userSession.cacheSize")
Review Comment:
The Spark Sessions are shared common or for user?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] Hisoka-X commented on a diff in pull request #42221: [SPARK-44595][CONNECT] Make the user session cache number and cache time be configurable in spark connect service
Posted by "Hisoka-X (via GitHub)" <gi...@apache.org>.
Hisoka-X commented on code in PR #42221:
URL: https://github.com/apache/spark/pull/42221#discussion_r1278228410
##########
connector/connect/server/src/main/scala/org/apache/spark/sql/connect/config/Connect.scala:
##########
@@ -121,4 +121,22 @@ object Connect {
.version("3.5.0")
.booleanConf
.createWithDefault(false)
+
+ val CONNECT_USER_SESSION_CACHE_SIZE =
+ ConfigBuilder("spark.connect.userSession.cacheSize")
+ .doc("""
+ |Sets the cache size of user session.
+ |""".stripMargin)
Review Comment:
```suggestion
.doc("Sets the cache size of user session.")
```
##########
connector/connect/server/src/main/scala/org/apache/spark/sql/connect/config/Connect.scala:
##########
@@ -121,4 +121,22 @@ object Connect {
.version("3.5.0")
.booleanConf
.createWithDefault(false)
+
+ val CONNECT_USER_SESSION_CACHE_SIZE =
+ ConfigBuilder("spark.connect.userSession.cacheSize")
+ .doc("""
+ |Sets the cache size of user session.
+ |""".stripMargin)
+ .version("4.0.0")
+ .intConf
+ .createWithDefault(100)
+
+ val CONNECT_USER_SESSION_CACHE_TIMEOUT =
+ ConfigBuilder("spark.connect.userSession.cacheTimeout")
+ .doc("""
+ |Sets the cache timeout of user session.
+ |""".stripMargin)
Review Comment:
```suggestion
.doc("Sets the cache timeout of user session.")
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org