[GitHub] [superset] kgabryje commented on a change in pull request #14046: fix: Make chart emitting cross-filter exclude itself from filtering

[GitBox <gi...@apache.org>]

kgabryje commented on a change in pull request #14046:
URL: https://github.com/apache/superset/pull/14046#discussion_r610652696



##########
File path: superset-frontend/src/dashboard/util/activeAllDashboardFilters.ts
##########
@@ -92,7 +92,7 @@ export const getAllActiveFilters = ({
     const scope = nativeFilters?.[filterId]?.scope ??
       chartConfiguration?.[filterId]?.crossFilters?.scope ?? {
         rootPath: [DASHBOARD_ROOT_ID],
-        excluded: [],
+        excluded: [filterId],

Review comment:
       I haven't encountered such case. It's either an empty object or an array with a chart ID.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org