You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@bookkeeper.apache.org by "hangc0276 (via GitHub)" <gi...@apache.org> on 2023/03/27 14:03:00 UTC

[GitHub] [bookkeeper] hangc0276 opened a new pull request, #3890: Fix BookieWriteLedgerTest parameterized failed

hangc0276 opened a new pull request, #3890:
URL: https://github.com/apache/bookkeeper/pull/3890

   
   ### Motivation
   https://github.com/apache/bookkeeper/pull/3884 introduced a parameterized test for BookieWriteLedgerTest, but those parameters don't work due to they are set in the constructor method, which doesn't run for each test. We need to set them in the `setUp()` method to ensure they are configured for each test.
   
   ### Changes
   Move the parameters from the constructor method to the `setUp()` method to make sure they are configured for each test.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@bookkeeper.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [bookkeeper] merlimat merged pull request #3890: Fix BookieWriteLedgerTest parameterized failed

Posted by "merlimat (via GitHub)" <gi...@apache.org>.
merlimat merged PR #3890:
URL: https://github.com/apache/bookkeeper/pull/3890


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@bookkeeper.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org