You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@iggy.apache.org by "justinmclean (via GitHub)" <gi...@apache.org> on 2026/09/21 02:50:46 UTC
[PR] fix(server): skip NUMA memory binding on a single-node host [iggy]
justinmclean opened a new pull request, #4243:
URL: https://github.com/apache/iggy/pull/4243
## Which issue does this PR address?
Closes #4242
## Rationale
The documented Docker quickstart does not start 0.9.0 on Docker Desktop or other single-NUMA-node hosts.
## What changed?
With one NUMA node, every shard bound its memory to that node. The bind gains nothing there, and Docker Desktop's VM rejects it, so the server exited at startup with failed to bind shard N memory to its NUMA node.
Shards are no longer memory-bound when the topology has a single node. Multi-node hosts are unchanged. NumaTopology::detect() is split so tests can pass synthetic one-node and two-node topologies.
## Local Execution
- Passed: cargo test -p server --lib (460 of 460), cargo fmt --check, cargo clippy --all-features. The new single-node test fails without the fix.
- Pre-commit hooks ran (prek).
- Not run: an end-to-end check against a rebuilt Docker image. The workaround in #4242 was verified in Docker on 0.9.0.
## AI Usage
1. Claude (Claude Code).
2. Diagnosed the startup failure and wrote the fix, the from_topology split, and the two tests.
3. Ran the server lib tests, fmt, and clippy, and confirmed the single-node test fails when the fix is reverted.
4. Reviewed and refined by a human.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@iggy.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(server): skip NUMA memory binding on a single-node host [iggy]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #4243:
URL: https://github.com/apache/iggy/pull/4243#issuecomment-5754756340
<!-- iggy-pr-triage-welcome -->
Thanks for the PR. It is labeled `S-waiting-on-review` and queued for review.
Slash commands (own line, regular comment) move it around the queue:
- `/ready` - back to `S-waiting-on-review` after addressing feedback
- `/author` - flip to `S-waiting-on-author` while you finish changes
- `/request-review @user-or-team` - request a reviewer
- `/pin` - exempt the PR from the stale bot, `/unpin` to undo
See [CONTRIBUTING.md](https://github.com/apache/iggy/blob/master/CONTRIBUTING.md#pr-triage-commands) for details.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@iggy.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(server): skip NUMA memory binding on a single-node host [iggy]
Posted by "justinmclean (via GitHub)" <gi...@apache.org>.
justinmclean commented on PR #4243:
URL: https://github.com/apache/iggy/pull/4243#issuecomment-5756015620
Note shard_allocator.rs coverage jumped from 36% to 65% (+28.93 points) thanks to the new tests.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@iggy.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(server): skip NUMA memory binding on a single-node host [iggy]
Posted by "hubcio (via GitHub)" <gi...@apache.org>.
hubcio merged PR #4243:
URL: https://github.com/apache/iggy/pull/4243
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@iggy.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(server): skip NUMA memory binding on a single-node host [iggy]
Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #4243:
URL: https://github.com/apache/iggy/pull/4243#issuecomment-5754768759
## [Codecov](https://app.codecov.io/gh/apache/iggy/pull/4243?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:white_check_mark: All modified and coverable lines are covered by tests.
:white_check_mark: Project coverage is 87.15%. Comparing base ([`ad8951f`](https://app.codecov.io/gh/apache/iggy/commit/ad8951f57fd1ba3641425a67f8ee61b85e91678b?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`fba3397`](https://app.codecov.io/gh/apache/iggy/commit/fba339784269ae93ecb24837ef1ecedab869edaf?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #4243 +/- ##
============================================
- Coverage 87.47% 87.15% -0.33%
Complexity 1575 1575
============================================
Files 1280 1278 -2
Lines 223241 222992 -249
Branches 186604 186564 -40
============================================
- Hits 195290 194342 -948
- Misses 23241 23933 +692
- Partials 4710 4717 +7
```
| [Components](https://app.codecov.io/gh/apache/iggy/pull/4243/components?src=pr&el=components&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [Rust Core](https://app.codecov.io/gh/apache/iggy/pull/4243/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `88.55% <ø> (+<0.01%)` | :arrow_up: |
| [Java SDK](https://app.codecov.io/gh/apache/iggy/pull/4243/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `68.68% <ø> (ø)` | |
| [C# SDK](https://app.codecov.io/gh/apache/iggy/pull/4243/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `77.46% <ø> (ø)` | |
| [Python SDK](https://app.codecov.io/gh/apache/iggy/pull/4243/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `90.97% <ø> (ø)` | |
| [PHP SDK](https://app.codecov.io/gh/apache/iggy/pull/4243/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `85.67% <ø> (ø)` | |
| [Node SDK](https://app.codecov.io/gh/apache/iggy/pull/4243/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `90.78% <ø> (-5.66%)` | :arrow_down: |
| [Go SDK](https://app.codecov.io/gh/apache/iggy/pull/4243/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `70.12% <ø> (ø)` | |
| [Files with missing lines](https://app.codecov.io/gh/apache/iggy/pull/4243?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [core/server/src/shard\_allocator.rs](https://app.codecov.io/gh/apache/iggy/pull/4243?src=pr&el=tree&filepath=core%2Fserver%2Fsrc%2Fshard_allocator.rs&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Y29yZS9zZXJ2ZXIvc3JjL3NoYXJkX2FsbG9jYXRvci5ycw==) | `36.56% <ø> (+0.11%)` | :arrow_up: |
... and [53 files with indirect coverage changes](https://app.codecov.io/gh/apache/iggy/pull/4243/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
- :package: [JS Bundle Analysis](https://docs.codecov.com/docs/javascript-bundle-analysis): Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@iggy.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org