You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@spark.apache.org by maropu <gi...@git.apache.org> on 2018/04/20 06:41:44 UTC

[GitHub] spark pull request #21112: [SPARK-23588][SQL][FOLLOW-UP] Resolve a map build...

GitHub user maropu opened a pull request:

    https://github.com/apache/spark/pull/21112

    [SPARK-23588][SQL][FOLLOW-UP]  Resolve a map builder method per execution in CatalystToExternalMap

    ## What changes were proposed in this pull request?
    This pr is a follow-up pr of #20979 and fixes code to resolve a map builder method per execution instead of per row in `CatalystToExternalMap`.
    
    ## How was this patch tested?
    Existing tests.


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/maropu/spark SPARK-23588-FOLLOWUP

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/spark/pull/21112.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #21112
    
----
commit 1474cd91d58ce5fd8d543c103277de97cd53cc05
Author: Takeshi Yamamuro <ya...@...>
Date:   2018-04-20T06:35:46Z

    Fix

----


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #21112: [SPARK-23588][SQL][FOLLOW-UP] Resolve a map builder meth...

Posted by SparkQA <gi...@git.apache.org>.

Github user SparkQA commented on the issue:

    https://github.com/apache/spark/pull/21112
  
    **[Test build #89618 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/89618/testReport)** for PR 21112 at commit [`1474cd9`](https://github.com/apache/spark/commit/1474cd91d58ce5fd8d543c103277de97cd53cc05).
     * This patch passes all tests.
     * This patch merges cleanly.
     * This patch adds no public classes.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #21112: [SPARK-23588][SQL][FOLLOW-UP] Resolve a map builder meth...

Posted by SparkQA <gi...@git.apache.org>.

Github user SparkQA commented on the issue:

    https://github.com/apache/spark/pull/21112
  
    **[Test build #89609 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/89609/testReport)** for PR 21112 at commit [`1474cd9`](https://github.com/apache/spark/commit/1474cd91d58ce5fd8d543c103277de97cd53cc05).
     * This patch **fails due to an unknown error code, -9**.
     * This patch merges cleanly.
     * This patch adds no public classes.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #21112: [SPARK-23588][SQL][FOLLOW-UP] Resolve a map builder meth...

Posted by AmplabJenkins <gi...@git.apache.org>.

Github user AmplabJenkins commented on the issue:

    https://github.com/apache/spark/pull/21112
  
    Test PASSed.
    Refer to this link for build results (access rights to CI server needed): 
    https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/89618/
    Test PASSed.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #21112: [SPARK-23588][SQL][FOLLOW-UP] Resolve a map builder meth...

Posted by hvanhovell <gi...@git.apache.org>.

Github user hvanhovell commented on the issue:

    https://github.com/apache/spark/pull/21112
  
    Merging to master. Thanks!


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #21112: [SPARK-23588][SQL][FOLLOW-UP] Resolve a map builder meth...

Posted by maropu <gi...@git.apache.org>.

Github user maropu commented on the issue:

    https://github.com/apache/spark/pull/21112
  
    @hvanhovell 


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #21112: [SPARK-23588][SQL][FOLLOW-UP] Resolve a map builder meth...

Posted by AmplabJenkins <gi...@git.apache.org>.

Github user AmplabJenkins commented on the issue:

    https://github.com/apache/spark/pull/21112
  
    Test PASSed.
    Refer to this link for build results (access rights to CI server needed): 
    https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/2518/
    Test PASSed.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #21112: [SPARK-23588][SQL][FOLLOW-UP] Resolve a map builder meth...

Posted by AmplabJenkins <gi...@git.apache.org>.

Github user AmplabJenkins commented on the issue:

    https://github.com/apache/spark/pull/21112
  
    Test FAILed.
    Refer to this link for build results (access rights to CI server needed): 
    https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/89609/
    Test FAILed.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org