You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@maven.apache.org by rf...@apache.org on 2016/10/31 20:05:48 UTC
maven git commit: [MNG-6109] PluginDescriptor doesn't read since
value of parameter
Repository: maven
Updated Branches:
refs/heads/master e07978bdc -> a277f6f43
[MNG-6109] PluginDescriptor doesn't read since value of parameter
Project: http://git-wip-us.apache.org/repos/asf/maven/repo
Commit: http://git-wip-us.apache.org/repos/asf/maven/commit/a277f6f4
Tree: http://git-wip-us.apache.org/repos/asf/maven/tree/a277f6f4
Diff: http://git-wip-us.apache.org/repos/asf/maven/diff/a277f6f4
Branch: refs/heads/master
Commit: a277f6f43a9b52c17b6aa2af069554edd2b0e42e
Parents: e07978b
Author: rfscholte <rf...@apache.org>
Authored: Mon Oct 31 21:05:28 2016 +0100
Committer: rfscholte <rf...@apache.org>
Committed: Mon Oct 31 21:05:28 2016 +0100
----------------------------------------------------------------------
.../apache/maven/plugin/descriptor/PluginDescriptorBuilder.java | 2 ++
.../maven/plugin/descriptor/PluginDescriptorBuilderTest.java | 1 +
maven-plugin-api/src/test/resources/plugin.xml | 1 +
3 files changed, 4 insertions(+)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/maven/blob/a277f6f4/maven-plugin-api/src/main/java/org/apache/maven/plugin/descriptor/PluginDescriptorBuilder.java
----------------------------------------------------------------------
diff --git a/maven-plugin-api/src/main/java/org/apache/maven/plugin/descriptor/PluginDescriptorBuilder.java b/maven-plugin-api/src/main/java/org/apache/maven/plugin/descriptor/PluginDescriptorBuilder.java
index 7224554..9508c51 100644
--- a/maven-plugin-api/src/main/java/org/apache/maven/plugin/descriptor/PluginDescriptorBuilder.java
+++ b/maven-plugin-api/src/main/java/org/apache/maven/plugin/descriptor/PluginDescriptorBuilder.java
@@ -299,6 +299,8 @@ public class PluginDescriptorBuilder
parameter.setImplementation( d.getChild( "implementation" ).getValue() );
+ parameter.setSince( d.getChild( "since" ).getValue() );
+
PlexusConfiguration paramConfig = mojoConfig.getChild( parameter.getName(), false );
if ( paramConfig != null )
{
http://git-wip-us.apache.org/repos/asf/maven/blob/a277f6f4/maven-plugin-api/src/test/java/org/apache/maven/plugin/descriptor/PluginDescriptorBuilderTest.java
----------------------------------------------------------------------
diff --git a/maven-plugin-api/src/test/java/org/apache/maven/plugin/descriptor/PluginDescriptorBuilderTest.java b/maven-plugin-api/src/test/java/org/apache/maven/plugin/descriptor/PluginDescriptorBuilderTest.java
index 799e3af..b9f5ab9 100644
--- a/maven-plugin-api/src/test/java/org/apache/maven/plugin/descriptor/PluginDescriptorBuilderTest.java
+++ b/maven-plugin-api/src/test/java/org/apache/maven/plugin/descriptor/PluginDescriptorBuilderTest.java
@@ -108,6 +108,7 @@ public class PluginDescriptorBuilderTest
assertEquals( "deprecated-parameter", mp.getDeprecated() );
assertEquals( "${jar.finalName}", mp.getExpression() );
assertEquals( "${project.build.finalName}", mp.getDefaultValue() );
+ assertEquals( "3.0.0", mp.getSince() );
ComponentRequirement cr = md.getRequirements().get( 0 );
http://git-wip-us.apache.org/repos/asf/maven/blob/a277f6f4/maven-plugin-api/src/test/resources/plugin.xml
----------------------------------------------------------------------
diff --git a/maven-plugin-api/src/test/resources/plugin.xml b/maven-plugin-api/src/test/resources/plugin.xml
index 6b97211..add46dc 100644
--- a/maven-plugin-api/src/test/resources/plugin.xml
+++ b/maven-plugin-api/src/test/resources/plugin.xml
@@ -60,6 +60,7 @@ under the License.
<editable>true</editable>
<description>parameter-description</description>
<deprecated>deprecated-parameter</deprecated>
+ <since>3.0.0</since>
</parameter>
</parameters>
<configuration>