[GitHub] [superset] junlincc edited a comment on pull request #13606: feat: add warning metadata to tables and metrics

[GitBox <gi...@apache.org>]

junlincc edited a comment on pull request #13606:
URL: https://github.com/apache/superset/pull/13606#issuecomment-800708811


   @ktmud 
   
   - Move "extra" to "Advanced" 
   Definitely! 
   - Make the AceEditor for extra taller and resizable 
   Make sense 
   -Move the two column layout to be two rows with Basic options on top and Advanced in the bottom.
   -Add two column layout within the Basic and Advanced container
   Good idea! We probably need more exploration than simply changing the layout. 
   
   @etr2460 Thank you, Erik, for opening this PR and adjusting the UI element for consistency. Really appreciate it! 
   Term _Data entity_ is not being used anywhere,  should we change it? 
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org