You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2022/05/11 20:59:52 UTC
[GitHub] [airflow] pingzh opened a new pull request, #23655: Ensure execution_timeout as timedelta
pingzh opened a new pull request, #23655:
URL: https://github.com/apache/airflow/pull/23655
so that it can be correctly serialized and deserialized
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in a newsfragement file, named `{pr_number}.significant.rst`, in [newsfragments](https://github.com/apache/airflow/tree/main/newsfragments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] pingzh commented on pull request #23655: Ensure execution_timeout as timedelta
Posted by GitBox <gi...@apache.org>.
pingzh commented on PR #23655:
URL: https://github.com/apache/airflow/pull/23655#issuecomment-1126622597
@kaxil do you think we can merge this PR? i have been force pushed several times.but CI somehow is stuck and got `cancelled checks` for all of them. and i believe it should not be related to this PR.
thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] kaxil commented on a diff in pull request #23655: Ensure execution_timeout as timedelta
Posted by GitBox <gi...@apache.org>.
kaxil commented on code in PR #23655:
URL: https://github.com/apache/airflow/pull/23655#discussion_r872224701
##########
airflow/models/baseoperator.py:
##########
@@ -767,7 +767,13 @@ def __init__(
self.email = email
self.email_on_retry = email_on_retry
self.email_on_failure = email_on_failure
+
+ if execution_timeout is not None and not isinstance(execution_timeout, timedelta):
Review Comment:
Even if you have plan to allow None, the following should work:
```
if execution_timeout and not isinstance(execution_timeout, timedelta):
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] kaxil commented on pull request #23655: Ensure execution_timeout as timedelta
Posted by GitBox <gi...@apache.org>.
kaxil commented on PR #23655:
URL: https://github.com/apache/airflow/pull/23655#issuecomment-1128067063
🎉
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] kaxil commented on a diff in pull request #23655: Ensure execution_timeout as timedelta
Posted by GitBox <gi...@apache.org>.
kaxil commented on code in PR #23655:
URL: https://github.com/apache/airflow/pull/23655#discussion_r872224228
##########
airflow/models/baseoperator.py:
##########
@@ -767,7 +767,13 @@ def __init__(
self.email = email
self.email_on_retry = email_on_retry
self.email_on_failure = email_on_failure
+
+ if execution_timeout is not None and not isinstance(execution_timeout, timedelta):
Review Comment:
```suggestion
if not isinstance(execution_timeout, timedelta):
```
should be enough as we already have the default set in ctor:
https://github.com/apache/airflow/blob/d4d29718fdc46cd49e8b5be2e54fb313d595f06e/airflow/models/baseoperator.py#L205
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] uranusjr commented on a diff in pull request #23655: Ensure execution_timeout as timedelta
Posted by GitBox <gi...@apache.org>.
uranusjr commented on code in PR #23655:
URL: https://github.com/apache/airflow/pull/23655#discussion_r873049437
##########
airflow/models/baseoperator.py:
##########
@@ -767,7 +767,13 @@ def __init__(
self.email = email
self.email_on_retry = email_on_retry
self.email_on_failure = email_on_failure
+
+ if execution_timeout and not isinstance(execution_timeout, timedelta):
Review Comment:
```suggestion
if execution_timeout is not None and not isinstance(execution_timeout, timedelta):
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] KevinYang21 merged pull request #23655: Ensure execution_timeout as timedelta
Posted by GitBox <gi...@apache.org>.
KevinYang21 merged PR #23655:
URL: https://github.com/apache/airflow/pull/23655
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #23655: Ensure execution_timeout as timedelta
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #23655:
URL: https://github.com/apache/airflow/pull/23655#issuecomment-1126318878
The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and take the risk. If they don't merge it quickly - please rebase it to the latest main at your convenience, or amend the last commit of the PR, and push it with --force-with-lease.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] pingzh commented on a diff in pull request #23655: Ensure execution_timeout as timedelta
Posted by GitBox <gi...@apache.org>.
pingzh commented on code in PR #23655:
URL: https://github.com/apache/airflow/pull/23655#discussion_r872600582
##########
airflow/models/baseoperator.py:
##########
@@ -767,7 +767,13 @@ def __init__(
self.email = email
self.email_on_retry = email_on_retry
self.email_on_failure = email_on_failure
+
+ if execution_timeout is not None and not isinstance(execution_timeout, timedelta):
Review Comment:
nice, updated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org