You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@qpid.apache.org by GitBox <gi...@apache.org> on 2020/01/22 20:58:26 UTC

[GitHub] [qpid-dispatch] bhardesty opened a new pull request #672: DISPATCH-1555: Update doc for new console ui

bhardesty opened a new pull request #672: DISPATCH-1555: Update doc for new console ui
URL: https://github.com/apache/qpid-dispatch/pull/672
 
 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org

[GitHub] [qpid-dispatch] jbyrne-redhat commented on a change in pull request #672: DISPATCH-1555: Update doc for new console ui

Posted by GitBox <gi...@apache.org>.

jbyrne-redhat commented on a change in pull request #672: DISPATCH-1555: Update doc for new console ui
URL: https://github.com/apache/qpid-dispatch/pull/672#discussion_r370084108

##########
File path: docs/books/modules/user-guide/monitoring-router-network-web-console.adoc
##########
@@ -24,22 +24,31 @@ under the License
[id='monitoring-router-network-web-console'-{context}']
= Monitoring the router network using {ConsoleName}

-In the web console, you use the tabs to monitor the router network.
+The web console provides several sections you can use to monitor the router network.

-| `Overview` | Aggregated information about routers, addresses, links, connections, and logs.
+| Overview
+a|
+Aggregated information about the router network. This includes the following:

-| `Entities` | Detailed information about each AMQP management entity for each router in the router network. Some of the attributes have charts that you can add to the `Charts` tab.
+* Dashboard (shows router network statistics)
+* Routers
+* Addresses
+* Links
+* Connections
+* Logs

-| `Topology` | A graphical view of the router network, including routers, clients, and brokers. The topology shows how the routers are connected, and how messages are flowing through the network.
+| Visualizations
+a|
+A graphical view of the router network. You can view the following types of visualizations:

-| `Charts` | Graphs of the information selected on the `Entities` tab.
+`Topology`:: Shows the topology of the router network, including routers, clients, and brokers. It also shows how messages are flowing through the network.
+`Message flow`:: A chord diagram showing the real-time message flow by address.

-| `Message Flow` | A chord diagram showing the real-time message flow by address.
-
-| `Schema` | The management schema that controls each of the routers in the router network.
+| Details
+| Detailed configuration information about each AMQP management entity for each router in the router network. You can view and change the configuration of any of the routers in the network.

Review comment:
Insert a pause:

Detailed configuration information about each AMQP management entity, for each router in the router network.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org

[GitHub] [qpid-dispatch] fgiorgetti commented on issue #672: DISPATCH-1555: Update doc for new console ui

Posted by GitBox <gi...@apache.org>.

fgiorgetti commented on issue #672: DISPATCH-1555: Update doc for new console ui
URL: https://github.com/apache/qpid-dispatch/pull/672#issuecomment-579548486
 
 
   @bhardesty changes look good to me. Thanks!

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org

[GitHub] [qpid-dispatch] jbyrne-redhat commented on a change in pull request #672: DISPATCH-1555: Update doc for new console ui

Posted by GitBox <gi...@apache.org>.

jbyrne-redhat commented on a change in pull request #672: DISPATCH-1555: Update doc for new console ui
URL: https://github.com/apache/qpid-dispatch/pull/672#discussion_r370083662
 
 

 ##########
 File path: docs/books/modules/user-guide/monitoring-router-network-web-console.adoc
 ##########
 @@ -24,22 +24,31 @@ under the License
 [id='monitoring-router-network-web-console'-{context}']
 = Monitoring the router network using {ConsoleName}
 
-In the web console, you use the tabs to monitor the router network.
+The web console provides several sections you can use to monitor the router network.
 
-[cols="30,70"]
+[cols="25,75"]
 |===
-| This tab... | Provides...
+| This section... | Provides...
 
-| `Overview` | Aggregated information about routers, addresses, links, connections, and logs.
+| Overview
+a|
+Aggregated information about the router network. This includes the following:
 
-| `Entities` | Detailed information about each AMQP management entity for each router in the router network. Some of the attributes have charts that you can add to the `Charts` tab.
+* Dashboard (shows router network statistics)
+* Routers
+* Addresses
+* Links
+* Connections
+* Logs
 
-| `Topology` | A graphical view of the router network, including routers, clients, and brokers. The topology shows how the routers are connected, and how messages are flowing through the network.
+| Visualizations
+a|
+A graphical view of the router network. You can view the following types of visualizations:
 
-| `Charts` | Graphs of the information selected on the `Entities` tab.
+`Topology`:: Shows the topology of the router network, including routers, clients, and brokers. It also shows how messages are flowing through the network.
+`Message flow`:: A chord diagram showing the real-time message flow by address.
 
 Review comment:
   Chord diagram showing...

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org

[GitHub] [qpid-dispatch] jbyrne-redhat commented on a change in pull request #672: DISPATCH-1555: Update doc for new console ui

Posted by GitBox <gi...@apache.org>.

jbyrne-redhat commented on a change in pull request #672: DISPATCH-1555: Update doc for new console ui
URL: https://github.com/apache/qpid-dispatch/pull/672#discussion_r370080737
 
 

 ##########
 File path: docs/books/modules/user-guide/monitoring-router-network-web-console.adoc
 ##########
 @@ -24,22 +24,31 @@ under the License
 [id='monitoring-router-network-web-console'-{context}']
 = Monitoring the router network using {ConsoleName}
 
-In the web console, you use the tabs to monitor the router network.
+The web console provides several sections you can use to monitor the router network.
 
 Review comment:
   ...several sections that you can use...

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org

[GitHub] [qpid-dispatch] jbyrne-redhat commented on a change in pull request #672: DISPATCH-1555: Update doc for new console ui

Posted by GitBox <gi...@apache.org>.

jbyrne-redhat commented on a change in pull request #672: DISPATCH-1555: Update doc for new console ui
URL: https://github.com/apache/qpid-dispatch/pull/672#discussion_r370083200
 
 

 ##########
 File path: docs/books/modules/user-guide/monitoring-router-network-web-console.adoc
 ##########
 @@ -24,22 +24,31 @@ under the License
 [id='monitoring-router-network-web-console'-{context}']
 = Monitoring the router network using {ConsoleName}
 
-In the web console, you use the tabs to monitor the router network.
+The web console provides several sections you can use to monitor the router network.
 
-[cols="30,70"]
+[cols="25,75"]
 |===
-| This tab... | Provides...
+| This section... | Provides...
 
-| `Overview` | Aggregated information about routers, addresses, links, connections, and logs.
+| Overview
+a|
+Aggregated information about the router network. This includes the following:
 
-| `Entities` | Detailed information about each AMQP management entity for each router in the router network. Some of the attributes have charts that you can add to the `Charts` tab.
+* Dashboard (shows router network statistics)
+* Routers
+* Addresses
+* Links
+* Connections
+* Logs
 
-| `Topology` | A graphical view of the router network, including routers, clients, and brokers. The topology shows how the routers are connected, and how messages are flowing through the network.
+| Visualizations
+a|
+A graphical view of the router network. You can view the following types of visualizations:
 
 Review comment:
   Graphical views of the router network. You can see the following types of visualizations:

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org

[GitHub] [qpid-dispatch] jbyrne-redhat commented on a change in pull request #672: DISPATCH-1555: Update doc for new console ui

Posted by GitBox <gi...@apache.org>.

jbyrne-redhat commented on a change in pull request #672: DISPATCH-1555: Update doc for new console ui
URL: https://github.com/apache/qpid-dispatch/pull/672#discussion_r370081663
 
 

 ##########
 File path: docs/books/modules/user-guide/monitoring-router-network-web-console.adoc
 ##########
 @@ -24,22 +24,31 @@ under the License
 [id='monitoring-router-network-web-console'-{context}']
 = Monitoring the router network using {ConsoleName}
 
-In the web console, you use the tabs to monitor the router network.
+The web console provides several sections you can use to monitor the router network.
 
-[cols="30,70"]
+[cols="25,75"]
 |===
-| This tab... | Provides...
+| This section... | Provides...
 
-| `Overview` | Aggregated information about routers, addresses, links, connections, and logs.
+| Overview
+a|
+Aggregated information about the router network. This includes the following:
 
-| `Entities` | Detailed information about each AMQP management entity for each router in the router network. Some of the attributes have charts that you can add to the `Charts` tab.
+* Dashboard (shows router network statistics)
+* Routers
+* Addresses
+* Links
+* Connections
+* Logs
 
-| `Topology` | A graphical view of the router network, including routers, clients, and brokers. The topology shows how the routers are connected, and how messages are flowing through the network.
+| Visualizations
+a|
+A graphical view of the router network. You can view the following types of visualizations:
 
-| `Charts` | Graphs of the information selected on the `Entities` tab.
+`Topology`:: Shows the topology of the router network, including routers, clients, and brokers. It also shows how messages are flowing through the network.
 
 Review comment:
   Topology of the router network, including routers, clients, and brokers. This visualization also shows...

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org

[GitHub] [qpid-dispatch] jbyrne-redhat commented on a change in pull request #672: DISPATCH-1555: Update doc for new console ui

Posted by GitBox <gi...@apache.org>.

jbyrne-redhat commented on a change in pull request #672: DISPATCH-1555: Update doc for new console ui
URL: https://github.com/apache/qpid-dispatch/pull/672#discussion_r370086145
 
 

 ##########
 File path: docs/books/modules/user-guide/monitoring-router-network-web-console.adoc
 ##########
 @@ -24,22 +24,31 @@ under the License
 [id='monitoring-router-network-web-console'-{context}']
 = Monitoring the router network using {ConsoleName}
 
-In the web console, you use the tabs to monitor the router network.
+The web console provides several sections you can use to monitor the router network.
 
-[cols="30,70"]
+[cols="25,75"]
 |===
-| This tab... | Provides...
+| This section... | Provides...
 
-| `Overview` | Aggregated information about routers, addresses, links, connections, and logs.
+| Overview
+a|
+Aggregated information about the router network. This includes the following:
 
-| `Entities` | Detailed information about each AMQP management entity for each router in the router network. Some of the attributes have charts that you can add to the `Charts` tab.
+* Dashboard (shows router network statistics)
+* Routers
+* Addresses
+* Links
+* Connections
+* Logs
 
-| `Topology` | A graphical view of the router network, including routers, clients, and brokers. The topology shows how the routers are connected, and how messages are flowing through the network.
+| Visualizations
+a|
 
 Review comment:
   The three minor suggestions that follow are aimed at making all of the descriptions in this table parallel, that is, eliminate the verbs and articles that begin some descriptions.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org

[GitHub] [qpid-dispatch] jbyrne-redhat commented on a change in pull request #672: DISPATCH-1555: Update doc for new console ui

Posted by GitBox <gi...@apache.org>.

jbyrne-redhat commented on a change in pull request #672: DISPATCH-1555: Update doc for new console ui
URL: https://github.com/apache/qpid-dispatch/pull/672#discussion_r370080899
 
 

 ##########
 File path: docs/books/modules/user-guide/monitoring-router-network-web-console.adoc
 ##########
 @@ -24,22 +24,31 @@ under the License
 [id='monitoring-router-network-web-console'-{context}']
 = Monitoring the router network using {ConsoleName}
 
-In the web console, you use the tabs to monitor the router network.
+The web console provides several sections you can use to monitor the router network.
 
-[cols="30,70"]
+[cols="25,75"]
 |===
-| This tab... | Provides...
+| This section... | Provides...
 
-| `Overview` | Aggregated information about routers, addresses, links, connections, and logs.
+| Overview
+a|
+Aggregated information about the router network. This includes the following:
 
 Review comment:
   This information includes...

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org

[GitHub] [qpid-dispatch] jbyrne-redhat commented on a change in pull request #672: DISPATCH-1555: Update doc for new console ui

Posted by GitBox <gi...@apache.org>.

jbyrne-redhat commented on a change in pull request #672: DISPATCH-1555: Update doc for new console ui
URL: https://github.com/apache/qpid-dispatch/pull/672#discussion_r370084108

-In the web console, you use the tabs to monitor the router network.
+The web console provides several sections you can use to monitor the router network.

-| `Overview` | Aggregated information about routers, addresses, links, connections, and logs.
+| Overview
+a|
+Aggregated information about the router network. This includes the following:

Review comment:
Insert a pause:

"Detailed configuration information about each AMQP management entity, for each router in the router network."

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org

[GitHub] [qpid-dispatch] asfgit closed pull request #672: DISPATCH-1555: Update doc for new console ui

Posted by GitBox <gi...@apache.org>.

asfgit closed pull request #672: DISPATCH-1555: Update doc for new console ui
URL: https://github.com/apache/qpid-dispatch/pull/672
 
 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org

[GitHub] [qpid-dispatch] jbyrne-redhat commented on a change in pull request #672: DISPATCH-1555: Update doc for new console ui

Posted by GitBox <gi...@apache.org>.

jbyrne-redhat commented on a change in pull request #672: DISPATCH-1555: Update doc for new console ui
URL: https://github.com/apache/qpid-dispatch/pull/672#discussion_r370083200

-In the web console, you use the tabs to monitor the router network.
+The web console provides several sections you can use to monitor the router network.

-| `Overview` | Aggregated information about routers, addresses, links, connections, and logs.
+| Overview
+a|
+Aggregated information about the router network. This includes the following:

Review comment:
Eliminate the article. Use the verb "see" instead of "view" to avoid confusion with the previously mentioned "graphical view".

"Graphical views of the router network. You can see the following types of visualizations."

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org