You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@trafficserver.apache.org by GitBox <gi...@apache.org> on 2021/06/03 03:21:56 UTC
[GitHub] [trafficserver] randall opened a new pull request #7916: Propagate proxy.config.net.sock_option_flag_in to accepted connections
randall opened a new pull request #7916:
URL: https://github.com/apache/trafficserver/pull/7916
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] randall closed pull request #7916: Propagate proxy.config.net.sock_option_flag_in to accepted connections
Posted by GitBox <gi...@apache.org>.
randall closed pull request #7916:
URL: https://github.com/apache/trafficserver/pull/7916
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] randall commented on pull request #7916: Propagate proxy.config.net.sock_option_flag_in to accepted connections
Posted by GitBox <gi...@apache.org>.
randall commented on pull request #7916:
URL: https://github.com/apache/trafficserver/pull/7916#issuecomment-868735659
This breaks the regression tests. It comes down to SO_LINGER being set/propagated during the tests.
I think, without this change, setting DSCP will be broken due to e65cf23015fd743cd790d9f7868a3731d62fc2a8 (which requires PACKET_TOS to be configured in `proxy.config.net.sock_option_flag_in`)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] randall commented on pull request #7916: Propagate proxy.config.net.sock_option_flag_in to accepted connections
Posted by GitBox <gi...@apache.org>.
randall commented on pull request #7916:
URL: https://github.com/apache/trafficserver/pull/7916#issuecomment-854038223
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] randall removed a comment on pull request #7916: Propagate proxy.config.net.sock_option_flag_in to accepted connections
Posted by GitBox <gi...@apache.org>.
randall removed a comment on pull request #7916:
URL: https://github.com/apache/trafficserver/pull/7916#issuecomment-854038223
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] bryancall commented on pull request #7916: Propagate proxy.config.net.sock_option_flag_in to accepted connections
Posted by GitBox <gi...@apache.org>.
bryancall commented on pull request #7916:
URL: https://github.com/apache/trafficserver/pull/7916#issuecomment-856319801
[approve ci]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] randall closed pull request #7916: Propagate proxy.config.net.sock_option_flag_in to accepted connections
Posted by GitBox <gi...@apache.org>.
randall closed pull request #7916:
URL: https://github.com/apache/trafficserver/pull/7916
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] randall commented on pull request #7916: Propagate proxy.config.net.sock_option_flag_in to accepted connections
Posted by GitBox <gi...@apache.org>.
randall commented on pull request #7916:
URL: https://github.com/apache/trafficserver/pull/7916#issuecomment-1086189908
This was superseded by #8463
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] randall edited a comment on pull request #7916: Propagate proxy.config.net.sock_option_flag_in to accepted connections
Posted by GitBox <gi...@apache.org>.
randall edited a comment on pull request #7916:
URL: https://github.com/apache/trafficserver/pull/7916#issuecomment-868735659
This breaks the regression tests. It comes down to SO_LINGER being set/propagated during the tests.
I think, without this change, setting DSCP via header_rewrite (aka `TSHttpTxnClientPacketDscpSet`) will be broken due to e65cf23015fd743cd790d9f7868a3731d62fc2a8 (which requires PACKET_TOS to be configured in `proxy.config.net.sock_option_flag_in`). Without the propagation, the bit mask check will fail.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] randall removed a comment on pull request #7916: Propagate proxy.config.net.sock_option_flag_in to accepted connections
Posted by GitBox <gi...@apache.org>.
randall removed a comment on pull request #7916:
URL: https://github.com/apache/trafficserver/pull/7916#issuecomment-854038223
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] randall commented on pull request #7916: Propagate proxy.config.net.sock_option_flag_in to accepted connections
Posted by GitBox <gi...@apache.org>.
randall commented on pull request #7916:
URL: https://github.com/apache/trafficserver/pull/7916#issuecomment-854039157
[approve ci debian]
[approve ci ubuntu]
[approve ci autest]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] randall commented on pull request #7916: Propagate proxy.config.net.sock_option_flag_in to accepted connections
Posted by GitBox <gi...@apache.org>.
randall commented on pull request #7916:
URL: https://github.com/apache/trafficserver/pull/7916#issuecomment-854038223
[approve ci centos]
[approve ci fedora]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org