You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@beam.apache.org by "TSultanov (via GitHub)" <gi...@apache.org> on 2023/03/22 14:21:08 UTC
[GitHub] [beam] TSultanov opened a new pull request, #25931: [Playground] Guard router methods from being executed on runners
TSultanov opened a new pull request, #25931:
URL: https://github.com/apache/beam/pull/25931
Exit immediately from controller methods which should not be executed when the backend is running in a runner mode
resolves #25929
------------------------
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
- [ ] Mention the appropriate issue in your description (for example: `addresses #123`), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment `fixes #<ISSUE NUMBER>` instead.
- [ ] Update `CHANGES.md` with noteworthy changes.
- [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
See the [Contributor Guide](https://beam.apache.org/contribute) for more tips on [how to make review process smoother](https://beam.apache.org/contribute/get-started-contributing/#make-the-reviewers-job-easier).
To check the build health, please visit [https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md](https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md)
GitHub Actions Tests Status (on master branch)
------------------------------------------------------------------------------------------------
[](https://github.com/apache/beam/actions?query=workflow%3A%22Build+python+source+distribution+and+wheels%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Python+Tests%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Java+Tests%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Go+tests%22+branch%3Amaster+event%3Aschedule)
See [CI.md](https://github.com/apache/beam/blob/master/CI.md) for more information about GitHub Actions CI.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] damccorm merged pull request #25931: [Playground] Guard router methods from being executed on runners
Posted by "damccorm (via GitHub)" <gi...@apache.org>.
damccorm merged PR #25931:
URL: https://github.com/apache/beam/pull/25931
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] github-actions[bot] commented on pull request #25931: [Playground] Guard router methods from being executed on runners
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #25931:
URL: https://github.com/apache/beam/pull/25931#issuecomment-1479790831
Checks are failing. Will not request review until checks are succeeding. If you'd like to override that behavior, comment `assign set of reviewers`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] olehborysevych commented on pull request #25931: [Playground] Guard router methods from being executed on runners
Posted by "olehborysevych (via GitHub)" <gi...@apache.org>.
olehborysevych commented on PR #25931:
URL: https://github.com/apache/beam/pull/25931#issuecomment-1479659159
LGTM
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] damccorm commented on a diff in pull request #25931: [Playground] Guard router methods from being executed on runners
Posted by "damccorm (via GitHub)" <gi...@apache.org>.
damccorm commented on code in PR #25931:
URL: https://github.com/apache/beam/pull/25931#discussion_r1150923517
##########
playground/backend/cmd/server/controller_test.go:
##########
@@ -64,18 +64,19 @@ const (
var lis *bufconn.Listener
var cacheService cache.Cache
var dbClient db.Database
-var opt goleak.Option
+
+// var opt goleak.Option
var ctx context.Context
func TestMain(m *testing.M) {
- server := setup()
- opt = goleak.IgnoreCurrent()
+ //server := setup()
+ //opt = goleak.IgnoreCurrent()
exitValue := m.Run()
- teardown(server)
+ //teardown(server)
Review Comment:
Instead of making these comments, can we just remove them?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org