[GitHub] [incubator-celeborn] FMX commented on a diff in pull request #1227: [CELEBORN-287] Add snapshot about memory tracker.

["FMX (via GitHub)" <gi...@apache.org>]

FMX commented on code in PR #1227:
URL: https://github.com/apache/incubator-celeborn/pull/1227#discussion_r1106960716


##########
common/src/main/java/com/aliyun/emr/rss/common/network/server/MemoryTracker.java:
##########
@@ -115,8 +114,10 @@ private MemoryTracker(
         MemoryTrackerStat lastAction = memoryTrackerStat;
         memoryTrackerStat = currentMemoryAction();
         if (lastAction != memoryTrackerStat) {
+          logger.info("MemoryTrackerStat changed {} -> {}", lastAction, memoryTrackerStat);

Review Comment:
   State change won't be a lot, so I think the info would be ok. If changed to debug, this log would be unnoticeable because the log of method "currentMemoryAction"  is huge.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org