[jira] [Commented] (ARTEMIS-3751) Artemis cuts off large bytes messages with compression that exceed the minimal large message size

["Clebert Suconic (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/ARTEMIS-3751?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17523849#comment-17523849 ] 

Clebert Suconic commented on ARTEMIS-3751:
------------------------------------------

The issue is that the message was not sent as Large Message from the client, but it became large on the server's through protecting the journal-buffer-size.


the asLargeMessage on LargeServerMessageImpl was to protect such cases, but the compressed large message was missed in there.


Nice catch.. I am merging the PR with a few adjustments.

> Artemis cuts off large bytes messages with compression that exceed the minimal large message size
> -------------------------------------------------------------------------------------------------
>
>                 Key: ARTEMIS-3751
>                 URL: https://issues.apache.org/jira/browse/ARTEMIS-3751
>             Project: ActiveMQ Artemis
>          Issue Type: Bug
>          Components: JMS
>    Affects Versions: 2.18.0, 2.20.0
>            Reporter: Alvin Kwekel
>            Priority: Major
>         Attachments: image-2022-03-30-12-21-21-351.png
>
>          Time Spent: 1.5h
>  Remaining Estimate: 0h
>
> Messages are cut off meaning that the message is only partially written to the broker. The messages are stored in incomplete form in the "large-messages" directory.  No exception is thrown. Consumers inevitably also get the incomplete partial messages.
>  
> To reproduce
> - Message size must exceed the minimal large message size
> - Message size must be less than twice the minimal large message size
> - Minimal large message size must be more than about 1MiB
> - Large message compression must be enabled
> - Message must be a JMS bytes message
> - If messages are smaller than the minimal large message size there is no issue
> - If messages are twice as big as the minimal large message size there is no issue
> - If the minimal large message size is less than about 1MiB there is no issue
> - If large messages are not compressed there is no issue
> - If the message is a text message there is no issue
> Tested with both Artemis client version 2.18.0 and 2.20.0 while my Artemis server is at 2.20.0
> I've created a project that reproduces the issues: [https://github.com/alvinkwekel/artemis-large-message-cutoff]
> !image-2022-03-30-12-21-21-351.png!
>  



--
This message was sent by Atlassian Jira
(v8.20.1#820001)