You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by GitBox <gi...@apache.org> on 2022/07/27 08:02:00 UTC
[GitHub] [doris] zhannngchen opened a new pull request, #11252: [feature-wip](unique-key-merge-on-write) update counter, DSIP-018
zhannngchen opened a new pull request, #11252:
URL: https://github.com/apache/doris/pull/11252
# Proposed changes
Issue Number: close #xxx
## Problem Summary:
The follow up patch for #11136
## Checklist(Required)
1. Type of your changes:
- [ ] Improvement
- [ ] Fix
- [x] Feature-WIP
- [ ] Feature
- [ ] Doc
- [ ] Refator
- [ ] Others:
2. Does it affect the original behavior:
- [ ] Yes
- [x] No
- [ ] I don't know
3. Has unit tests been added:
- [ ] Yes
- [ ] No
- [x] No Need
4. Has document been added or modified:
- [ ] Yes
- [ ] No
- [x] No Need
5. Does it need to update dependencies:
- [ ] Yes
- [x] No
6. Are there any changes that cannot be rolled back:
- [ ] Yes
- [x] No
## Further comments
If this is a relatively large or complex change, kick off the discussion at [dev@doris.apache.org](mailto:dev@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] BiteTheDDDDt commented on a diff in pull request #11252: [feature-wip](unique-key-merge-on-write) update counter, DSIP-018
Posted by GitBox <gi...@apache.org>.
BiteTheDDDDt commented on code in PR #11252:
URL: https://github.com/apache/doris/pull/11252#discussion_r930971749
##########
be/src/olap/rowset/segment_v2/segment_iterator.cpp:
##########
@@ -156,7 +156,9 @@ Status SegmentIterator::_init(bool is_vec) {
// Remove rows that have been marked deleted
if (_opts.delete_bitmap.count(segment_id()) > 0 &&
_opts.delete_bitmap[segment_id()] != nullptr) {
+ size_t pre_size = _row_bitmap.cardinality();
_row_bitmap -= *(_opts.delete_bitmap[segment_id()]);
Review Comment:
Sorry, I read it wrong, I read `-=` as `=` 😥
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] zhannngchen commented on pull request #11252: [feature-wip](unique-key-merge-on-write) update counter, DSIP-018
Posted by GitBox <gi...@apache.org>.
zhannngchen commented on PR #11252:
URL: https://github.com/apache/doris/pull/11252#issuecomment-1196637591
> BTW, is this pr related to #11191?
no，see the PR desc, it's a follow up patch for #11136, part of WIP feature of DSIP-018
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] zhannngchen commented on a diff in pull request #11252: [feature-wip](unique-key-merge-on-write) update counter, DSIP-018
Posted by GitBox <gi...@apache.org>.
zhannngchen commented on code in PR #11252:
URL: https://github.com/apache/doris/pull/11252#discussion_r930973619
##########
be/src/olap/rowset/segment_v2/segment_iterator.cpp:
##########
@@ -156,7 +156,9 @@ Status SegmentIterator::_init(bool is_vec) {
// Remove rows that have been marked deleted
if (_opts.delete_bitmap.count(segment_id()) > 0 &&
_opts.delete_bitmap[segment_id()] != nullptr) {
+ size_t pre_size = _row_bitmap.cardinality();
_row_bitmap -= *(_opts.delete_bitmap[segment_id()]);
Review Comment:
LOL, thanks for your review~
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] dataroaring merged pull request #11252: [feature-wip](unique-key-merge-on-write) update counter, DSIP-018
Posted by GitBox <gi...@apache.org>.
dataroaring merged PR #11252:
URL: https://github.com/apache/doris/pull/11252
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #11252: [feature-wip](unique-key-merge-on-write) update counter, DSIP-018
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #11252:
URL: https://github.com/apache/doris/pull/11252#issuecomment-1196657435
PR approved by anyone and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] zhannngchen commented on a diff in pull request #11252: [feature-wip](unique-key-merge-on-write) update counter, DSIP-018
Posted by GitBox <gi...@apache.org>.
zhannngchen commented on code in PR #11252:
URL: https://github.com/apache/doris/pull/11252#discussion_r930962924
##########
be/src/olap/rowset/segment_v2/segment_iterator.cpp:
##########
@@ -156,7 +156,9 @@ Status SegmentIterator::_init(bool is_vec) {
// Remove rows that have been marked deleted
if (_opts.delete_bitmap.count(segment_id()) > 0 &&
_opts.delete_bitmap[segment_id()] != nullptr) {
+ size_t pre_size = _row_bitmap.cardinality();
_row_bitmap -= *(_opts.delete_bitmap[segment_id()]);
Review Comment:
Why do we need such a CHECK here? Do you want to ensure that the delete_bitmap is not empty?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #11252: [feature-wip](unique-key-merge-on-write) update counter, DSIP-018
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #11252:
URL: https://github.com/apache/doris/pull/11252#issuecomment-1196657399
PR approved by at least one committer and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] BiteTheDDDDt commented on pull request #11252: [feature-wip](unique-key-merge-on-write) update counter, DSIP-018
Posted by GitBox <gi...@apache.org>.
BiteTheDDDDt commented on PR #11252:
URL: https://github.com/apache/doris/pull/11252#issuecomment-1196634512
BTW, is this pr related to #11191?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org