You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@jena.apache.org by afs <gi...@git.apache.org> on 2015/05/01 11:30:00 UTC

[GitHub] jena pull request: jena-text multilingual indexing (take 2)

Github user afs commented on the pull request:

    https://github.com/apache/jena/pull/52#issuecomment-98085046
  
    Hi - this is looking good.
    
    Merge conflicts arise because of the Jena3 migration.  Any packages "com.hp.hpl.jena" have become "org.apache.jena". Don't worry about that, we can fix that up easily enough.  I just checked the current state and replacing "com.hp.hpl.jena" by "org.apache.jena" resulted in a valid patch.
    
    About tests and documentation - it's quite important to have these so that future changes in and around jena-text don't accidentally break things and so people can find the feature.  The documentation does not need to be large.
    
    I've create [JENA-928](https://issues.apache.org/jira/browse/JENA-928) to track this.
    
    @amiara514 Would it help if I created a branch in the codebase so that we're working against that as a reference point?
    



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---