You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@netbeans.apache.org by GitBox <gi...@apache.org> on 2020/11/03 13:40:10 UTC
[GitHub] [netbeans] dbalek opened a new pull request #2515: Setting the icon and categories for VSCode extension.
dbalek opened a new pull request #2515:
URL: https://github.com/apache/netbeans/pull/2515
Before going to [Marketplace](https://marketplace.visualstudio.com/), the Apache NetBeans Language Server extension should provide an icon and search categories.
Updating the records in package.json.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] dbalek commented on pull request #2515: Setting the icon and categories for VSCode extension.
Posted by GitBox <gi...@apache.org>.
dbalek commented on pull request #2515:
URL: https://github.com/apache/netbeans/pull/2515#issuecomment-721270791
> I'm just wondering how this one passed the license check of Travis...
> Please update the licenseinfo.xml with the logo, just to be on the safe side.
Done.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] JaroslavTulach commented on a change in pull request #2515: Setting the icon, categories, and renaming debug configuration for VSCode extension.
Posted by GitBox <gi...@apache.org>.
JaroslavTulach commented on a change in pull request #2515:
URL: https://github.com/apache/netbeans/pull/2515#discussion_r517281093
##########
File path: java/java.lsp.server/vscode/package.json
##########
@@ -65,8 +65,8 @@
],
"debuggers": [
{
- "type": "java-polyglot",
- "label": "Java (Polyglot)",
+ "type": "java8+",
+ "label": "Java 8+",
Review comment:
The "Java 8+" name seems to nicely stress the core functionality of Apache NetBeans Language Server VSCode extension - e.g. the ability to run on JDK8 (other extensions require JDK11). I think it is a good name.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] lkishalmi merged pull request #2515: Setting the icon, categories, and renaming debug configuration for VSCode extension.
Posted by GitBox <gi...@apache.org>.
lkishalmi merged pull request #2515:
URL: https://github.com/apache/netbeans/pull/2515
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists