You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by GitBox <gi...@apache.org> on 2022/05/16 07:28:57 UTC
[GitHub] [camel-quarkus] JiriOndrusek opened a new issue, #3790: Improve camel-quarkus-velocity test coverage
JiriOndrusek opened a new issue, #3790:
URL: https://github.com/apache/camel-quarkus/issues/3790
Add tests for:
- Custom Velocity context
- Dynamic templates
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] JiriOndrusek commented on issue #3790: Improve camel-quarkus-velocity test coverage
Posted by GitBox <gi...@apache.org>.
JiriOndrusek commented on issue #3790:
URL: https://github.com/apache/camel-quarkus/issues/3790#issuecomment-1130082032
I'll look at that, thanks for the point.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] aldettinger commented on issue #3790: Improve camel-quarkus-velocity test coverage
Posted by GitBox <gi...@apache.org>.
aldettinger commented on issue #3790:
URL: https://github.com/apache/camel-quarkus/issues/3790#issuecomment-1129984896
I remember scenarios where velocity is using a lot of reflection. Then, I wonder if it would would be interesting to add more coverage based on camel tests above ?
https://github.com/apache/camel/blob/main/components/camel-velocity/src/test/java/org/apache/camel/component/velocity/VelocityMethodInvokationTest.java
https://github.com/apache/camel/blob/main/components/camel-velocity/src/test/java/org/apache/camel/component/velocity/VelocityBodyAsDomainObjectTest.java
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] aldettinger commented on issue #3790: Improve camel-quarkus-velocity test coverage
Posted by GitBox <gi...@apache.org>.
aldettinger commented on issue #3790:
URL: https://github.com/apache/camel-quarkus/issues/3790#issuecomment-1130080726
@JiriOndrusek Good point. I've double-checked and actually the camel-quarkus `testBodyAsDomainObject` is already covering both. The involved classes just need to be marked as @RegisterForReflection.
I wonder if a cq-velocity specific doc statement would be needed to document that ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] JiriOndrusek commented on issue #3790: Improve camel-quarkus-velocity test coverage
Posted by GitBox <gi...@apache.org>.
JiriOndrusek commented on issue #3790:
URL: https://github.com/apache/camel-quarkus/issues/3790#issuecomment-1130091672
There is no mention of registering for reflection in the doc - https://github.com/apache/camel-quarkus/blob/main/extensions/velocity/runtime/src/main/doc/configuration.adoc
I'll add a chapter about it and ammend it to this PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] jamesnetherton closed issue #3790: Improve camel-quarkus-velocity test coverage
Posted by GitBox <gi...@apache.org>.
jamesnetherton closed issue #3790: Improve camel-quarkus-velocity test coverage
URL: https://github.com/apache/camel-quarkus/issues/3790
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] JiriOndrusek commented on issue #3790: Improve camel-quarkus-velocity test coverage
Posted by GitBox <gi...@apache.org>.
JiriOndrusek commented on issue #3790:
URL: https://github.com/apache/camel-quarkus/issues/3790#issuecomment-1130026185
@aldettinger I can try that. I made the tests according to the documentation.
Just for your information, there is a lot of coverage already in the repository.
For example https://github.com/apache/camel-quarkus/blob/main/integration-tests/velocity/src/test/java/org/apache/camel/quarkus/component/velocity/it/VelocityTest.java#L79 and https://github.com/apache/camel-quarkus/blob/main/integration-tests/velocity/src/test/java/org/apache/camel/quarkus/component/velocity/it/VelocityTest.java#L129
(which at first glance should cover both tests you mentioned)
This PR only adds 2 missing configuration options which were not covered so far.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org