You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@couchdb.apache.org by GitBox <gi...@apache.org> on 2022/01/31 08:42:01 UTC
[GitHub] [couchdb] big-r81 opened a new pull request #3920: Update CONTRIBUTING.md
big-r81 opened a new pull request #3920:
URL: https://github.com/apache/couchdb/pull/3920
<!-- Thank you for your contribution!
Please file this form by replacing the Markdown comments
with your text. If a section needs no action - remove it.
Also remember, that CouchDB uses the Review-Then-Commit (RTC) model
of code collaboration. Positive feedback is represented +1 from committers
and negative is a -1. The -1 also means veto, and needs to be addressed
to proceed. Once there are no objections, the PR can be merged by a
CouchDB committer.
See: http://couchdb.apache.org/bylaws.html#decisions for more info. -->
## Overview
- rename master to main
- fixing inline links
<!-- Please give a short brief for the pull request,
what problem it solves or how it makes things better. -->
## Testing recommendations
<!-- Describe how we can test your changes.
Does it provides any behaviour that the end users
could notice? -->
## Related Issues or Pull Requests
<!-- If your changes affects multiple components in different
repositories please put links to those issues or pull requests here. -->
## Checklist
- [ ] Code is written and works correctly
- [ ] Changes are covered by tests
- [ ] Any new configurable parameters are documented in `rel/overlay/etc/default.ini`
- [ ] A PR for documentation changes has been made in https://github.com/apache/couchdb-documentation
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@couchdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [couchdb] big-r81 commented on a change in pull request #3920: Update CONTRIBUTING.md
Posted by GitBox <gi...@apache.org>.
big-r81 commented on a change in pull request #3920:
URL: https://github.com/apache/couchdb/pull/3920#discussion_r795520665
##########
File path: CONTRIBUTING.md
##########
@@ -238,7 +238,7 @@ If you have commit access, please follow this process for merging patches and cu
8. If the commit messages follow [our conventions](@commit-message-conventions)
Review comment:
If someone of the core members have a link to a document with conventions, i would update the link too.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@couchdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [couchdb] nickva commented on a change in pull request #3920: Update CONTRIBUTING.md
Posted by GitBox <gi...@apache.org>.
nickva commented on a change in pull request #3920:
URL: https://github.com/apache/couchdb/pull/3920#discussion_r800079400
##########
File path: CONTRIBUTING.md
##########
@@ -238,7 +238,7 @@ If you have commit access, please follow this process for merging patches and cu
8. If the commit messages follow [our conventions](@commit-message-conventions)
Review comment:
Thanks for noticing @big-r81 and for starting the discussion https://github.com/apache/couchdb/discussions/3918
I suggested to use some minimal rules here. Wonder what others think
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@couchdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [couchdb] nickva commented on a change in pull request #3920: Update CONTRIBUTING.md
Posted by GitBox <gi...@apache.org>.
nickva commented on a change in pull request #3920:
URL: https://github.com/apache/couchdb/pull/3920#discussion_r801008568
##########
File path: CONTRIBUTING.md
##########
@@ -238,7 +238,7 @@ If you have commit access, please follow this process for merging patches and cu
8. If the commit messages follow [our conventions](@commit-message-conventions)
Review comment:
Looks like we might have a proposal for commit message guidelines in the discussion. @big-r81 if you get a chance, mind updating the PR with it so we can see how it looks? Up to you if it would look better as a paragraph or a section somewhere.
Thank you again for contributing and for staring the discussion around this issue. It's much appreciated!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@couchdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [couchdb] big-r81 commented on a change in pull request #3920: Update CONTRIBUTING.md
Posted by GitBox <gi...@apache.org>.
big-r81 commented on a change in pull request #3920:
URL: https://github.com/apache/couchdb/pull/3920#discussion_r802610262
##########
File path: CONTRIBUTING.md
##########
@@ -238,7 +238,7 @@ If you have commit access, please follow this process for merging patches and cu
8. If the commit messages follow [our conventions](@commit-message-conventions)
Review comment:
Hi @nickva , I added your hints from the discussion. Please take a look.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@couchdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [couchdb] nickva merged pull request #3920: Update CONTRIBUTING.md
Posted by GitBox <gi...@apache.org>.
nickva merged pull request #3920:
URL: https://github.com/apache/couchdb/pull/3920
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@couchdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org