[GitHub] ivankelly commented on a change in pull request #970: ISSUE #966: Expose quorum write complete latency to the client

[GitBox <gi...@apache.org>]

ivankelly commented on a change in pull request #970: ISSUE #966: Expose quorum write complete latency to the client
URL: https://github.com/apache/bookkeeper/pull/970#discussion_r162753724
 
 

 ##########
 File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/client/LedgerHandleAdv.java
 ##########
 @@ -152,8 +153,33 @@ public void asyncAddEntry(final long entryId, final byte[] data, final int offse
         asyncAddEntry(entryId, Unpooled.wrappedBuffer(data, offset, length), cb, ctx);
     }
 
+    /**
+     * Add entry asynchronously to an open ledger, using an offset and range.
+     *
+     * @param entryId
+     *            entryId of the entry to add
+     * @param data
+     *            array of bytes to be written
+     * @param offset
+     *            offset from which to take bytes from data
+     * @param length
+     *            number of bytes to take from data
+     * @param cb
+     *            object implementing callbackinterface
+     * @param ctx
+     *            some control object
+     * @throws ArrayIndexOutOfBoundsException
+     *             if offset or length is negative or offset and length sum to a
+     *             value higher than the length of data.
+     */
+    @Override
+    public void asyncAddEntry(final long entryId, final byte[] data, final int offset, final int length,
 
 Review comment:
   is it possible to annotate this method with Evolving interface stability? 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services