You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudstack.apache.org by GitBox <gi...@apache.org> on 2021/10/21 01:58:31 UTC
[GitHub] [cloudstack] utchoang opened a new pull request #5597: UI - Hidden features checkbox as user role
utchoang opened a new pull request #5597:
URL: https://github.com/apache/cloudstack/pull/5597
### Description
Fixes https://github.com/apache/cloudstack/issues/5591
<!--- Describe your changes in DETAIL - And how has behaviour functionally changed. -->
<!-- For new features, provide link to FS, dev ML discussion etc. -->
<!-- In case of bug fix, the expected and actual behaviours, steps to reproduce. -->
<!-- When "Fixes: #<id>" is specified, the issue/PR will automatically be closed when this PR gets merged -->
<!-- For addressing multiple issues/PRs, use multiple "Fixes: #<id>" -->
<!-- Fixes: # -->
<!--- ********************************************************************************* -->
<!--- NOTE: AUTOMATATION USES THE DESCRIPTIONS TO SET LABELS AND PRODUCE DOCUMENTATION. -->
<!--- PLEASE PUT AN 'X' in only **ONE** box -->
<!--- ********************************************************************************* -->
### Types of changes
- [ ] Breaking change (fix or feature that would cause existing functionality to change)
- [ ] New feature (non-breaking change which adds functionality)
- [x] Bug fix (non-breaking change which fixes an issue)
- [ ] Enhancement (improves an existing feature and functionality)
- [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
### Feature/Enhancement Scale or Bug Severity
#### Feature/Enhancement Scale
- [ ] Major
- [x] Minor
#### Bug Severity
- [ ] BLOCKER
- [ ] Critical
- [ ] Major
- [x] Minor
- [ ] Trivial
### Screenshots (if appropriate):


### How Has This Been Tested?
<!-- Please describe in detail how you tested your changes. -->
<!-- Include details of your testing environment, and the tests you ran to -->
<!-- see how your change affects other areas of the code, etc. -->
<!-- Please read the [CONTRIBUTING](https://github.com/apache/cloudstack/blob/main/CONTRIBUTING.md) document -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on a change in pull request #5597: UI - Hidden features checkbox as user role
Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on a change in pull request #5597:
URL: https://github.com/apache/cloudstack/pull/5597#discussion_r733385863
##########
File path: ui/src/views/image/RegisterOrUploadTemplate.vue
##########
@@ -363,7 +363,7 @@
</a-checkbox>
</a-col>
</a-row>
- <a-row>
+ <a-row v-if="$store.getters.userInfo.roletype === 'Admin'">
Review comment:
this means a user cannot make templates public in the checkbox below, even when it is allowed by the global config.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] utchoang removed a comment on pull request #5597: UI - Hidden features checkbox as user role
Posted by GitBox <gi...@apache.org>.
utchoang removed a comment on pull request #5597:
URL: https://github.com/apache/cloudstack/pull/5597#issuecomment-948197732
@blueorangutan ui
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd merged pull request #5597: UI - Hidden features checkbox as user role
Posted by GitBox <gi...@apache.org>.
rhtyd merged pull request #5597:
URL: https://github.com/apache/cloudstack/pull/5597
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] utchoang commented on pull request #5597: UI - Hidden features checkbox as user role
Posted by GitBox <gi...@apache.org>.
utchoang commented on pull request #5597:
URL: https://github.com/apache/cloudstack/pull/5597#issuecomment-948337439
@blueorangutan ui
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5597: UI - Hidden features checkbox as user role
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5597:
URL: https://github.com/apache/cloudstack/pull/5597#issuecomment-948346110
UI build: :heavy_check_mark:
Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/5597 (SL-JID-771)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5597: UI - Hidden features checkbox as user role
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5597:
URL: https://github.com/apache/cloudstack/pull/5597#issuecomment-948244686
@utchoang a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5597: UI - Hidden features checkbox as user role
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5597:
URL: https://github.com/apache/cloudstack/pull/5597#issuecomment-948246674
UI build: :heavy_check_mark:
Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/5597 (SL-JID-770)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] utchoang commented on a change in pull request #5597: UI - Hidden features checkbox as user role
Posted by GitBox <gi...@apache.org>.
utchoang commented on a change in pull request #5597:
URL: https://github.com/apache/cloudstack/pull/5597#discussion_r733389106
##########
File path: ui/src/views/image/RegisterOrUploadTemplate.vue
##########
@@ -363,7 +363,7 @@
</a-checkbox>
</a-col>
</a-row>
- <a-row>
+ <a-row v-if="$store.getters.userInfo.roletype === 'Admin'">
Review comment:
Ah, I misunderstood this place, will fix it now
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5597: UI - Hidden features checkbox as user role
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5597:
URL: https://github.com/apache/cloudstack/pull/5597#issuecomment-948337945
@utchoang a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on a change in pull request #5597: UI - Hidden features checkbox as user role
Posted by GitBox <gi...@apache.org>.
rhtyd commented on a change in pull request #5597:
URL: https://github.com/apache/cloudstack/pull/5597#discussion_r733403089
##########
File path: ui/src/views/image/RegisterOrUploadIso.vue
##########
@@ -144,17 +144,11 @@
<a-form-item
:label="$t('label.ispublic')"
v-if="$store.getters.userInfo.roletype === 'Admin' || $store.getters.features.userpublictemplateenabled" >
- <a-switch
- v-decorator="['ispublic', {
- initialValue: false
- }]" />
+ <a-switch v-decorator="['ispublic', { initialValue: false }]" />
</a-form-item>
- <a-form-item :label="$t('label.isfeatured')">
- <a-switch
- v-decorator="['isfeatured', {
- initialValue: false
- }]" />
+ <a-form-item :label="$t('label.isfeatured')" v-if="$store.getters.userInfo.roletype === 'Admin'">
Review comment:
@utchoang cc @Pearl1594 @borisstoyanov should there be a check to see if admin has allowed this, say via some global setting? (I'm not sure if such a global setting or capabilities exists, so asking)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] utchoang commented on pull request #5597: UI - Hidden features checkbox as user role
Posted by GitBox <gi...@apache.org>.
utchoang commented on pull request #5597:
URL: https://github.com/apache/cloudstack/pull/5597#issuecomment-948224389
@blueorangutan ui
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] utchoang commented on pull request #5597: UI - Hidden features checkbox as user role
Posted by GitBox <gi...@apache.org>.
utchoang commented on pull request #5597:
URL: https://github.com/apache/cloudstack/pull/5597#issuecomment-948197732
@blueorangutan ui
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org