You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2020/10/26 07:22:39 UTC
[GitHub] [pulsar] eolivelli opened a new pull request #8370: Do not use "star import" for org.apache.pulsar.functions.api.Record in order to be able to build Pulsar on JDK14+
eolivelli opened a new pull request #8370:
URL: https://github.com/apache/pulsar/pull/8370
### Motivation
JDK14 introduced java.lang.Record, that is imported by default as "Record".
The build fails in some .java files due to the ambiguity between org.apache.pulsar.functions.api.Record and java.lang.Record.
### Modifications
Use explicit imports instead of star import, only in the Java files that break the build.
### Verifying this change
This change is a trivial rework / code cleanup without any test coverage.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] eolivelli commented on pull request #8370: Do not use "star import" for org.apache.pulsar.functions.api.Record in order to be able to build Pulsar on JDK14+
Posted by GitBox <gi...@apache.org>.
eolivelli commented on pull request #8370:
URL: https://github.com/apache/pulsar/pull/8370#issuecomment-716427637
/pulsarbot rerun-failure-checks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] eolivelli commented on pull request #8370: Do not use "star import" for org.apache.pulsar.functions.api.Record in order to be able to build Pulsar on JDK14+
Posted by GitBox <gi...@apache.org>.
eolivelli commented on pull request #8370:
URL: https://github.com/apache/pulsar/pull/8370#issuecomment-716412486
/pulsarbot rerun-failure-checks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] merlimat merged pull request #8370: Do not use "star import" for org.apache.pulsar.functions.api.Record in order to be able to build Pulsar on JDK14+
Posted by GitBox <gi...@apache.org>.
merlimat merged pull request #8370:
URL: https://github.com/apache/pulsar/pull/8370
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] eolivelli commented on pull request #8370: Do not use "star import" for org.apache.pulsar.functions.api.Record in order to be able to build Pulsar on JDK14+
Posted by GitBox <gi...@apache.org>.
eolivelli commented on pull request #8370:
URL: https://github.com/apache/pulsar/pull/8370#issuecomment-716532093
/pulsarbot rerun-failure-checks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] eolivelli commented on pull request #8370: Do not use "star import" for org.apache.pulsar.functions.api.Record in order to be able to build Pulsar on JDK14+
Posted by GitBox <gi...@apache.org>.
eolivelli commented on pull request #8370:
URL: https://github.com/apache/pulsar/pull/8370#issuecomment-716532277
I have sent a separate fix for the flaky test
https://github.com/apache/pulsar/pull/8379
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] eolivelli commented on pull request #8370: Do not use "star import" for org.apache.pulsar.functions.api.Record in order to be able to build Pulsar on JDK14+
Posted by GitBox <gi...@apache.org>.
eolivelli commented on pull request #8370:
URL: https://github.com/apache/pulsar/pull/8370#issuecomment-716657760
I had another change about upgrading checkstyle to latest version.
It would be a quite huge patch (and boring work) because they changed the ImportOrder rule
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] eolivelli commented on pull request #8370: Do not use "star import" for org.apache.pulsar.functions.api.Record in order to be able to build Pulsar on JDK14+
Posted by GitBox <gi...@apache.org>.
eolivelli commented on pull request #8370:
URL: https://github.com/apache/pulsar/pull/8370#issuecomment-716494647
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] eolivelli commented on pull request #8370: Do not use "star import" for org.apache.pulsar.functions.api.Record in order to be able to build Pulsar on JDK14+
Posted by GitBox <gi...@apache.org>.
eolivelli commented on pull request #8370:
URL: https://github.com/apache/pulsar/pull/8370#issuecomment-716448590
/pulsarbot rerun-failure-checks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] eolivelli commented on pull request #8370: Do not use "star import" for org.apache.pulsar.functions.api.Record in order to be able to build Pulsar on JDK14+
Posted by GitBox <gi...@apache.org>.
eolivelli commented on pull request #8370:
URL: https://github.com/apache/pulsar/pull/8370#issuecomment-716361341
I am trying to split the patch into smaller pieces because in #8360 integration tests and other CI jobs does not pass, probably due to the upgrade of the Maven Assembly plugin.
I am going to send a separate patch for the Maven Assembly Plugin stuff.
@merlimat you already approved #8360, hopefully here the tests will pass without problem (otherwise we have serious issues on CI), PTAL and merge if you can. thanks in advance
cc @codelipenghui @rdhabalia @jiazhai
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] eolivelli commented on pull request #8370: Do not use "star import" for org.apache.pulsar.functions.api.Record in order to be able to build Pulsar on JDK14+
Posted by GitBox <gi...@apache.org>.
eolivelli commented on pull request #8370:
URL: https://github.com/apache/pulsar/pull/8370#issuecomment-716525812
/pulsarbot rerun-failure-checks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org