You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@hudi.apache.org by GitBox <gi...@apache.org> on 2022/03/07 09:20:13 UTC

[GitHub] [hudi] danny0405 commented on a change in pull request #4936: [HUDI-3573] flink cleanFuntion execute clean on initialization

danny0405 commented on a change in pull request #4936:
URL: https://github.com/apache/hudi/pull/4936#discussion_r820513269



##########
File path: hudi-flink/src/main/java/org/apache/hudi/table/HoodieTableSink.java
##########
@@ -136,5 +136,8 @@ public void applyOverwrite(boolean overwrite) {
     // set up the operation as INSERT_OVERWRITE_TABLE first,
     // if there are explicit partitions, #applyStaticPartition would overwrite the option.
     this.conf.setString(FlinkOptions.OPERATION, WriteOperationType.INSERT_OVERWRITE_TABLE.value());
+    // set up clean eager if clean async enabled
+    this.conf.setBoolean(FlinkOptions.CLEAN_ASYNC_EAGER_ENABLED, true);
+

Review comment:
       Maybe we can check the operation as `WriteOperationType.INSERT_OVERWRITE_TABLE` directly so that the option is not needed.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org